Handle intentional task failures properly

Bug #1633438 reported by Jesse Pretorius
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Kevin Carter

Bug Description

We have many tasks spread across many roles which intentionally fail, using 'failed_when: false'. Most of these generate output in the Ansible output which looks like an error and is very confusing to anyone seeing it for the first time. Even worse it requires walking the code or very carefully reading the output to see that it's an intentional fail which is OK.

We should take the time to handle these more gracefully and prevent output that looks like a failure. This improves our usability and causes less confusion to newcomers.

Some examples from https://review.openstack.org/386128 / http://logs.openstack.org/28/386128/1/check/gate-openstack-ansible-openstack-ansible-aio-ubuntu-trusty/4df3caa/console.html

2016-10-13 18:22:58.256281 | TASK [bootstrap-host : Determine whether partitions labeled openstack-data{1,2} are present] ***
2016-10-13 18:22:58.440644 | fatal: [localhost]: FAILED! => {"changed": false, "cmd": "parted --script -l -m | egrep -q ':ext4:openstack-data[12]:;$'", "delta": "0:00:00.010736", "end": "2016-10-13 18:22:58.401710", "failed": true, "rc": 1, "start": "2016-10-13 18:22:58.390974", "stderr": "", "stdout": "", "stdout_lines": [], "warnings": []}
2016-10-13 18:22:58.440771 | ...ignoring

2016-10-13 18:50:59.802765 | TASK [galera_server : Check major galera install version] **********************
2016-10-13 18:51:00.340879 | fatal: [aio1_galera_container-fbdcb707]: FAILED! => {"changed": true, "cmd": ["dpkg", "-s", "mariadb-galera-server-10.0"], "delta": "0:00:00.011568", "end": "2016-10-13 18:51:00.164284", "failed": true, "rc": 1, "start": "2016-10-13 18:51:00.152716", "stderr": "dpkg-query: package 'mariadb-galera-server-10.0' is not installed and no information is available\nUse dpkg --info (= dpkg-deb --info) to examine archive files,\nand dpkg --contents (= dpkg-deb --contents) to list their contents.", "stdout": "", "stdout_lines": [], "warnings": []}
2016-10-13 18:51:00.341304 | ...ignoring
2016-10-13 18:51:00.350742 |
2016-10-13 18:51:00.350793 | TASK [galera_server : Check for any galera install version] ********************
2016-10-13 18:51:00.894828 | fatal: [aio1_galera_container-fbdcb707]: FAILED! => {"changed": true, "cmd": "dpkg --get-selections | grep mariadb-galera-server", "delta": "0:00:00.012244", "end": "2016-10-13 18:51:00.720672", "failed": true, "rc": 1, "start": "2016-10-13 18:51:00.708428", "stderr": "", "stdout": "", "stdout_lines": [], "warnings": []}
2016-10-13 18:51:00.895223 | ...ignoring

2016-10-13 18:51:05.227996 | TASK [galera_server : Gather mysql facts] **************************************
2016-10-13 18:51:05.710802 | fatal: [aio1_galera_container-fbdcb707]: FAILED! => {"changed": false, "failed": true, "msg": "Mysql fact collection failed: \"ERROR 2003 (HY000): Can't connect to MySQL server on '127.0.0.1' (111 \"Connection refused\")\"."}
2016-10-13 18:51:05.711187 | ...ignoring

2016-10-13 18:58:53.882361 | TASK [os_keystone : Enable/disable mod_shib2 for apache2] **********************
2016-10-13 18:58:54.362767 | fatal: [aio1_keystone_container-5c43f682]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to disable module shib2: "}
2016-10-13 18:58:54.363169 | ...ignoring

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386792

Changed in openstack-ansible:
assignee: nobody → Kevin Carter (kevin-carter)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-ceph_client (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386793

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-galera_client (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386794

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-galera_server (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386795

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-haproxy_server (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386796

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-lxc_container_create (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386797

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-lxc_hosts (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386798

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-openstack_hosts (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386799

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_aodh (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386801

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386803

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cloudkitty (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386805

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386806

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_gnocchi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386808

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386809

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386810

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386811

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386812

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386813

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386814

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386815

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386816

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386818

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386822

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386824

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386825

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_lock_down (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386826

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-rabbitmq_server (master)

Fix proposed to branch: master
Review: https://review.openstack.org/386827

Changed in openstack-ansible:
assignee: Kevin Carter (kevin-carter) → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-ansible-pip_lock_down (master)

Change abandoned by Jesse Pretorius (odyssey4me) (<email address hidden>) on branch: master
Review: https://review.openstack.org/386826
Reason: This repo has been retired.

Changed in openstack-ansible:
assignee: Jesse Pretorius (jesse-pretorius) → Kevin Carter (kevin-carter)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-haproxy_server (master)

Reviewed: https://review.openstack.org/386796
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-haproxy_server/commit/?id=696056db674d06a855566e81e2fcc1a889c13a97
Submitter: Jenkins
Branch: master

commit 696056db674d06a855566e81e2fcc1a889c13a97
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:03 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I460b4eb12c30d66769f3093a451dc39c77150ea3
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-openstack_hosts (master)

Reviewed: https://review.openstack.org/386799
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=84587efdc8db5de1d1117c948afd45ee6dc7eec5
Submitter: Jenkins
Branch: master

commit 84587efdc8db5de1d1117c948afd45ee6dc7eec5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:22 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Icd0afaaf8f0d9c5e06751f284f99985af6a924c6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-galera_client (master)

Reviewed: https://review.openstack.org/386794
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=9dc6e60247b0f43ce8328743a6ead422e4415457
Submitter: Jenkins
Branch: master

commit 9dc6e60247b0f43ce8328743a6ead422e4415457
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:45 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I2c1b39905720e8e6ecb51d88f36c9eb47329d328
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (master)

Reviewed: https://review.openstack.org/386825
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=c45165acd3581203e7ac0b6dfcf6c7c90ca3d3cc
Submitter: Jenkins
Branch: master

commit c45165acd3581203e7ac0b6dfcf6c7c90ca3d3cc
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:45 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Iab6a4e4be29ae358cc95d94eb1090a7963a925df
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-lxc_hosts (master)

Reviewed: https://review.openstack.org/386798
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=6642af670f67e30c99e03cf3ebcade5fc79bf811
Submitter: Jenkins
Branch: master

commit 6642af670f67e30c99e03cf3ebcade5fc79bf811
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:13 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I298510082bcecb0b84eb252851f8044d8b7f7f61
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-galera_server (master)

Reviewed: https://review.openstack.org/386795
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=5038acc3907c75d6a5ff1af6382e5abec4ea1650
Submitter: Jenkins
Branch: master

commit 5038acc3907c75d6a5ff1af6382e5abec4ea1650
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:57 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I2a40fa9a0da45602a76f2d56611971fcf4063512
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_trove (master)

Reviewed: https://review.openstack.org/386822
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=91c6088783da7312a5c10a00b9e925c42a6e4601
Submitter: Jenkins
Branch: master

commit 91c6088783da7312a5c10a00b9e925c42a6e4601
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:28 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ic24c9ee327c7293753dd7b7fba4cde1987722f5f
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_gnocchi (master)

Reviewed: https://review.openstack.org/386808
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_gnocchi/commit/?id=4c438e8f135bb9b0d517f15953506052f9d8bf3c
Submitter: Jenkins
Branch: master

commit 4c438e8f135bb9b0d517f15953506052f9d8bf3c
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:15 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I73eb17072f243d3a14eee148ec8205bc1aee71f8
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-lxc_container_create (master)

Reviewed: https://review.openstack.org/386797
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_container_create/commit/?id=9db66dbee7841453fac12df52cfe6e33f4f64fde
Submitter: Jenkins
Branch: master

commit 9db66dbee7841453fac12df52cfe6e33f4f64fde
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:08 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ia5c6d38a33e96c969116606859a9a60c6a79a663
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_zaqar (master)

Reviewed: https://review.openstack.org/386824
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_zaqar/commit/?id=6a2d0be83a12ae091b90705a8d154302d434464f
Submitter: Jenkins
Branch: master

commit 6a2d0be83a12ae091b90705a8d154302d434464f
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:40 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Iafffee89b2629643799efd1e2fa233de9ca281f6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_rally (master)

Reviewed: https://review.openstack.org/386816
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_rally/commit/?id=4cd19d9ce8e90084d779956ee25a2ed41e37b9ea
Submitter: Jenkins
Branch: master

commit 4cd19d9ce8e90084d779956ee25a2ed41e37b9ea
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:03 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I5986a6588788b09501935fcd0fc18b96531bdca2
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_heat (master)

Reviewed: https://review.openstack.org/386809
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_heat/commit/?id=5a18f13b478b4fc8266aac2d0ff086f42f801b93
Submitter: Jenkins
Branch: master

commit 5a18f13b478b4fc8266aac2d0ff086f42f801b93
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:21 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ida40e2f232676906014471a87954c66f115ab018
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_watcher (master)

Reviewed: https://review.openstack.org/386823
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_watcher/commit/?id=eaac2a2eccf504d26ac51cca8099225d15f928bc
Submitter: Jenkins
Branch: master

commit eaac2a2eccf504d26ac51cca8099225d15f928bc
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:33 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I9f973a7ab43d12eb002b0843552bf20b38d8cc6d
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_aodh (master)

Reviewed: https://review.openstack.org/386800
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=df77794138f8a8972ad5529bfc568a47a37951ac
Submitter: Jenkins
Branch: master

commit df77794138f8a8972ad5529bfc568a47a37951ac
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:39 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I336c2b8da5ebb6358e2158ebc33f340e2713aad6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_glance (master)

Reviewed: https://review.openstack.org/386807
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=bb58d18a39cb06b0aea0bef3b1bbb2c1ea13a9f7
Submitter: Jenkins
Branch: master

commit bb58d18a39cb06b0aea0bef3b1bbb2c1ea13a9f7
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:10 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ie6f04bac9023d9f97b80f8de6911f09c338f3027
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cloudkitty (master)

Reviewed: https://review.openstack.org/386805
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cloudkitty/commit/?id=e96f805c6f0c60ab307cf0d6e0bcf68ea397858b
Submitter: Jenkins
Branch: master

commit e96f805c6f0c60ab307cf0d6e0bcf68ea397858b
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:00 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I9b2a7c6ca8ea0f69ca7defc7266c17be224b4b9e
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-rabbitmq_server (master)

Reviewed: https://review.openstack.org/386827
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=98e7bca1fb58f6eeb7cb60e20b1dad03aa04e4cd
Submitter: Jenkins
Branch: master

commit 98e7bca1fb58f6eeb7cb60e20b1dad03aa04e4cd
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:47:04 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I34f49f829a61e25393fcec6b047aa28858c8eeb6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_horizon (master)

Reviewed: https://review.openstack.org/386810
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=5abc1e2e808b87a22698a81b6420081f57349230
Submitter: Jenkins
Branch: master

commit 5abc1e2e808b87a22698a81b6420081f57349230
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:27 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I04d02d4b2b85a10e2dc715e4f68dc8b26e258504
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_barbican (master)

Reviewed: https://review.openstack.org/386801
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_barbican/commit/?id=fb8be52a86e0ebac6f2cf02e527678fcfeef278a
Submitter: Jenkins
Branch: master

commit fb8be52a86e0ebac6f2cf02e527678fcfeef278a
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:44 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I4f26f58eae798b92d5c0269eb142445b464ce4e8
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_swift (master)

Reviewed: https://review.openstack.org/386819
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=e7dd1eb0cbf0275a46ddd73391f846978df953eb
Submitter: Jenkins
Branch: master

commit e7dd1eb0cbf0275a46ddd73391f846978df953eb
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:14 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Idb837672142c26d0198bf914abab900fcade7ccb
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_designate (master)

Reviewed: https://review.openstack.org/386806
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_designate/commit/?id=8763039a0ebddce706c20ed1d8231c5ac08a69e8
Submitter: Jenkins
Branch: master

commit 8763039a0ebddce706c20ed1d8231c5ac08a69e8
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:04 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I8e171fff9f83314caec5a5ec5173555e85f12676
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (master)

Reviewed: https://review.openstack.org/386812
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=6c902fc47191d3918658171504eb0d1cd751175d
Submitter: Jenkins
Branch: master

commit 6c902fc47191d3918658171504eb0d1cd751175d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:37 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I5ceece61312e2bf39d7489261bca247f353d6d74
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cinder (master)

Reviewed: https://review.openstack.org/386803
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=08696779b08f73ffa5a279843c15d3babf626dec
Submitter: Jenkins
Branch: master

commit 08696779b08f73ffa5a279843c15d3babf626dec
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:55 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I86f1c186caef114ee6fe7f753db92084b5d24d7d
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_neutron (master)

Reviewed: https://review.openstack.org/386814
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=7849c7d8e39010a6a77e738a5110aea3adbd8c37
Submitter: Jenkins
Branch: master

commit 7849c7d8e39010a6a77e738a5110aea3adbd8c37
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:52 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I0e6b5fc5b10e379485cec5c58acca4b315d4a6c4
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_tempest (master)

Reviewed: https://review.openstack.org/386821
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=0827b69aa716079660bc5bd736389140792fa16e
Submitter: Jenkins
Branch: master

commit 0827b69aa716079660bc5bd736389140792fa16e
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:23 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I9ce8a41be134eaff336f6da7886db8461f333953
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (master)

Reviewed: https://review.openstack.org/386815
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=4253d20418496ef7dac054f308a4e0df334a9776
Submitter: Jenkins
Branch: master

commit 4253d20418496ef7dac054f308a4e0df334a9776
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:58 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ibc6f84428699a0a54c0f24d54b1390af6a041f9f
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ironic (master)

Reviewed: https://review.openstack.org/386811
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ironic/commit/?id=3a62eccb2cbb3b8071bb7b34007ee17d82eae311
Submitter: Jenkins
Branch: master

commit 3a62eccb2cbb3b8071bb7b34007ee17d82eae311
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:32 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I7067a541362c826579fc7d17abf86fe9ddc89bee
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-haproxy_server (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387479

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-openstack_hosts (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387480

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-galera_client (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387482

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-galera_server (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387483

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-lxc_hosts (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387484

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_aodh (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387486

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cinder (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387487

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_gnocchi (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387489

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387490

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ironic (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387492

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387493

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387494

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_rally (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_tempest (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387496

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-rabbitmq_server (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387498

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-haproxy_server (stable/newton)

Reviewed: https://review.openstack.org/387479
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-haproxy_server/commit/?id=936bec29925c5d6799a36b4b0b9b3cb072d67a4d
Submitter: Jenkins
Branch: stable/newton

commit 936bec29925c5d6799a36b4b0b9b3cb072d67a4d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:03 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I460b4eb12c30d66769f3093a451dc39c77150ea3
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 696056db674d06a855566e81e2fcc1a889c13a97)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-openstack_hosts (stable/newton)

Reviewed: https://review.openstack.org/387480
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=0432c543ce28484270529f0d44ae6c51495e814f
Submitter: Jenkins
Branch: stable/newton

commit 0432c543ce28484270529f0d44ae6c51495e814f
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:22 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Icd0afaaf8f0d9c5e06751f284f99985af6a924c6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 84587efdc8db5de1d1117c948afd45ee6dc7eec5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-galera_client (stable/newton)

Reviewed: https://review.openstack.org/387482
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=d9cfa250a238faaf62abf1149c01e259adc70e67
Submitter: Jenkins
Branch: stable/newton

commit d9cfa250a238faaf62abf1149c01e259adc70e67
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:45 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I2c1b39905720e8e6ecb51d88f36c9eb47329d328
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 9dc6e60247b0f43ce8328743a6ead422e4415457)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-ceph_client (master)

Reviewed: https://review.openstack.org/386793
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=cf56576b10fe4425a7d3e33cb959a83aae9a3df1
Submitter: Jenkins
Branch: master

commit cf56576b10fe4425a7d3e33cb959a83aae9a3df1
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:40 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I38d32136b3721da499b7c13722a20d0eb5056de5
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/newton)

Reviewed: https://review.openstack.org/387497
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=adc76716ee46f6a33cf5d8309ea19483366d46dd
Submitter: Jenkins
Branch: stable/newton

commit adc76716ee46f6a33cf5d8309ea19483366d46dd
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:45 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Iab6a4e4be29ae358cc95d94eb1090a7963a925df
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit c45165acd3581203e7ac0b6dfcf6c7c90ca3d3cc)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-lxc_hosts (stable/newton)

Reviewed: https://review.openstack.org/387484
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=f093f06eb5721d89c4499d1113d406f2f8f9fefd
Submitter: Jenkins
Branch: stable/newton

commit f093f06eb5721d89c4499d1113d406f2f8f9fefd
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:13 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I298510082bcecb0b84eb252851f8044d8b7f7f61
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 6642af670f67e30c99e03cf3ebcade5fc79bf811)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-galera_server (stable/newton)

Reviewed: https://review.openstack.org/387483
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=db312c521f7d77c58b75eb9acc6a93d5479ae68b
Submitter: Jenkins
Branch: stable/newton

commit db312c521f7d77c58b75eb9acc6a93d5479ae68b
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:57 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I2a40fa9a0da45602a76f2d56611971fcf4063512
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 5038acc3907c75d6a5ff1af6382e5abec4ea1650)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_neutron (stable/newton)

Reviewed: https://review.openstack.org/387493
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=98520089ff8f9005529614e40d6575dcdf53f07b
Submitter: Jenkins
Branch: stable/newton

commit 98520089ff8f9005529614e40d6575dcdf53f07b
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:52 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I0e6b5fc5b10e379485cec5c58acca4b315d4a6c4
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 7849c7d8e39010a6a77e738a5110aea3adbd8c37)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cinder (stable/newton)

Reviewed: https://review.openstack.org/387487
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=fe3d1483343040660cb4bfb3d0f1387968bf90b8
Submitter: Jenkins
Branch: stable/newton

commit fe3d1483343040660cb4bfb3d0f1387968bf90b8
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:55 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I86f1c186caef114ee6fe7f753db92084b5d24d7d
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 08696779b08f73ffa5a279843c15d3babf626dec)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-rabbitmq_server (stable/newton)

Reviewed: https://review.openstack.org/387498
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=a3bcb49f62926766e0dd631556bf246a7007bcdc
Submitter: Jenkins
Branch: stable/newton

commit a3bcb49f62926766e0dd631556bf246a7007bcdc
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:47:04 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I34f49f829a61e25393fcec6b047aa28858c8eeb6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 98e7bca1fb58f6eeb7cb60e20b1dad03aa04e4cd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_heat (stable/newton)

Reviewed: https://review.openstack.org/387490
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_heat/commit/?id=9c5c0f13a8c5a7e31472412ae6de9c1b3648be45
Submitter: Jenkins
Branch: stable/newton

commit 9c5c0f13a8c5a7e31472412ae6de9c1b3648be45
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:21 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ida40e2f232676906014471a87954c66f115ab018
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 5a18f13b478b4fc8266aac2d0ff086f42f801b93)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_gnocchi (stable/newton)

Reviewed: https://review.openstack.org/387489
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_gnocchi/commit/?id=00fc8cf68857f0d3c56e66fa679a025e6b22f962
Submitter: Jenkins
Branch: stable/newton

commit 00fc8cf68857f0d3c56e66fa679a025e6b22f962
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:15 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I73eb17072f243d3a14eee148ec8205bc1aee71f8
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 4c438e8f135bb9b0d517f15953506052f9d8bf3c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_aodh (stable/newton)

Reviewed: https://review.openstack.org/387486
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=9f398e06c4227a801a63e5987fad8579c93246cf
Submitter: Jenkins
Branch: stable/newton

commit 9f398e06c4227a801a63e5987fad8579c93246cf
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:39 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I336c2b8da5ebb6358e2158ebc33f340e2713aad6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit df77794138f8a8972ad5529bfc568a47a37951ac)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_rally (stable/newton)

Reviewed: https://review.openstack.org/387495
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_rally/commit/?id=125d7ec437cab046bce4302ee66820a5bff3835f
Submitter: Jenkins
Branch: stable/newton

commit 125d7ec437cab046bce4302ee66820a5bff3835f
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:03 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I5986a6588788b09501935fcd0fc18b96531bdca2
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 4cd19d9ce8e90084d779956ee25a2ed41e37b9ea)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (stable/newton)

Reviewed: https://review.openstack.org/387494
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=be0f8ed4ea5f67156b544984720d16c12e956a3d
Submitter: Jenkins
Branch: stable/newton

commit be0f8ed4ea5f67156b544984720d16c12e956a3d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:58 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ibc6f84428699a0a54c0f24d54b1390af6a041f9f
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 4253d20418496ef7dac054f308a4e0df334a9776)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_tempest (stable/newton)

Reviewed: https://review.openstack.org/387496
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=901b1e563ad9627d2c650ca6a28f34dfc470cd4d
Submitter: Jenkins
Branch: stable/newton

commit 901b1e563ad9627d2c650ca6a28f34dfc470cd4d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:23 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I9ce8a41be134eaff336f6da7886db8461f333953
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 0827b69aa716079660bc5bd736389140792fa16e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-ceph_client (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387569

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_glance (stable/newton)

Reviewed: https://review.openstack.org/387488
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=4d725acb5baacc445e39b5920edd742c1e0329ea
Submitter: Jenkins
Branch: stable/newton

commit 4d725acb5baacc445e39b5920edd742c1e0329ea
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:10 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ie6f04bac9023d9f97b80f8de6911f09c338f3027
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit bb58d18a39cb06b0aea0bef3b1bbb2c1ea13a9f7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-ceph_client (stable/newton)

Reviewed: https://review.openstack.org/387569
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=ea064bce39cdb22814f91c6873ad187c7fd5f97b
Submitter: Jenkins
Branch: stable/newton

commit ea064bce39cdb22814f91c6873ad187c7fd5f97b
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:40 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I38d32136b3721da499b7c13722a20d0eb5056de5
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit cf56576b10fe4425a7d3e33cb959a83aae9a3df1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (stable/newton)

Reviewed: https://review.openstack.org/387492
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=ceabcef03dcd360d610c7fadf9c328c676ede6bf
Submitter: Jenkins
Branch: stable/newton

commit ceabcef03dcd360d610c7fadf9c328c676ede6bf
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:37 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I5ceece61312e2bf39d7489261bca247f353d6d74
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 6c902fc47191d3918658171504eb0d1cd751175d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ironic (stable/newton)

Reviewed: https://review.openstack.org/387491
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ironic/commit/?id=235754a21b9d4da9b5f8579c159f3e00e8b7a70e
Submitter: Jenkins
Branch: stable/newton

commit 235754a21b9d4da9b5f8579c159f3e00e8b7a70e
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:32 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I7067a541362c826579fc7d17abf86fe9ddc89bee
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 3a62eccb2cbb3b8071bb7b34007ee17d82eae311)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/386792
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=d921c90aa0a81fc98ab29b1115d57b4379cdc3e5
Submitter: Jenkins
Branch: master

commit d921c90aa0a81fc98ab29b1115d57b4379cdc3e5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:29 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I358675701b72317db8522da7af68ed9ee56bcc54
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/387645

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/newton)

Reviewed: https://review.openstack.org/387645
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=97aa8edb85d77ca9765bfbf382ddba941cb50afb
Submitter: Jenkins
Branch: stable/newton

commit 97aa8edb85d77ca9765bfbf382ddba941cb50afb
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:43:29 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: I358675701b72317db8522da7af68ed9ee56bcc54
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit d921c90aa0a81fc98ab29b1115d57b4379cdc3e5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-pip_install 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-galera_client 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-galera_client 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-galera_server 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-galera_server 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-ceph_client 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-ceph_client 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-haproxy_server 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-haproxy_server 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-lxc_hosts 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-lxc_hosts 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-openstack_hosts 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_keystone 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_keystone 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_aodh 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_aodh 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_cinder 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_cinder 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_glance 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_gnocchi 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_gnocchi 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_heat 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_heat 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_ironic 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_ironic 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_neutron 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_neutron 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_nova 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_nova 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_rally 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_rally 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_tempest 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-os_tempest 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rabbitmq_server 14.0.0.0rc4

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server 14.0.0.0rc4 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ceilometer (master)

Reviewed: https://review.openstack.org/386802
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=2ef2b9e735fdb63abd4763f2bdfc92b3ca86aa97
Submitter: Jenkins
Branch: master

commit 2ef2b9e735fdb63abd4763f2bdfc92b3ca86aa97
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:50 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ide6ae6a5ea5d2279c42003f379b3a3460e62a525
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ceilometer (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/389773

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ceilometer (stable/newton)

Reviewed: https://review.openstack.org/389773
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=b97fc6046995c3ec1491e8fa5c0644ea8e6d2f48
Submitter: Jenkins
Branch: stable/newton

commit b97fc6046995c3ec1491e8fa5c0644ea8e6d2f48
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:50 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ide6ae6a5ea5d2279c42003f379b3a3460e62a525
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 2ef2b9e735fdb63abd4763f2bdfc92b3ca86aa97)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_magnum (master)

Reviewed: https://review.openstack.org/386813
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_magnum/commit/?id=14df603af349e90f240ed4429bf1638ab26cc877
Submitter: Jenkins
Branch: master

commit 14df603af349e90f240ed4429bf1638ab26cc877
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:43 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ib906fa3a67a8d70174da10608921a1a213dfd739
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_magnum (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392105

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_sahara (master)

Reviewed: https://review.openstack.org/386818
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_sahara/commit/?id=3e65a5a166a8ddf92f957eca7b865b7fc07b2157
Submitter: Jenkins
Branch: master

commit 3e65a5a166a8ddf92f957eca7b865b7fc07b2157
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:08 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ia6f55ae6fd6270d03e6bf0541d577cd862b3a16b
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_magnum (stable/newton)

Reviewed: https://review.openstack.org/392105
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_magnum/commit/?id=1aae6c283e0610c10ccb037ef42417ea19bcccf5
Submitter: Jenkins
Branch: stable/newton

commit 1aae6c283e0610c10ccb037ef42417ea19bcccf5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:43 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ib906fa3a67a8d70174da10608921a1a213dfd739
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 14df603af349e90f240ed4429bf1638ab26cc877)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_ceilometer 14.0.1

This issue was fixed in the openstack/openstack-ansible-os_ceilometer 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_sahara (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394325

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_sahara (stable/newton)

Reviewed: https://review.openstack.org/394325
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_sahara/commit/?id=36281d2de08a40774db0727004a10103ee24a1d3
Submitter: Jenkins
Branch: stable/newton

commit 36281d2de08a40774db0727004a10103ee24a1d3
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:08 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Ia6f55ae6fd6270d03e6bf0541d577cd862b3a16b
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 3e65a5a166a8ddf92f957eca7b865b7fc07b2157)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_ceilometer 14.0.1

This issue was fixed in the openstack/openstack-ansible-os_ceilometer 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-pip_install 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-galera_client 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-galera_client 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-galera_server 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-galera_server 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-ceph_client 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-ceph_client 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-haproxy_server 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-haproxy_server 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-lxc_container_create 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-lxc_container_create 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-lxc_hosts 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-lxc_hosts 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-openstack_hosts 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-openstack_hosts 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_keystone 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_keystone 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_aodh 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_aodh 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_ceilometer 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_ceilometer 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_cinder 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_cinder 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_glance 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_glance 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_gnocchi 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_gnocchi 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_heat 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_heat 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_horizon 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_horizon 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_ironic 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_ironic 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_magnum 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_magnum 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_neutron 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_neutron 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_nova 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_nova 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_rally 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_rally 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_sahara 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_sahara 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_swift 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_swift 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_tempest 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-os_tempest 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rabbitmq_server 15.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_magnum 14.0.3

This issue was fixed in the openstack/openstack-ansible-os_magnum 14.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_sahara 14.0.3

This issue was fixed in the openstack/openstack-ansible-os_sahara 14.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_magnum 14.0.3

This issue was fixed in the openstack/openstack-ansible-os_magnum 14.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_sahara 14.0.3

This issue was fixed in the openstack/openstack-ansible-os_sahara 14.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.