commit 696056db674d06a855566e81e2fcc1a889c13a97
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:03 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I460b4eb12c30d66769f3093a451dc39c77150ea3
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
Reviewed: https:/ /review. openstack. org/386796 /git.openstack. org/cgit/ openstack/ openstack- ansible- haproxy_ server/ commit/ ?id=696056db674 d06a855566e81e2 fcc1a889c13a97
Committed: https:/
Submitter: Jenkins
Branch: master
commit 696056db674d06a 855566e81e2fcc1 a889c13a97
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:03 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I460b4eb12c30d6 6769f3093a451dc 39c77150ea3
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>