commit 1aae6c283e0610c10ccb037ef42417ea19bcccf5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:43 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Ib906fa3a67a8d70174da10608921a1a213dfd739
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
(cherry picked from commit 14df603af349e90f240ed4429bf1638ab26cc877)
Reviewed: https:/ /review. openstack. org/392105 /git.openstack. org/cgit/ openstack/ openstack- ansible- os_magnum/ commit/ ?id=1aae6c283e0 610c10ccb037ef4 2417ea19bcccf5
Committed: https:/
Submitter: Jenkins
Branch: stable/newton
commit 1aae6c283e0610c 10ccb037ef42417 ea19bcccf5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:43 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Ib906fa3a67a8d7 0174da10608921a 1a213dfd739 f240ed4429bf163 8ab26cc877)
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
(cherry picked from commit 14df603af349e90