Comment 36 for bug 1633438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-openstack_hosts (master)

Reviewed: https://review.openstack.org/386799
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=84587efdc8db5de1d1117c948afd45ee6dc7eec5
Submitter: Jenkins
Branch: master

commit 84587efdc8db5de1d1117c948afd45ee6dc7eec5
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:22 2016 -0500

    Remove 'ignore_errors: true' in favor of 'failed_when: false'

    This change removes the use of 'ignore_errors: true' because it causes deployers
    to see red output and a stacktrace, which traditionally means something is broken,
    even when the failure is known to have a fall back option or be intentional. This
    conversion will provide a generally cleaner interface.

    It should be noted that the 'failed' filter will still function normally. Tasks
    with the 'failed_when: false' option will still be marked as 'failed' in any
    registered variable. This change simply makes the output look cleaner.

    Change-Id: Icd0afaaf8f0d9c5e06751f284f99985af6a924c6
    Closes-Bug: #1633438
    Signed-off-by: Kevin Carter <email address hidden>