commit c45165acd3581203e7ac0b6dfcf6c7c90ca3d3cc
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:45 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Iab6a4e4be29ae358cc95d94eb1090a7963a925df
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
Reviewed: https:/ /review. openstack. org/386825 /git.openstack. org/cgit/ openstack/ openstack- ansible- pip_install/ commit/ ?id=c45165acd35 81203e7ac0b6dfc f6c7c90ca3d3cc
Committed: https:/
Submitter: Jenkins
Branch: master
commit c45165acd358120 3e7ac0b6dfcf6c7 c90ca3d3cc
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:46:45 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Iab6a4e4be29ae3 58cc95d94eb1090 a7963a925df
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>