commit 6642af670f67e30c99e03cf3ebcade5fc79bf811
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:13 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I298510082bcecb0b84eb252851f8044d8b7f7f61
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
Reviewed: https:/ /review. openstack. org/386798 /git.openstack. org/cgit/ openstack/ openstack- ansible- lxc_hosts/ commit/ ?id=6642af670f6 7e30c99e03cf3eb cade5fc79bf811
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6642af670f67e30 c99e03cf3ebcade 5fc79bf811
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:44:13 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I298510082bcecb 0b84eb252851f80 44d8b7f7f61
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>