commit be0f8ed4ea5f67156b544984720d16c12e956a3d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:58 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Ibc6f84428699a0a54c0f24d54b1390af6a041f9f
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
(cherry picked from commit 4253d20418496ef7dac054f308a4e0df334a9776)
Reviewed: https:/ /review. openstack. org/387494 /git.openstack. org/cgit/ openstack/ openstack- ansible- os_nova/ commit/ ?id=be0f8ed4ea5 f67156b54498472 0d16c12e956a3d
Committed: https:/
Submitter: Jenkins
Branch: stable/newton
commit be0f8ed4ea5f671 56b544984720d16 c12e956a3d
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:58 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: Ibc6f84428699a0 a54c0f24d54b139 0af6a041f9f 7dac054f308a4e0 df334a9776)
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
(cherry picked from commit 4253d20418496ef