commit 3a62eccb2cbb3b8071bb7b34007ee17d82eae311
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:32 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I7067a541362c826579fc7d17abf86fe9ddc89bee
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>
Reviewed: https:/ /review. openstack. org/386811 /git.openstack. org/cgit/ openstack/ openstack- ansible- os_ironic/ commit/ ?id=3a62eccb2cb b3b8071bb7b3400 7ee17d82eae311
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3a62eccb2cbb3b8 071bb7b34007ee1 7d82eae311
Author: Kevin Carter <email address hidden>
Date: Fri Oct 14 16:45:32 2016 -0500
Remove 'ignore_errors: true' in favor of 'failed_when: false'
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.
It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.
Change-Id: I7067a541362c82 6579fc7d17abf86 fe9ddc89bee
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <email address hidden>