Angular catalog serials menu doesn't include Quick Receive
Bug #1906462 reported by
Mary Llewellyn
This bug affects 25 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
High
|
Jane Sandberg | ||
3.12 |
Confirmed
|
Undecided
|
Unassigned | ||
3.13 |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
Version: 3.5.1
Browser: Chrome Version 86.0.4240.198 (Official Build) (64-bit)
When you click on the Serials button in the traditional staff catalog, you get 3 menu choices:
Quick Receive, Manage Subscriptions, Manage MFHDs
In the Angular staff catalog, there are only 2 choices
Manage Subscriptions, Manage MFHDs
What I expected:
To have the Quick Receive menu option to be present in the Angular catalog menu
Changed in evergreen: | |
status: | New → Confirmed |
summary: |
- Angular catalog serials menu doesn't include Quick Recieve + Angular catalog serials menu doesn't include Quick Receive |
tags: | added: staffcatalog |
tags: | added: regression |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbergja) |
tags: | added: pullrequest signedoff |
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbergja) |
tags: |
added: needsrebase removed: pullrequest |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbergja) |
Changed in evergreen: | |
assignee: | Jane Sandberg (sandbergja) → nobody |
tags: | added: needswork |
To post a comment you must log in.
I spent some time looking at how the AngularJS client's Quick Receive works. For anybody who takes this ticket, here are the broad strokes that I saw, in case it is helpful to you:
1) When Quick Receive is clicked, open a modal containing the egSubSelector/ eg-sub- selector (subscription selector) directive. This directive is, in turn, made of an org selector and a PCRUD-generated list of subscriptions at that bib record and OU (and the OU's descendants). My impression is that it would be easy to address usability bug 1915567 while re-implementing this subscription selector in Angular.
2) When the user chooses the subscription they want, the AngularJS serials service's fetchItemsForSub method does some work to search for just the right serials items.
3) The item IDs get passed to the AngularJS serials service's process_items method, which ultimately sends a call to open-ils. serial. receive_ items
At a casual glance, steps 2 and 3 seem to do a lot of work. Perhaps, rather than re-implementing them exactly in Angular, some of that logic could be done in Perl.