Comment 12 for bug 1906462

I've started reviewing this. I don't have the time to do a complete review in one sitting, but here's what I have so far:

[1] The form seems to be expecting that at least one item will have call number and barcode supplied, even if you haven't ticked the checkbox to barcode the issue. In other words, it's not allowing you to receive without barcoding without also fiddling with the form, which is a regression on the AngularJS Quick Receive and a showstopper. I'm adjusting the LP tags accordingly.

[2] I'm not a fan of the template row automatically overwriting inputs in the item rows; the AngularJS Quick Receive has an explicit apply button, which gives a little more room for the operator to catch an error before committing to a batch change, especially since neither version of Quick Receive has undo.

[3] Nit regarding the routing list: the hyphen before the routing list entry note is always displayed, even if there is no note for that entry.

[4] Maybe a nit regarding the routing list, maybe not: the AngularJS version of the printed routing list included the patron addresses. If that's functionality that anybody might need, I think it would be better for the new server-side print template to include it (and in general, match the older version as closely as possible.) (Also, if it's not wanted, it's easier to remove fields than add them when customizing print templates.)