Comment 24 for bug 1906462

Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed out a new collab branch, working/collab/gmcharlt/lp1906462_more_review, that includes follow-ups to fix lint and allow null to be passed as the call number affix value without breaking serial receiving.

(By the way, contra comment 16, the AngularJS Quick Receive seemed to handle cases where the affixes were left unset just fine)

Other feedback:

[1] The checkboxes for whether a routing list should be printed or not seem to do nothing; it looks like the "Receive and print routing list" button will print the routing lists regardless of the checkbox settings.

[2] The AngularJS Quick Receive was more sophisticated in its handling of call numbers; in particular, it looks for all call numbers (with affixes) that have been used for the bib at the receiving library and presents a drop-down allowing the user to pick one to use as a batch update option. It also fills in the call number of the last issue that was received.

However, I think there's a broader discussion to be had regarding that feedback, regarding the second point: while it's clear that more work would need to be done to fully replicate the functionality of the AngularJS Quick Receive (and TBH, I think replicating its ability to help the user select the call number to use for barcoded issues rather than type them in from scratch is important), are we at a point where it's "good enough" for the moment?