Desktop Action menus of Remmina are not translated

[AsciiWolf]

Desktop Action menus of Remmina are not translated although they are fully translated in the upstream desktop file. It looks like that the translation is not applied for some reason. Maybe because Ubuntu is using gettext instead of having the translated strings directly in the desktop files?

[Gunnar Hjalmarsson (gunnarhj)]

There is a "remmina" translation template in LP, but not a "remmina-plugins" template, and the language packs only install remmina.mo, not remmina-plugins.mo.

Maybe that has something to do with it.

[AsciiWolf (asciiwolf)]

I think the issue is that in upstream, the translated strings are directly in the remmina.desktop.in file instead of the pofile. This is not an issue in most distributions, but packages on Ubuntu do not ship with any translated strings placed directly in desktop files.

[Gunnar Hjalmarsson (gunnarhj)]

Ok, I might have misunderstood...

Are you talking about e.g. the string "Create a new connection profile" which you translated in LP yesterday? In that case it will show up in Czech in 18.04.

[Jeremy Bícha (jbicha)]

Gunnar, but it's already translated upstream:

https://github.com/FreeRDP/Remmina/blob/next/remmina/desktop/remmina.desktop.in

[AsciiWolf (asciiwolf)]

Gunnar, the "Create a new connection profile" string is in pofiles because it is also used in remmina.c/remmina_main.glade, the other two strings ("Start Remmina Minimized", "Quit") are not.

[Gunnar Hjalmarsson (gunnarhj)]

Yeah, I saw the upstream .desktop file, and for some reason those translations are dropped when the package is built. Can't tell exactly how that happens.

Is there any example of a package where that kind of .desktop translations are successfully ending up in LP? In other packages the .desktop file is included in POTFILES.in and the strings make it to the .po files that way.

@AsciiWolf: Thanks for clarifying; I didn't realize it was a coincident.

[Daniel van Vugt (vanvugt)]

I can't find anything in the gnome-shell source relating to Remmina. Does it need to be mentioned here?

[Gunnar Hjalmarsson (gunnarhj)]

No, the gnome-shell task seems to be off topic on this bug report.

[Gunnar Hjalmarsson (gunnarhj)]

I figured out a hackish solution to this, which I think will work. Building with the attached debdiff ought to give us a translation template with the strings in the .desktop file. Then the strings can be translated in LP, and after next update of the language packs the strings should show up translated.

[AsciiWolf (asciiwolf)]

Thanks! I will translate it via Launchpad when possible.

[Gunnar Hjalmarsson (gunnarhj)]

An alternative and less hackish solution: Simply remove "X-Ubuntu-Gettext-Domain=remmina" from the .desktop file, and the translations won't be stripped from .desktop when the package is built.

[Gunnar Hjalmarsson (gunnarhj)]

On 2018-02-03 17:04, AsciiWolf wrote:
> Thanks! I will translate it via Launchpad when possible.

It looks like you don't need to, since we went for the second idea for a solution. The drawback is that "Quit" will remain untranslated until translation happens upstream.

[Launchpad Janitor (janitor)]

This bug was fixed in the package remmina - 1.2.0-rcgit.26+dfsg-1ubuntu2

---------------
remmina (1.2.0-rcgit.26+dfsg-1ubuntu2) bionic; urgency=low

  * debian/patches/translations.patch:
    - Don't add "X-Ubuntu-Gettext-Domain=remmina" to .desktop file to
      prevent that the file's translations are removed by
      pkgstriptranslations (LP: #1746004).

 -- Gunnar Hjalmarsson <email address hidden> Mon, 05 Feb 2018 11:15:00 +0100

[AsciiWolf (asciiwolf)]

The "Quit" string is still appearing as not translated on latest Ubuntu Focal.

[AsciiWolf (asciiwolf)]

(It may, however, be another issue, pofiles for 20.04 are not translatable yet using Launchpad so I am checking it against translations from 19.10 where only a "_Quit" string was available for translation and was translated.)

[AsciiWolf (asciiwolf)]

Oops, ignore my previous comments. The "Quit" string seems to be available in upstream pofiles and is now fully translated in my (Czech) language.