[UIFe] Radiance panel icons are unreadable and ugly when panel goes transparent with Dash

[Callum Saunders]

==========
UIFe: I need to change the colour of the text when the Dash opens to white, and try and load white versions of all the icons. This will effect any screenshot of the Dash - njpatel
==============

I've attached screenshots.

For the text equivalent, see bug 838168. In both cases, elements are being drawn as if they are on a light background when they aren't.

[Callum Saunders (callumsaunders)]

for comparison

[Andrea Cimitan (cimi)]

not a bug in light themes, maybe unity should start using symbolic icons and tint icons properly when transparent panel goes in

[Martin Pitt (pitti)]

Radiance is not our standard theme, and we need to re-do the screenshots in ubuntu-doc anyway, so approved.

[Neil J. Patel (njpatel)]

99% of the icons we are getting from the indicators right now are pixbufs, which made this way more difficult that it could have been (and not as nice). For now, to cover all themes instead of just Radiance, I'm doing some cairo magic in the code when the dash is up to convert the pixbufs into white-based icons. This works pretty well for symbolic-type icons, however it's not so great if the icon has tons of detail. As we don't, by default, have any icon that looks bad, and because the icons still look at least somewhat recognisable, I'm going for this as the right approach for Oneiric.

[Andrea Cimitan (cimi)]

I discussed that with Neil, and I think this is the best compromise we can come up for Oneiric. Future plans involve using symbolic icons in indicators, and change color directly without needing to play with cairo magics that can have their drawbacks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity - 4.16.0-0ubuntu1

---------------
unity (4.16.0-0ubuntu1) oneiric; urgency=low

  * New upstream release.
    - compiz crashed with SIGSEGV in nux::GpuDevice::GetGpuInfo()
      (LP: #765375)
    - F10 doesn't start keyboard navigation to the panel (LP: #839628)
    - Change on the at-spi accessibility-toolkit can affect also Unity
      (LP: #844927)
    - compiz crashed with SIGSEGV when a lens is shutting down (LP: #848675)
    - [UIFe] Radiance panel icons are unreadable and ugly when panel goes
      transparent with Dash (LP: #828862)
    - window switcher stuck (not only, but can be triggered with Onboard)
      (LP: #832033)
    - Window titlebar is click through after raising a minimized window
      (LP: #840285)
    - Alt+Shift+` does not work in symmetry with Alt+` (LP: #843250)
    - UIFe: Alt-Tab: Update layout behavior to make previews larger and
      outline active preview (LP: #847944)
    - windows clipped on resize (LP: #848962)
    - Alt-tab - Add orange border to selected window in alt-tab window spread
      (LP: #838114)
    - Launcher - the direction the Launcher is scrolled with the mouse wheel
      is inverted (LP: #839703)
    - Launcher - the rendering of the BFB and Lens squircle does not match the
      design (LP: #838708)
    - Alt-Tab - In the app window spread, all windows should have the same
      height, only the width should vary (LP: #838110)
    - Launcher - the background of the Launcher should be tinted using the
      average colour of the wallpaper (LP: #850068)
    - Alt-tab - It is currently very difficult to see pips in the left of the
      app icon for the currently selected app (LP: #838134)
    - Launcher - Auto scroll missing from the top of the Launcher
      (LP: #838744)
    - Scope searches blocks the lens (LP: #850816)
    - Shortcuts SUPER+1...9 doesn’t work until opening a window (LP: #768076)
    - Dash closes prematurely when dragging apps into the launcher
      (LP: #773892)
    - Dash - As soon as a user starts dragging a .png file from the Dash, the
      file icon turns into a grey question mark (LP: #764447)
    - Dash shows an empty icon for some applications. (LP: #830887)
    - Windows are click through after restore from minimize (LP: #834034)
    - Dash - No keyboard shortcuts for switching lenses (LP: #842086)
    - Dash search for files states "two more results" but doesn't display them
      (LP: #840005)
    - <meta>+<shift>+<launcher #> to start a new instance of a program doesn't
      work anymore (LP: #842977)
    - Alt-tab - Cross interactions between Alt-tab and Dash are broken
      (LP: #844021)
    - UIFe: Dash - Shape and positioning of most of the elements in the Dash
      need adjustment (Part 2) (LP: #844889)
    - Alt-Tab - make pause to spread default alt-tab behaviour. Upgrade
      existing installs as well. (LP: #838075)
    - Do not install unity-preference (LP: #847599)
    - Update unity --distro to latest plugins installed (LP: #847799)
    - off by one error in count of additional results in a category
      (LP: #848218)
    - UIFe - Launcher - The background of the BFB, Workspace Switcher, Lens,
    ...

[Adolfo Jayme Barrientos (fitojb)]

This change is nice, however, as Neil said, affects non-symbolic icons; and Ubuntu ship a non-symbolic icon for the keyboard layout indicator (please see bug 620331 regarding removal of the keyboard icon, needs raising its importance because now is a highly visible problem).

[Jeremy Bícha (jbicha)]

Another example is the Universal Access icon which can be turned on by opening System Settings>Universal Access. Switch to the Typing tab and select "Turn on accessibility features from the keyboard."

Now when opening the dash, there's an ugly white circle in place of the universal access menu.

[Omer Akram (om26er)]

The white icons when dash is open is reported as bug 852816

On Sun, Sep 18, 2011 at 9:08 AM, Jeremy Bicha <email address hidden> wrote:
> Another example is the Universal Access icon which can be turned on by
> opening System Settings>Universal Access. Switch to the Typing tab and
> select "Turn on accessibility features from the keyboard."
>
> Now when opening the dash, there's an ugly white circle in place of the
> universal access menu.
>
> --
> You received this bug notification because you are subscribed to unity.
> https://bugs.launchpad.net/bugs/828862
>
> Title:
>  [UIFe] Radiance panel icons are unreadable and ugly when panel goes
>  transparent with Dash
>
> Status in Light Themes:
>  Invalid
> Status in Unity:
>  Fix Released
> Status in “light-themes” package in Ubuntu:
>  Invalid
> Status in “unity” package in Ubuntu:
>  Fix Released
>
> Bug description:
>  ==========
>  UIFe: I need to change the colour of the text when the Dash opens to white, and try and load white versions of all the icons. This will effect any screenshot of the Dash - njpatel
>  ==============
>
>  I've attached screenshots.
>
>  For the text equivalent, see bug 838168. In both cases, elements are
>  being drawn as if they are on a light background when they aren't.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/light-themes/+bug/828862/+subscriptions
>