Launcher - the rendering of the BFB and Lens squircle does not match the design
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Jason Smith | ||
unity-2d |
Fix Released
|
High
|
Tiago Salem Herrmann | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity-2d (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
*update* The latest designs for the BFB and Lens squircles are now attached to this bug. "launcher.png" shows exactly how the BFB should look, and "glow.png" and "base.png" should provide the required assets. Contact Rosie if these assets need any adjustment or if additional assets are required.
-------
The rendering of the BFB and Lens squircle does not match the design.
Look closely at the attached design and compare to the implementation. The issues are:
- the border of the squircle is incorrect
- there seems to be a strange highlight on the sides of the squircle that is not present in the design.
- the white glow effect seems to be missing.
- the background should be tinted using the wallpaper average background colour
If any changed or additional assets are required to match the implementation with the design contact Rosie.
Related branches
- Lohith D Shivamurthy (community): Approve
-
Diff: 73 lines (+13/-2)2 files modifiedlauncher/LauncherItem.qml (+11/-2)
launcher/LauncherList.qml (+2/-0)
- Albert Astals Cid (community): Approve
- Gerry Boland: Pending requested
- Michał Sawicz: Pending requested
-
Diff: 341 lines (+92/-64)9 files modifiedlibunity-2d-private/src/lens.cpp (+15/-3)
libunity-2d-private/src/lenses.cpp (+8/-5)
libunity-2d-private/src/lenses.h (+2/-0)
shell/app/shelldeclarativeview.cpp (+7/-0)
shell/app/shelldeclarativeview.h (+2/-0)
shell/dash/Dash.qml (+25/-17)
shell/dash/LensBar.qml (+20/-19)
shell/dash/LensView.qml (+7/-6)
shell/dash/RendererGrid.qml (+6/-14)
- Albert Astals Cid (community): Approve (fun)
- Gerry Boland (community): Needs Fixing
- Michał Sawicz: Abstain
-
Diff: 341 lines (+92/-64)9 files modifiedlibunity-2d-private/src/lens.cpp (+15/-3)
libunity-2d-private/src/lenses.cpp (+8/-5)
libunity-2d-private/src/lenses.h (+2/-0)
shell/app/shelldeclarativeview.cpp (+7/-0)
shell/app/shelldeclarativeview.h (+2/-0)
shell/dash/Dash.qml (+25/-17)
shell/dash/LensBar.qml (+20/-19)
shell/dash/LensView.qml (+7/-6)
shell/dash/RendererGrid.qml (+6/-14)
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
tags: | added: onew udo |
Changed in unity-2d: | |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in unity: | |
status: | New → Incomplete |
importance: | Undecided → High |
assignee: | nobody → Jason Smith (jassmith) |
Changed in unity: | |
status: | Incomplete → Fix Committed |
milestone: | none → 4.16.0 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
tags: | added: delta-with-3d |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesigno removed: onew udo |
tags: |
added: reviewedbydesign removed: reviewedbydesigno |
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-2d: | |
milestone: | none → 4.14 |
Changed in unity-2d: | |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
Changed in unity-2d: | |
milestone: | 4.14 → 5.2 |
assignee: | Renato Araujo Oliveira Filho (renatofilho) → nobody |
Changed in unity-2d: | |
assignee: | nobody → Tiago Salem Herrmann (tiagosh) |
Changed in unity-2d: | |
status: | Confirmed → In Progress |
Changed in unity-2d: | |
status: | In Progress → Fix Committed |
Changed in unity-2d: | |
status: | Fix Committed → Fix Released |
Out of curiosity was these really considered "Critical"?