Port Terminator to Python3

Bug #1662544 reported by Stephen Boddy on 2017-02-07
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Emilio Pozuelo Monfort

Bug Description

Python2 is starting to fall out of favour slightly (i.e. not included by default on some distros).

It is time we moved away from the old version, and onto Python3.

Related branches

Changed in terminator:
milestone: 2.1 → 3.0
rahmadani (rahmadani) on 2017-02-08
Changed in terminator:
assignee: nobody → rahmadani (rahmadani)
status: Triaged → Confirmed
Stephen Boddy (stephen-j-boddy) wrote :

Rahmadani, just so I know, are you assigning this to yourself because you intend to work on it? If so, great! I'll set the bug to "In Progress". If on the other hand you didn't mean to or didn't realise what you did, let me know and I will unassign this.

I mostly created this for my self while planning future releases and what they'd contain.

Stephen Boddy (stephen-j-boddy) wrote :

Rahmadani, this project had a user who vandalised translations and changed bug assignee and status for no good reason, and refused to respond when contacted. After I had them banned, they came back and did it again under a new username, which also got banned.

I hope you are not them back again, so please just drop a quick line here confirming that you are not them. The reason I'm challenging you is that your account was created a few days after the second account got banned, and I think they also showed as Indonesian on their details page.

I'm going to put this ticket back to myself for now. Do NOT simply reassign it back to yourself. When you push a bzr/git branch into launchpad, or point me to a repository somewhere where it's obvious you are actually working on this with commits, I'll be happy (delighted!) for you to assign it back to yourself.

If you have no connection to that individual, please accept my apologies.

And just in case you do not speak English... Google Translate... which is probably wrong...

Rahmadani, proyek ini memiliki pengguna yang dirusak terjemahan dan berubah bug penerima dan status tanpa alasan yang baik, dan menolak untuk merespon ketika dihubungi. Setelah saya mereka dilarang, mereka datang kembali dan melakukannya lagi di bawah nama pengguna baru, yang juga kena banned.

Saya harap Anda tidak mereka kembali lagi, jadi silahkan saja menjatuhkan baris cepat di sini mengkonfirmasikan bahwa Anda bukan mereka. Alasan saya menantang Anda adalah bahwa akun Anda telah dibuat beberapa hari setelah akun kedua kena banned, dan saya pikir mereka juga menunjukkan sebagai Indonesia pada halaman rincian mereka.

Aku akan menempatkan tiket ini kembali ke diri saya sendiri untuk saat ini. TIDAK hanya menetapkan kembali kembali ke diri sendiri. Ketika Anda mendorong cabang bzr / git ke launchpad, atau menunjuk saya untuk repositori di suatu tempat di mana sudah jelas Anda benar-benar bekerja pada ini dengan komit, saya akan senang (senang!) Bagi Anda untuk menetapkan kembali kepada diri sendiri.

Jika Anda tidak memiliki sambungan ke individu itu, terimalah permintaan maaf saya.

Dan hanya dalam kasus Anda tidak berbicara bahasa Inggris ... Google Translate ... yang mungkin salah ...

Changed in terminator:
assignee: rahmadani (rahmadani) → Stephen Boddy (stephen-j-boddy)
Stephen Boddy (stephen-j-boddy) wrote :

Oh, and if you ignore me and assign the ticket back to you, I will assume you are the vandal. Then I will ask that you are banned again.

Oh, dan jika Anda mengabaikan saya dan menetapkan tiket kembali kepada Anda, saya akan menganggap Anda adalah perusak. Kemudian saya akan meminta Anda dilarang lagi.

Changed in terminator:
status: Confirmed → Triaged
Emilio Pozuelo Monfort (pochu) wrote :

I have a working branch using Python 3. I need to do some more testing and split the changes into nice commits, and I'll submit it for review / wider testing.

Changed in terminator:
assignee: Stephen Boddy (stephen-j-boddy) → Emilio Pozuelo Monfort (pochu)
Changed in terminator:
status: Triaged → Confirmed
Emilio Pozuelo Monfort (pochu) wrote :

Here's my work, split in nice, small commits:


I've been running it for a couple of weeks, no crashes and no exceptions. It just works flawlessly, at least for the use that I give it. There surely are bugs in codepaths that I don't use, so some wider testing would be appreciated.

There are a bunch of shebangs still pointing to python2, but we should just delete those I guess.

Changed in terminator:
status: Confirmed → In Progress
Laurent Bigonville (bigon) wrote :


Any news on getting pochu patch merged?

It seems to work fine here for me (no extensive testing though)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers