Comment 28 for bug 1662544

Revision history for this message
Stanislav Laznicka (stlaz) wrote :

Hi,

Thanks all for looking into this. While I am no longer a user of terminator, I do think it is still quite important to get it working with python3.

I noticed a potential issue with my patch, I do think that the part which goes like

```
         self.layouttreestore.clear()
         layouts = self.config.list_layouts()
- for layout in sorted(layouts, cmp=lambda x,y: cmp(x.lower(), y.lower())):
+ for layout in sorted(l.lower() for l in layouts):
             if layout != "default":
                 self.layouttreestore.append([layout])
```

should really be
```
         self.layouttreestore.clear()
         layouts = self.config.list_layouts()
         for i, layout in enumerate(sorted(l.lower() for l in layouts)):
             if layout != "default":
                 self.layouttreestore.append([layouts[i]])
```
to keep the original casing of the layout.

Otherwise it's hopefully fine.

Good luck with the python3 port!