Comment 51 for bug 1662544

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

I've just realized that there's been a truly unfortunate lack of information flow here.

Emilio did submit his python3 port to the Debian package versioned 1.91-2 a long time (1.5 years) ago. So it's been in Debian experimental, later in unstable, and eventually in stable for quite some time.

Debian Buster (10; released in 2019-07), Ubuntu Disco (19.04) and Ubuntu Eoan (19.10) all ship python3-based terminator (numbered 1.91-4).

The exact changes (in form of patches on top of mainstream 1.91) can be found at e.g. https://packages.debian.org/buster/terminator -> terminator_1.91-4.debian.tar.xz. There are three relevant patches inside: a big one, and two tiny followup ones.

The existing work should be merged. E.g. check if the Debian/Ubuntu patches are indeed the same as Emilio's branch (at which commit). Whether Emilio's branch also contains the two tiny followup patches, and/or other commits, and if so then whether Roman's branch also contains them. If not then evaluate and merge them back to whichever other branches where development currently happens (Roman's branch I guess).

The latest Debian and Ubuntu bugreports should be interpreted knowing that they might be about Python 3:

https://bugs.launchpad.net/terminator/+bugs?orderby=-id&start=0
https://bugs.launchpad.net/ubuntu/+source/terminator/+bugs?orderby=-id&start=0
https://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=terminator

In particular, these two seem to need attention:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939929
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=941479

The good news is that this way the python3 work has already received much wider testing than we hoped for, and apparently there aren't many problems to worry about.

MattRose, this might mean that you should perhaps just go ahead with the current python3 work for the Fedora package, rather than applying for exceptions.