Comment 8 for bug 1662544

Revision history for this message
Stanislav Laznicka (stlaz) wrote :

Hey,
I only found a small issue while going through your branch as I ran pylint on it. There's one missed usage of cmp() in `terminatorlib/layoutlauncher.py`.

Also, if you make all shebangs point to python3 instead, `./run_tests` will fail because dicts are wrapping their values and keys you receive from the methods.

I'm adding a messy patch (this is my first time using bzr, I had a deep appreciation for git before that only grew with this experience) which fixes the tests, the cmp() use, makes all shebangs point to py3 and adds/removes pylint comments every now and then. It also removes some trailing whitespaces, I won't certainly block my IDE from doing that.

Feel free to use any of the patch freely, if you want. Generally this works, please, merge, python2 needs to die.