Web Client: Call Number Labels should not be required in the Copy Editor

Bug #1821950 reported by Michele Morgan on 2019-03-27
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
3.1
High
Unassigned
3.2
High
Unassigned

Bug Description

It is not possible to create a holding in the web client with a blank call number label. The xul client did allow saving call number records with blank call number labels.

It is common practice for our libraries to use a call number that has only a prefix and a blank label. Our production system has a large number of holdings of this type, and they cannot be created or edited in the web client due to the requirement that the call number label be filled in.

If some feel strongly that call number labels should be required, then there needs to be a library setting to allow the use of blank call number labels.

Elaine Hardy (ehardy) wrote :

I think this should be a setting. Perhaps at the shelving location level, in the Shelving Locations Editor? That would allow finer control so that a library could require call numbers in some collections and not in others.

Changed in evergreen:
status: New → Confirmed
Kyle Huckins (khuckins) on 2019-05-16
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Kyle Huckins (khuckins) wrote :

I've pushed a branch here, adding a new YAOUS, and modifying the volcopy editor's behavior to check the setting to determine whether or not to allow items with empty call number label boxes.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1821950-call-number-labels-not-required

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: pullrequest
Michele Morgan (mmorgan) on 2019-08-26
Changed in evergreen:
milestone: none → 3.3.4
Derek C. Zoladz (derekz) on 2019-09-05
Changed in evergreen:
assignee: nobody → Derek C. Zoladz (derekz)
Michele Morgan (mmorgan) wrote :

I have done some testing on this patch, and have seen the following problem with cat.require_call_number_labels set to FALSE:

Using Add Holdings to create a new call number and item, if I do nothing to the call number label field, I am unable to save the record and the holdings editor remains open.

In this case, the browser console shows:

error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.0307549055054026081567543016374], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.20.2/OpenILS/Application/Cat.pm line 1226.

Possibly unhandled rejection: error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.0307549055054026081567543016374], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.20.2/OpenILS/Application/Cat.pm line 1226.

Evergreen logs show:

2019-09-03 17:01:07 brick3 open-ils.cstore: [ERR :60754:oils_sql.c:2522:156754372460501166] open-ils.cstore ERROR inserting asset::call_number object using query [INSERT INTO asset.call_number (create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix) VALUES ('now',517,DEFAULT,'now',517,DEFAULT,DEFAULT,74,2126522,DEFAULT,2,-1,-1);]: 3452548 3452548: ERROR: query string argument of EXECUTE is null#012CONTEXT: PL/pgSQL function asset.label_normalizer() line 16 at EXECUTE statement

If, however, I enter date in the call number label and then remove it (leaving it blank) I am able to save the new record with the blank label and the holdings editor closes.

Derek C. Zoladz (derekz) on 2019-09-11
Changed in evergreen:
assignee: Derek C. Zoladz (derekz) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers