Call Number Labels should not be required in the Angular Holdings Editor

[Christine Morgan]

3.8 / 3.9

It is not possible to create a holding in the Holdings Editor with a blank call number label. This is a regression since the xul client did allow saving call number records with blank call number labels.

It is common practice for our libraries to use a call number that has only a prefix and a blank label. Our production system has a large number of holdings of this type, and they cannot be created or edited in the Holdings Editor or the Web Client Copy Editor due to the requirement that the call number label be filled in.

If some feel strongly that call number labels should be required, then there needs to be a library setting to allow the use of blank call number labels.

Linking back to the Web Client bug for this same issue.
https://bugs.launchpad.net/evergreen/+bug/1821950

[Jennifer Pringle (jpringle-u)]

Confirming it is not possible to save a blank call number in the new angular holdings editor. I can save a call number with just a space (so it appears blank).

[Terran McCanna (tmccanna)]

The New Developers Working Group worked on this one as well as the related AngularJS one:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1980409_allow_empty_call_number_label

(Note that this requires the top two commits on the branch - the first by Kyle Huckins and the second under my name, but worked on by the New Devs Group.)

[Christine Morgan (cmorgan-z)]

The New Developers Working Group worked on this again to fix an issue where the Save button became active before a barcode was entered. Terran updated her working branch in comment 2 with the fix. This was an issue only in the Angular editor. This now requires the top three commits on the branch.

[Christine Morgan (cmorgan-z)]

Works for me! Thanks to the New Devs Group, with a special shout out to Terran, for working on this.

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

[Terran McCanna (tmccanna)]

Thanks, Christine! Did you test in both the Angular & AngularJS copy editors?

[Christine Morgan (cmorgan-z)]

A colleague tested the AngularJS editor and I believe she has signed off on that.

[Terran McCanna (tmccanna)]

Confirmed, thank you!

[Michele Morgan (mmorgan)]

I'd be strongly in favor of backporting this to 3.9 (and 3.8) since this functionality existed way back in the xul client.

[Michele Morgan (mmorgan)]

Pushed to master, rel_3_9 and rel_3_8

Thanks Kyle, Terran, Christine, Beth, and the New Developer's Working Group!

Marking bug 1821950 as a duplicate of this one since this patch fixes both.