Comment 3 for bug 1821950

I have done some testing on this patch, and have seen the following problem with cat.require_call_number_labels set to FALSE:

Using Add Holdings to create a new call number and item, if I do nothing to the call number label field, I am unable to save the record and the holdings editor remains open.

In this case, the browser console shows:

error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.0307549055054026081567543016374], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.20.2/OpenILS/Application/Cat.pm line 1226.

Possibly unhandled rejection: error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.0307549055054026081567543016374], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.20.2/OpenILS/Application/Cat.pm line 1226.

Evergreen logs show:

2019-09-03 17:01:07 brick3 open-ils.cstore: [ERR :60754:oils_sql.c:2522:156754372460501166] open-ils.cstore ERROR inserting asset::call_number object using query [INSERT INTO asset.call_number (create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix) VALUES ('now',517,DEFAULT,'now',517,DEFAULT,DEFAULT,74,2126522,DEFAULT,2,-1,-1);]: 3452548 3452548: ERROR: query string argument of EXECUTE is null#012CONTEXT: PL/pgSQL function asset.label_normalizer() line 16 at EXECUTE statement

If, however, I enter date in the call number label and then remove it (leaving it blank) I am able to save the new record with the blank label and the holdings editor closes.