web client: Attempting to save a record from the vol/copy editor without a call number fails without feedback

Bug #1713164 reported by Kathy Lussier
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Medium
Unassigned

Bug Description

If a user adds a copy to a record using the volume/copy editor and neglects to add a call number, they are able to click the Save button. Saving the copy will fail. The data previously displaying in the copy editor clears and the window remains open. However, there is no message informing the user why the action failed.

The call number field should be handled in a similar fashion as the barcode field. If data isn't entered, the 'save' button should be disabled. Ideally, both fields would also have some sort of visual cue informing the user that they are required.

Revision history for this message
Kathy Lussier (klussier) wrote :

Adding a note that this only happens if adding a volume to a record that is not pulling in call number information from the bib record. In cases where the call number is automatically generated, when we clear the call number, we get a nice, visible alert telling us a call number is required.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirmed, 3.0 beta

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Christine Burns (christine-burns) wrote :

Confirmed, 3.0.3

Revision history for this message
Mike Risher (mrisher) wrote :

I pushed a branch with a fix. Now when you add a new copy the editor highlights that it's missing a call number and won't let you save til you add one.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1713164-saving-without-call-num

tags: added: pullrequest
Revision history for this message
Janet Schrader (jschrader) wrote :

I can confirm that the "missing call number" warning appears under the call number box if no call number is pulled in from the bib record.
I can confirm that the "save & exit" button is grayed out if no call number is added.

I have tested this code and consent to signing off on it with my name, Janet Schrader, and my email address, <email address hidden>

tags: added: signedoff
Revision history for this message
Mike Risher (mrisher) wrote :

This bug overlaps heavily with https://bugs.launchpad.net/evergreen/+bug/1821950. Because of this I plan to mark this bug as a duplicate of 1821950 and put my work on a branch based off of the work on 1821950. I hope it have it completed very soon. My apologies for not communicating this sooner.

Thank you,
Mike

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.