need ability to do in-line reviews
Bug #609297 reported by
Monty Taylor
This bug affects 20 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Celso Providelo | ||
Bug Description
When doing code reviews in merge-requests, often it is very beneficial to reference comments to specific chunks of code. In an email, one could just do inline comments (although these don't really get presented in any explicitly wonderful manner in the web ui) - but in the web ui there is just about no good way to make specific comments on specific chunks of code.
Related branches
lp:~stevenk/launchpad/inline-diff-comments-ui
- William Grant: Approve (code)
-
Diff: 438 lines (+332/-7)10 files modifiedlib/canonical/launchpad/icing/style.css (+3/-0)
lib/lp/app/browser/stringformatter.py (+1/-1)
lib/lp/app/javascript/client.js (+2/-1)
lib/lp/app/javascript/inlineedit/editor.js (+6/-2)
lib/lp/code/browser/branchmergeproposal.py (+4/-2)
lib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+132/-0)
lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.html (+84/-0)
lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js (+91/-0)
lib/lp/code/templates/branchmergeproposal-index.pt (+3/-1)
lib/lp/services/features/flags.py (+6/-0)
lp:~wgrant/launchpad/ic-js-cleanup
- Celso Providelo (community): Approve
- Chris Johnston (community): Approve
-
Diff: 660 lines (+176/-171)10 files modifiedlib/canonical/launchpad/icing/css/modifiers.css (+2/-1)
lib/canonical/launchpad/icing/style.css (+42/-0)
lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css (+0/-49)
lib/lp/code/browser/codereviewcomment.py (+2/-0)
lib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+89/-90)
lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js (+34/-27)
lib/lp/code/mail/codereviewcomment.py (+1/-1)
lib/lp/code/mail/tests/test_codereviewcomment.py (+2/-2)
lib/lp/code/templates/branchmergeproposal-diff.pt (+1/-1)
lib/lp/code/templates/branchmergeproposal-index.pt (+3/-0)
lp:~wgrant/launchpad/ic-fixes
- William Grant: Approve (code)
-
Diff: 154 lines (+21/-20)4 files modifiedlib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+6/-5)
lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js (+2/-2)
lib/lp/code/mail/codereviewcomment.py (+3/-4)
lib/lp/code/mail/tests/test_codereviewcomment.py (+10/-9)
| affects: | launchpad → launchpad-code |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: openstack |
Revision history for this message
| niels (opensource21) wrote | #1 |
Revision history for this message
| Florian Rathgeber (florian-rathgeber) wrote | #2 |
Revision history for this message
| Adam Candy (asc) wrote | #3 |
| Changed in launchpad: | |
| importance: | Medium → Low |
Revision history for this message
| SirVer (sirver) wrote | #4 |
Revision history for this message
| Samuel Mehrbrodt (sam92) wrote | #5 |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| William Grant (wgrant) wrote | #6 |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| Changed in launchpad: | |
| assignee: | nobody → Celso Providelo (cprov) |
| importance: | Low → High |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #8 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| SirVer (sirver) wrote | #9 |
| Changed in launchpad: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
I want to enhance the request, because I think that not only on merge request a comment function would be great. In github you found support for every commit.