Add ability to review changes inline similar to ReviewBoard
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
New
|
Undecided
|
Unassigned | ||
Bug Description
ReviewBoard has a really intuitive interface for doing reviews. When you view the side-by-side diff (which has a really neat feature which lets you expand hidden lines in the files - allowing you to comment on code that isn't close enough to show up by default) you can click the margin and select either a single line or drag and select several. When you let go, a re-positional modal dialogue pops up and lets you enter a comment about the lines you selected. When you click save, the modal dialogue is dismissed and a small green rectangle appears in the margin spanning vertically to indicate the lines you commented on. Inside the rectangle is the number of comments made on the same section of code. Clicking on a rectangle allows you to add (or update) your comment on that section of code. If others (or yourself in previous reviews) have made comments on the same section of code, they'll be shown in chronological order in the modal dialogue on the left - permitting the conversation about that bit of code to occur "inline".
After making your first comment, a small banner slides into the top of the page to advise you that you have a pending review and provides buttons to edit the review, publish, and discard. Clicking edit review pops up a modal dialogue that shows you each section of code followed by a text area with your comment allowing you to go through and review/update each comment you've made if you'd like. Additional text areas are at the top and bottom allowing you to enter an "introduction" and "conclusion" (my words, not theres). A checkbox at the very top labeled "Ship It" provides the equivalent to the "Approved" review type in Launchpad. Lastly, in the bottom right of the modal dialogue box are buttons that permit you to publish your review, discard, cancel, and save.
Once you publish your review, you're taken back to the threaded view of comments and you can see your new comment. It shows each highlighted snippet of the side-by-side diff you commented on followed by your comment and then a small, right justified "Add comment" link. Clicking on the "Add comment" link results in a text area sliding open to let you enter a comment. These comments on comments are also shown inline in the comment after saving.
Its very slick and some of these features would be awesome to have in Launchpad.
