commenting on specific lines in a diff using the web UI is tedious

[Thiago Bellini]

It would be very useful if launchpad provided a way for reviewing merge-proposals in-line.
Bugzilla for example provides that functionality, making it easy to comment on lines of code.
The example bellow, where the lines after ">" are the piece of the diff, and the next line is the comment some rewier might add.

>+def a(self):
>+ print b
I think you should print "c" instead of "b" here.

This could be implemented by adding an option when clicking "Add a review or comment" to respond inline. So, the diff would be copied to the textarea and the reviwer can delete pieces he finds it's ok, and let pieces he finds that needs improvement and comment in that exact point. Btw, that's the way Bugzilla do the job.

obs. Sorry for my poor english. Just point me if the description needs improvement.

[Robert Collins (lifeless)]

See also bug 307461 (start a review mail from the web page) bug 382561 (copy-paste of the diff is disrupted by the line numbers) and bug 686417 (actual edit-inline support, very close to this report but even nicer).

I'm tempted to dup this report on 686417 because I think that they are reporting the same issue, but proposing different fixes.

[Martin Pool (mbp)]

Perhaps a cheap start towards this would be just a way to get the full
diff pasted into the edit box.

Martin

[Robert Collins (lifeless)]

Perhaps so - there is a separate bug asking for that, FWIW - and I
think that fixing one doesn't necessitate fixing the other so we
should keep both.

[Thiago Bellini (bellini666)]

I posted about the bugzilla approach of commenting on bugs.

I was taking a look at github's approach. It's even greater. But I don't know if it would be a lot harder to create something like that...

[Thiago Bellini (bellini666)]

On comment above, s/commenting on bugs/commenting on diffs/

[OscarAlca (oscarolar)]

I believe that this can be a great fetaure watch this on git

http://www.diigo.com/item/image/3ai4q/81d9