Music CD has 2 Icons in Mounter applet

Bug #525306 reported by Jero
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Docky
Fix Released
Low
Robert Dyer
docky (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

When I insert a Music CD, Mounter displays two Icons instead of one. No problems with DVD's or CD-R.

$docky -d
<code>

[Info 15:08:31.522] Docky version: bzr docky r1159 ppa
[Info 15:08:31.530] Kernel version: 2.6.31.19
[Info 15:08:31.531] CLR version: 2.0.50727.1433
[Warn 15:08:31.672] [GLib] g_set_prgname() called multiple times
/usr/share/themes/Shiki-Brave/gtk-2.0/gtkrc:126: Murrine configuration option "gradients" is no longer supported and will be ignored.
[Debug 15:08:31.745] [SystemService] Using org.freedesktop.DeviceKit.Power for battery information
[Info 15:08:31.837] [DockServices] Dock services initialized.
[Info 15:08:31.930] [DockController] Setting theme: Classic
[Info 15:08:32.216] [PluginManager] Loaded "Docky.Widgets,1.0".
[Info 15:08:32.216] [PluginManager] Loaded "Docky.Widgets,1.0".
[Info 15:08:32.217] [PluginManager] Loaded "Weather".
[Info 15:08:32.230] [PluginManager] Loaded "Trash".
[Info 15:08:32.244] [PluginManager] Loaded "Battery Monitor".
[Debug 15:08:32.249] [BatteryMonitorProcItem] Hiding battery item (capacity=0) (max_capacity=-1) (OnBattery=False)
[Info 15:08:32.250] [PluginManager] Loaded "Mounter".
[Debug 15:08:32.270] [MountProvider] Adding Disco de sonido.
[Debug 15:08:32.459] Key MountItem_139720197160800 does not exist, creating.
[Info 15:08:32.553] [AbstractWeatherSource] Weather Underground: Reloading weather data
[Debug 15:08:32.561] [AbstractWeatherSource] Weather Underground: Fetching XML file 'http://api.wunderground.com/auto/wui/geo/WXCurrentObXML/index.xml?query=Madrid%2c+Spain'
[Info 15:08:32.662] [MountProvider] Disco de sonido mounted.
[Debug 15:08:32.677] Key MountItem_139720199286320 does not exist, creating.
[Info 15:08:33.789] [Helper] Starting pidgin_control.py
[Info 15:08:33.803] [Helper] Starting rhythmbox_control.py
[Info 15:08:33.824] [DrawingService] Could not find 'gajim', using fallback of 'extension'.
</code>

Ubuntu 9.10 64 bits
mono-runtime 2.4.2.3
xorg 1:7.4+3ubuntu10
Nvidia GTS250
Gnome 2.28.4

Thanks

Revision history for this message
Jero (jbuencuerpo) wrote :
Revision history for this message
Robert Dyer (psybers) wrote :

Where is your Docky icon?! How do we even know this is Docky! ;-)

I swore I already posted this bug in regards to my ipod, but I can't seem to find it anywhere... so thanks for posting this! We are aware of this already, Chris just hasn't fixed it yet.

Changed in docky:
importance: Undecided → Low
assignee: nobody → Chris S. (cszikszoy)
status: New → Confirmed
Revision history for this message
Jero (jbuencuerpo) wrote :

I have change it in my theme because I can't remove it!! hahahaha there is a blueprint for that, I'll be wating til then. I also have an Ipod and I see only one Icon, if it helps. Thank you

Revision history for this message
Alex Murray (alexmurray) wrote :

Attached is a patch which should fix this - basically we first check to see if a MountItem has already been created before adding a new one, and we test for equivalence using the root path of the mount point. Works for me and my iPhone which was previously producing duplicate entries without this patch.

Revision history for this message
Chris S. (cszikszoy) wrote : Re: [Bug 525306] Re: Music CD has 2 Icons in Mounter applet

 I'll apply this patch and see how it works out. I believe I tried to do
something similar in the past, but the reason why it didn't work is because
sometimes Mount.Root is null. I think the true solution is to couple GIO
with udev, I just haven't worked out how exactly that would work.

On Wed, Jun 16, 2010 at 6:56 AM, Alex Murray <email address hidden> wrote:

> Attached is a patch which should fix this - basically we first check to
> see if a MountItem has already been created before adding a new one, and
> we test for equivalence using the root path of the mount point. Works
> for me and my iPhone which was previously producing duplicate entries
> without this patch.
>
> ** Patch added: "Patch to fix duplicate items appearing in mounter docklet"
>
> http://launchpadlibrarian.net/50434037/docky-fix-duplicate-mount-items.patch
>
> --
> Music CD has 2 Icons in Mounter applet
> https://bugs.launchpad.net/bugs/525306
> You received this bug notification because you are a bug assignee.
>
> Status in Docky: Confirmed
>
> Bug description:
> When I insert a Music CD, Mounter displays two Icons instead of one. No
> problems with DVD's or CD-R.
>
> $docky -d
> <code>
>
> [Info 15:08:31.522] Docky version: bzr docky r1159 ppa
> [Info 15:08:31.530] Kernel version: 2.6.31.19
> [Info 15:08:31.531] CLR version: 2.0.50727.1433
> [Warn 15:08:31.672] [GLib] g_set_prgname() called multiple times
> /usr/share/themes/Shiki-Brave/gtk-2.0/gtkrc:126: Murrine configuration
> option "gradients" is no longer supported and will be ignored.
> [Debug 15:08:31.745] [SystemService] Using org.freedesktop.DeviceKit.Power
> for battery information
> [Info 15:08:31.837] [DockServices] Dock services initialized.
> [Info 15:08:31.930] [DockController] Setting theme: Classic
> [Info 15:08:32.216] [PluginManager] Loaded "Docky.Widgets,1.0".
> [Info 15:08:32.216] [PluginManager] Loaded "Docky.Widgets,1.0".
> [Info 15:08:32.217] [PluginManager] Loaded "Weather".
> [Info 15:08:32.230] [PluginManager] Loaded "Trash".
> [Info 15:08:32.244] [PluginManager] Loaded "Battery Monitor".
> [Debug 15:08:32.249] [BatteryMonitorProcItem] Hiding battery item
> (capacity=0) (max_capacity=-1) (OnBattery=False)
> [Info 15:08:32.250] [PluginManager] Loaded "Mounter".
> [Debug 15:08:32.270] [MountProvider] Adding Disco de sonido.
> [Debug 15:08:32.459] Key MountItem_139720197160800 does not exist,
> creating.
> [Info 15:08:32.553] [AbstractWeatherSource] Weather Underground: Reloading
> weather data
> [Debug 15:08:32.561] [AbstractWeatherSource] Weather Underground: Fetching
> XML file '
> http://api.wunderground.com/auto/wui/geo/WXCurrentObXML/index.xml?query=Madrid%2c+Spain
> '
> [Info 15:08:32.662] [MountProvider] Disco de sonido mounted.
> [Debug 15:08:32.677] Key MountItem_139720199286320 does not exist,
> creating.
> [Info 15:08:33.789] [Helper] Starting pidgin_control.py
> [Info 15:08:33.803] [Helper] Starting rhythmbox_control.py
> [Info 15:08:33.824] [DrawingService] Could not find 'gajim', using
> fallback of 'extension'.
> </code>
>
> Ubuntu 9.10 64 bits
> mono-runtime 2.4.2.3
> xorg 1:7.4+3ubuntu10
> Nvidia GTS250
> Gnome 2.28.4
>
> Thanks
>
>
>

Revision history for this message
Robert Dyer (psybers) wrote :

I think this is a much better fix:

http://paste.pocoo.org/show/230206/

Revision history for this message
Robert Dyer (psybers) wrote :

Fixed in rev 1541.

Changed in docky:
status: Confirmed → Fix Committed
assignee: Chris S. (cszikszoy) → Robert Dyer (psybers)
milestone: none → 2.0.5
Changed in docky:
status: Fix Committed → Fix Released
summary: - Music CD has 2 Icons in Mounter applet
+ debdiff which fixes this is attached to bug #579049
summary: - debdiff which fixes this is attached to bug #579049
+ Music CD has 2 Icons in Mounter applet
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

debdiff which fixes this is attached to bug #579049

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.1 KiB)

This bug was fixed in the package docky - 2.0.5-1

---------------
docky (2.0.5-1) unstable; urgency=low

  * New upstream release 2.0.5 "Be proud of your dock",
    changes include:
    + remove --debug flag from launcher for lower memory usage
    + update the about dialog credits to list documenters and make translation
      tab easier to read
    + change url in about dialog to the launchpad project page
    + Window-Matching
      - fix for applications commandline
      - properly match qt creator (LP: #594814)
      - prefer local over global launchers (LP: #588073) (LP: #592841)
      - match prefix for gksudo (LP: #516433)
      - fix nautilus items showing active indicator when desktop
        is focused (LP: #487113)
      - fix matching wine apps that use a prefixed launcher (LP: #596092)
    + Memory Leaks
      - dispose of calendar painter when the clock item is disposed
      - fix leak in AutoHideManager
      - several fixes using Cairo.Context.Target and Pango.Layout
      - fix leak in PagingPainters
      - fix leak in recursive file-deletion
      - fix leaking SeparatorItems, WnckDockItems
      - fix leaks with FileEmblems
      - fix Pixbuf related leaks
      - fix some leaks regarding FileMonitors
      - fix leaks regarding Tiles and AbtractTileObjects
      - fix leaking Glib.FileAdapter caused by unreferenced Action in
        FileDockItem
    + Handle invalid desktopfile entry and UriFormatException in
      FileApplicationProvider (LP: #595921)
    + fix potential crash for invalid HelperMetadata
    + handle drops correctly
    + fix handling of Helpers in HelperService
    + make the sliders in preferences behave better
    + fix drawing of rotated items
    + fix HoveredItem click-position
    + avoids fatal errors on console when loading embedded icons when no
      height or width is specified and when dock items have a null Icon
    + fix icon theme change not refreshing the dock icons (LP: #590205)
    + fix SVG rendering bug
    + fix iconsize temporarily getting large when adding to full dock
      (LP: #579576)
    + fix the 'crash in PinToDock' (LP: #588073)
    + make 3d background height more consistent and a tad larger (LP: #503038)
    + fix dragging multiple files to a folder on the dock, which caused
      a crash and data corruption (LP: #579049)
    + don't request animations if urgent state is removed from a window and
      fix glow location (LP: #596422)
    + fix window previews being offset (LP: #495065)
    + fix broken zoom after shrinking icon size (LP: #598924)
    + fix problem with hovers still visible when painters show
    + fix displaying default icon in place of missing file emblem (LP: #534651)
    + fix crash when gconf key for menus_have_icons is not set (LP: #573751)
    + make sure painters fit on screen (LP: #589978)
    + fix icon minimize animations not working immediately for some newly
      opened windows
    + don't dispose our static DockyItem
    + fix CurrentDesktopOnly not working when dragging a window across desktops
      (LP: #600290)
    + GMail:
      - fix thread-guards and remove deprecated code
      - fix problem with feeds that don't have a...

Read more...

Changed in docky (Ubuntu):
status: New → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Accepted docky into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in docky (Ubuntu Lucid):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.9 KiB)

This bug was fixed in the package docky - 2.0.5-0ubuntu1

---------------
docky (2.0.5-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release 2.0.5 "Be proud of your dock",
    changes include:
    + remove --debug flag from launcher for lower memory usage
    + update the about dialog credits to list documenters and make translation
      tab easier to read
    + change url in about dialog to the launchpad project page
    + Window-Matching
      - fix for applications commandline
      - properly match qt creator (LP: #594814)
      - prefer local over global launchers (LP: #588073) (LP: #592841)
      - match prefix for gksudo (LP: #516433)
      - fix nautilus items showing active indicator when desktop
        is focused (LP: #487113)
      - fix matching wine apps that use a prefixed launcher (LP: #596092)
    + Memory Leaks
      - dispose of calendar painter when the clock item is disposed
      - fix leak in AutoHideManager
      - several fixes using Cairo.Context.Target and Pango.Layout
      - fix leak in PagingPainters
      - fix leak in recursive file-deletion
      - fix leaking SeparatorItems, WnckDockItems
      - fix leaks with FileEmblems
      - fix Pixbuf related leaks
      - fix some leaks regarding FileMonitors
      - fix leaks regarding Tiles and AbtractTileObjects
      - fix leaking Glib.FileAdapter caused by unreferenced Action in
        FileDockItem
    + Handle invalid desktopfile entry and UriFormatException in
      FileApplicationProvider (LP: #595921)
    + fix potential crash for invalid HelperMetadata
    + handle drops correctly
    + fix handling of Helpers in HelperService
    + make the sliders in preferences behave better
    + fix drawing of rotated items
    + fix HoveredItem click-position
    + avoids fatal errors on console when loading embedded icons when no
      height or width is specified and when dock items have a null Icon
    + fix icon theme change not refreshing the dock icons (LP: #590205)
    + fix SVG rendering bug
    + fix iconsize temporarily getting large when adding to full dock
      (LP: #579576)
    + fix the 'crash in PinToDock' (LP: #588073)
    + make 3d background height more consistent and a tad larger (LP: #503038)
    + fix dragging multiple files to a folder on the dock, which caused
      a crash and data corruption (LP: #579049)
    + don't request animations if urgent state is removed from a window and
      fix glow location (LP: #596422)
    + fix window previews being offset (LP: #495065)
    + fix broken zoom after shrinking icon size (LP: #598924)
    + fix problem with hovers still visible when painters show
    + fix displaying default icon in place of missing file emblem (LP: #534651)
    + fix crash when gconf key for menus_have_icons is not set (LP: #573751)
    + make sure painters fit on screen (LP: #589978)
    + fix icon minimize animations not working immediately for some newly
      opened windows
    + don't dispose our static DockyItem
    + fix CurrentDesktopOnly not working when dragging a window across desktops
      (LP: #600290)
    + GMail:
      - fix thread-guards and remove deprecated code
      - fix problem with feeds that do...

Read more...

Changed in docky (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.