Ubuntu
update-manager package

[jaunty] Launchpad changelog URLs with epochs are not correctly linked

Bug #328164 reported by pablomme on 2009-02-11

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	update-manager (Ubuntu)	Fix Released	Low	Michael Vogt

Bug Description

Binary package hint: update-manager

update-manager has the ability of linking to changelogs at launchpad.net when they are not available from the repositories (I assume?). However, when a package version string contains a colon in it, the URL is "linkified" up to the colon only, so clicking on the link opens a "not found" page rather than showing the changelog.

I've attached a screenshot to show what I mean.

I'm running an up-to-date Jaunty installed from the Alpha 4 liveCD. update-manager is at 1:0.97.1. I am not sure if Hardy and/or Intrepid have this issue too.

Related branches

lp:update-manager

lp:ubuntu/lucid/update-manager

Revision history for this message

pablomme (pablomme) wrote on 2009-02-11:

update-manager-link.png Edit (80.6 KiB, image/png)

Revision history for this message

Kiwinote (kiwinote) wrote on 2009-02-12:

Confirmed in jaunty.

Changed in update-manager:
status:	New → Confirmed

Revision history for this message

Fabián Rodríguez (magicfab) wrote on 2009-02-13:

I' ve assigned Importance -> Low - see https://wiki.ubuntu.com/Bugs/Importance.

Changed in update-manager:
importance:	Undecided → Low

Revision history for this message

kulight (kulight) wrote on 2009-02-17:

also confirm in jaunty

Revision history for this message

XXXXXXX (yddraiggoch) wrote on 2009-02-22:

bug328164.patch Edit (585 bytes, text/plain)

Attached a patch to fix this problem

Revision history for this message

Michael Vogt (mvo) wrote on 2009-03-05:

Thanks for the patch! Applied.

Changed in update-manager:
assignee:	nobody → mvo
status:	Confirmed → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-03-10:

This bug was fixed in the package update-manager - 1:0.100

---------------
update-manager (1:0.100) jaunty; urgency=low

  [ Andy Whitcroft ]
  * DistUpgrade/cdromupgrade:
    - if cdromupgrade is run with a relative path we will fail to find the
      installer components and error out. Ensure that the path is absolute.
      (LP: #335360)

  [ Michael Vogt ]
  * fix crash when help is not avaialble (LP: #338098)
  * data/glade/UpdateManager.glade:
    - remove the "Keep your system up-to-date" text (design team,
      LP: #336800)
  * fix crash when no network is avaialble for changelog fetching
    (LP: #334002)
  * debian/control:
    - add conflict against update-manager-kde to update-manager-hildon
      (LP: #333464)
  * UpdateManager/Core/MyCache.py:
    - show proper urls for sources with epochs (LP: #328164), thanks
      to Richie
  * UpdateManager/ChangelogViewer.py:
    - support copy to clipboard for URLs (LP: #85644), thanks to
      Richie
  * UpdateManager/UpdateManager.py:
    - disable fixed-hight mode, it can cause incorrect height
      calculation (thanks to Richie), LP: #273184
  * DistUpgrade/DistUpgradeController.py:
    - do not allow gtk/kde upgrades over ssh session (LP: #322482)
  * merged aufs branch (disabled by default but useful for testing)

-- Michael Vogt <email address hidden> Tue, 10 Mar 2009 20:25:55 +0100

Changed in update-manager:
status:	Fix Committed → Fix Released

Revision history for this message

Thomas E Jenkins (thomas-jenkins) wrote on 2009-03-11:

I feel like a more correct approach is to fix the linkify logic like I proposed in LP #329172 rather than URL encoding just ":" it here. The patch in the other bug ensures all links with colon characters work as well as some other valid punctuation while preserving their display in the text.

https://bugs.launchpad.net/update-manager/+bug/329172