cdromupgrade fails if run with a relative path

[Andy Whitcroft]

Binary package hint: update-manager

When upgrading a system from an alternate installer CD you execute the cdromupgrade script on the CD to initiate the upgrade. However if you do not run this with an absolute path it will fail with a very non-obvious error:

    /media/disk# ./cdromupgrade
    tar: ./dists/jaunty/main/dist-upgrader/binary-all//jaunty.tar.gz: Cannot open: No such file or directory
    tar: Error is not recoverable: exiting now
    tar: Child returned status 2
    tar: Error exit delayed from previous errors
    Could not find the upgrade application in the archive, exiting
    /media/disk#

We should at least tell the user to use an absolute path, if not simply cope.

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
Package: update-manager 1:0.98.1
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: update-manager
Uname: Linux 2.6.28-8-server x86_64

[Andy Whitcroft (apw)]

This is caused by the interaction between how we locate the installer tarball and the fact we are cd'ing into a temporary directory. We can simply detect that the path is not absolute and make it absolute using pwd.

[Andy Whitcroft (apw)]

Fixed this and pushed up a branch to fix this. Proposed branch for merging:

    https://code.launchpad.net/~apw/update-manager/cdromupgrade-absolute-path/+merge/4012

[Andy Whitcroft (apw)]

@Sponsors -- proposing the branch above be merged for Jaunty. Let me know if I need to do anything else.

[Michael Vogt (mvo)]

Thanks a lot for the fix! merged into what should become release 0.100

[Bryce Harrington (bryce)]

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:0.100

---------------
update-manager (1:0.100) jaunty; urgency=low

  [ Andy Whitcroft ]
  * DistUpgrade/cdromupgrade:
    - if cdromupgrade is run with a relative path we will fail to find the
      installer components and error out. Ensure that the path is absolute.
      (LP: #335360)

  [ Michael Vogt ]
  * fix crash when help is not avaialble (LP: #338098)
  * data/glade/UpdateManager.glade:
    - remove the "Keep your system up-to-date" text (design team,
      LP: #336800)
  * fix crash when no network is avaialble for changelog fetching
    (LP: #334002)
  * debian/control:
    - add conflict against update-manager-kde to update-manager-hildon
      (LP: #333464)
  * UpdateManager/Core/MyCache.py:
    - show proper urls for sources with epochs (LP: #328164), thanks
      to Richie
  * UpdateManager/ChangelogViewer.py:
    - support copy to clipboard for URLs (LP: #85644), thanks to
      Richie
  * UpdateManager/UpdateManager.py:
    - disable fixed-hight mode, it can cause incorrect height
      calculation (thanks to Richie), LP: #273184
  * DistUpgrade/DistUpgradeController.py:
    - do not allow gtk/kde upgrades over ssh session (LP: #322482)
  * merged aufs branch (disabled by default but useful for testing)

 -- Michael Vogt <email address hidden> Tue, 10 Mar 2009 20:25:55 +0100