Changelog linkifying of URL's end-of-string characters too strict
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Software Updater |
New
|
Undecided
|
Unassigned | ||
Bug Description
The search and link logic in on_insert_text in ChangelogViewer treats ":", "!", and "," characters as terminators for a linkable text. This makes sense when searching for bug numbers and the like, however these characters should be acceptable for vanilla URL's found by searching for "http://". This creates broken links for downloading changelogs for packages such as compiz that have ":" characters in their version string. The search and link already does not terminate on the "." character when building a vanilla URL link. However I think it should only terminate on whitespace or bracket-like characters not punctuation.
Attached is a diff off of the main bzr branch. It removes punctuation from the list of terminators for "http://" searches and removes the "." vs. other-punctuation special casing as well. Seemed too small a change to upload and register a branch.
On a related note should "https://" searches be added as well?
| Thomas E Jenkins (thomas-jenkins) wrote | #1 |
| CrYpTiC_MauleR (crypticmauler) wrote | #2 |
I can confirm this occurring as well with update-manager 1:0.98.1.1
>>On a related note should "https://" searches be added as well?
I agree, why use HTTP when all it does is redirect to HTTPS, have the URLs as HTTPS to begin with, will be more efficient in my opinion.