Item Alerts Not Editable

[Steve Callender]

Evergreen 3.9
Chrome

Items Alerts added via the new angular holdings editor can be removed but not edited.

In the old holdings editor they could be edited and removed.

This is similar to LP#1983628 but for Item Alerts on the same screen.

[Beth Willis (willis-a)]

Just noting that while it is possible to edit item notes in the old editor, it's not really clear that one can do so. I think it would be helpful to have an "edit" button in addition to the "clear" and "temporary" buttons in item alerts interface.

[Elaine Hardy (ehardy)]

Beth - see https://bugs.launchpad.net/evergreen/+bug/1983628

[Beth Willis (willis-a)]

Hi Elaine,

Thanks for sending this. I had cut and pasted my comment from
https://bugs.launchpad.net/evergreen/+bug/1983628 when commenting on
https://bugs.launchpad.net/bugs/2012971 and neglected to change "copies" to
"alerts." I have edited my comment.

Thanks again!
Beth

On Wed, May 10, 2023 at 11:18 AM Elaine Hardy <email address hidden>
wrote:

> Beth - see https://bugs.launchpad.net/evergreen/+bug/1983628
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2012971
>
> Title:
> Item Alerts Not Editable
>
> Status in Evergreen:
> Confirmed
>
> Bug description:
> Evergreen 3.9
> Chrome
>
> Items Alerts added via the new angular holdings editor can be removed
> but not edited.
>
> In the old holdings editor they could be edited and removed.
>
> This is similar to LP#1983628 but for Item Alerts on the same screen.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/2012971/+subscriptions
>
>

--
Beth Willis
Digital & Catalog Librarian
NOBLE, Inc.
5 Cherry Hill Drive
Danvers, MA 01923

[Joan Kranich (jkranich)]

3.10
Chrome

I see this problem in 3.10 too.

[Jennifer Pringle (jpringle-u)]

Confirmed still seeing this in 3.11.1

[Jennifer Pringle (jpringle-u)]

Noting that this currently has a workaround as you can edit an item alert through Item Status which still uses the old alerts.

When Item Status is rewritten in Angular it will most likely end this workaround - https://bugs.launchpad.net/evergreen/+bug/1960883

[Andrea Neiman (aneiman)]

Equinox will be working on this under contract from CW MARS.

[Jason Etheridge (phasefx)]

Here is a branch for this:
collab/phasefx/lp2012971-item-alerts-not-editable

From the commit message:
Release-notes: Fixes invocation of (Manage) Item Alerts dialog in Holdings Editor
Release-notes: Adds batch edit for Item Alerts in Holdings Editor. Alerts get grouped together for editing if they are mostly identical
Release-notes: Adds Manage Alerts button to Item Alerts dialog during alert display in Angular ("eg2") interfaces.
Release-notes: Fixes TypeError: defaults is null exception for missing Default Item Alert Type preference
Release-notes: Adds a Changes Pending indicator for Holdings Editor

Note that we do not address LP2044028 where multiple invocations of the
Item Alerts dialog in the Holdings Editor do not show pending changes
prior to a Save.

Example testing:

In staff client with Concerto dataset,
Cataloging -> Retrieve Bib Record By ID -> 1
Holdings View -> Show Copies
Select lines 5 and 6 (for CONC40000536 and CONC41000536)
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Normal Checkout, Test Note 123 -> Add New, Apply Changes
Should see a CHanges Pending label before Apply All & Save
Apply All, Save & Exit

Back in Holdings View,
Select lines 5 and 8 (for CONC40000536 and CONC4000036)
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Should not see the "Test Note 123" alert.
Close tab

Back in Holdings View,
Select lines 5 and 6 again
-> Edit: Edit Items
-> Add Item Alerts: Item Alerts
Should see a dialog for "Managing alerts in common for 2 item(s)."
Should also see the "Test Note 123" alert.
Close tab

Circulation -> Check Out
99999372363 -> Submit
In the URL, change /eg/ to /eg2/ for the experimental Angular circ interface
CONC40000536 -> Submit
Should see the Item Alerts dialog with the Test Note 123 alert.
Should also see a Manage Alerts button in the dialog.
Manage Alerts
Should see a new dialog, "Managing alerts for item CONC40000536",
which is the same Item Alerts dialog from the Holdings Editor.
Changes in this dialog are not reflected in the original Item Alerts
dialog from which it was spawned.

[Carol Witt (carolwitt)]

I have tested this code and consent to signing off on it with my name, Carol Witt and my email address, <email address hidden>.

[Tiffany Little (tslittle)]

I tested this on terran-main today.

I have a concern about the choice for the "Managing alerts in common for 2 item(s)" in the dialog header. For me, that's very easy to overlook as a user if that's the only notification that I'm batch modifying items, and *which* items I'm batch modifying. Since the header for editing one item includes the barcode, I would be fine with the header remaining the same as in the patch, but something needs to be in the body of the dialog to indicate which alerts are applied to which items.

I think it's also confusing that if multiple items are selected that not all alerts display. This also ties into my previous point, IMO. So for example if I select 3 items, the first two have the same alert and the third has a different one, that third alert just doesn't display at all. Even if it was greyed out or something to indicate it wouldn't be edited, I at least want to know it's there. That way if there's another alert that's close but not identical enough to be grouped, I know there's something up with the alerts on the items I've chosen.

[Michele Morgan (mmorgan)]

This patch was reviewed at Code Review yesterday. It works as advertised, restoring the lost functionality to edit item alerts.

The group shared the concerns expressed in comment #10, but opted to address the multiple items display issues in a separate bug.

Pushed to main and rel_3_12. It did not merge cleanly to rel_3_11.

Thanks Jason, Carol and all!