Item Notes Not Editable

[Jennifer Pringle]

Evergreen 3.9
Chrome

Items Notes added via the new angular holdings editor can be removed but not edited.

In the old holdings editor they could be edited and removed.

[Jennifer Pringle (jpringle-u)]

This was tested on our test server running 3.9 with the item alert and note fixes that have been committed to 3.9.1.

[Beth Willis (willis-a)]

Just noting that while it is possible to edit item notes in the old editor, it's not really clear that one can do so. I think it would be helpful to have an "edit" button in addition to the "remove" button in item notes interface.

[Jane Sandberg (sandbergja)]

Here's a branch to add the Edit button as recommended by Beth: user/sandbergja/lp1983628-copy-notes-editable

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1983628-copy-notes-editable

And here are the testing notes from the commit message:

1. Open your favorite bib record in the staff catalog
2. On the item table tab, find a barcode and click "Edit"
3. Press the Item Notes button.
4. Add a note with a title and value.
5. Press Apply Changes
6. Press Apply All and Save
7. Press the Item Notes button again.
8. Without this commit, you will not have a way to edit these notes. With this commit, you will have an edit button.
9. Confirm that you can Back out of the editor without making changes
10. Confirm that you can make changes and they persist.

[Steve Callender (stevecallender)]

I'm seeing the same problem with the Item Alert's as well. Does this bug cover the issue there?

[Jane Sandberg (sandbergja)]

My vote would be to have two separate bug reports, Steve. At least, the patch I submitted only modifies the manage item notes interface.

[Tiffany Little (tslittle)]

Getting a merge conflict when I try to cherry-pick this for Feedback Fest.

[Jane Sandberg (sandbergja)]

Thanks, Tiffany. I rebased and force-pushed to the same branch, user/sandbergja/lp1983628-copy-notes-editable

[Elaine Hardy (ehardy)]

I tested this on https://terran-master.gapines.org. I can edit one note at a time, which is great) but cannot edit multiple notes in batch. No edit button appears.

I have asked for discussion on EGCats list on whether to sign off or not.

[Mary Llewellyn (mllewell)]

I think it's a great step forward to be able to edit one item's note at this point. I see we can add notes to multiple items in a batch. It would be nice to do batch editing, but for me, it can wait.
We still can't edit the item tags on a batch of items, so maybe development on notes and tags can be tried together.

[Elaine Hardy (ehardy)]

I agree. Just wanted confirmation from someone else.

[Elaine Hardy (ehardy)]

I have tested this code and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>.

[Jason Boyer (jboyer)]

Because the CIG approved of the fix as-is I've pushed it to master, rel_3_11, and rel_3_10. (On 3.11's release 3.9 will enter security-only so I didn't bring it that far back.)

I'll open an additional LP for the remaining issues related to this (not everything can be edited, "current" new items aren't visible until saved, etc.)

Thanks Jane and Elaine!