tzdata 2023a/2023b/2023c release - Egypt restoring DST

Bug #2012599 reported by Dariusz Gadomski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tzdata (Ubuntu)
Fix Released
Critical
Benjamin Drung
Bionic
Fix Released
Critical
Unassigned
Focal
Fix Released
Critical
Unassigned
Jammy
Fix Released
Critical
Unassigned
Kinetic
Fix Released
Critical
Unassigned
Lunar
Fix Released
Critical
Benjamin Drung

Bug Description

[ Impact ]

Recently the Egyptian authorities decided to restore DST. The first switch after the change is expected to take place on last Friday of April. The upstream tzdata 2023a release already reflects this change.

The 2023a release contains the following changes:

* Egypt now uses DST again, from April through October.
* This year Morocco springs forward April 23, not April 30.
* Palestine delays the start of DST this year.
* Much of Greenland still uses DST from 2024 on.

The 2023c release reverts the changes done in 2023b.

[ Test Plan ]

Test cases were added to the autopkgtest to cover the testing:

* python: test_2023a
* python: test_2023c
* python: test_systemv_timezones (for releases <= 20.04 LTS)
* python-icu: test_2023a (only for kinetic, jammy, focal)

So the test plan is to check that the autopkgtest succeeds.

Alternatively the python test_2023a can be run manually:

 * Set system timezone to Egypt (e.g. Africa/Cairo).
 * Set system time to 2023-04-27 23:59.
 * Wait and observe what happens at 2023-04-28 0:00

[Test Case for releases <= 20.04 LTS]

Additionally, an upstream update of tzdata removed the 'old' SystemV timezones, so we should ensure that they are kept in Ubuntu 20.04 LTS and earlier releases. This is done by the test_systemv_timezones test case or can be checked manually with the following:
diff <(zdump -v America/Phoenix | cut -d' ' -f2-) <(zdump -v SystemV/MST7 | cut -d' ' -f2-)

[ Where problems could occur ]

 * Systems with incorrect timezone set (e.g. located outside of Egypt but still using Egyptian time) may observe unexpected time shift.

[ Other Info ]

The autopkgtest for chrony is flaky on jammy and kinetic (see bug #2002910).

 * More information with sources: https://en.wikipedia.org/wiki/Daylight_saving_time_in_Egypt#:~:text=Daylight%20saving%20time%20(DST)%20has,(DST)%20as%20of%202023.

tags: added: se sts
Benjamin Drung (bdrung)
Changed in tzdata (Ubuntu Lunar):
assignee: nobody → Benjamin Drung (bdrung)
summary: - Egypt restoring DST not reflected in tzdata shipped with Ubuntuu
+ tzdata 2023a release - Egypt restoring DST
Benjamin Drung (bdrung)
Changed in tzdata (Ubuntu Lunar):
importance: Undecided → Critical
Changed in tzdata (Ubuntu Kinetic):
importance: Undecided → Critical
Changed in tzdata (Ubuntu Jammy):
importance: Undecided → Critical
Changed in tzdata (Ubuntu Focal):
importance: Undecided → Critical
Changed in tzdata (Ubuntu Bionic):
importance: Undecided → Critical
Changed in tzdata (Ubuntu Lunar):
status: New → Fix Committed
Revision history for this message
Benjamin Drung (bdrung) wrote : Re: tzdata 2023a release - Egypt restoring DST
description: updated
tags: added: patch
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023a-0ubuntu0.22.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Kinetic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Revision history for this message
Benjamin Drung (bdrung) wrote : Re: tzdata 2023a release - Egypt restoring DST
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023a-0ubuntu0.22.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed-jammy
Changed in tzdata (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dariusz, or anyone else affected,

Accepted tzdata into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023a-0ubuntu0.20.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Benjamin Drung (bdrung) wrote : Re: tzdata 2023a release - Egypt restoring DST
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (tzdata/2023a-0ubuntu0.22.04.0)

All autopkgtests for the newly accepted tzdata (2023a-0ubuntu0.22.04.0) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

chrony/4.2-2ubuntu2 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Benjamin Drung (bdrung)
summary: - tzdata 2023a release - Egypt restoring DST
+ tzdata 2023a/2023b release - Egypt restoring DST
Revision history for this message
Benjamin Drung (bdrung) wrote : Re: tzdata 2023a/2023b release - Egypt restoring DST
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
Benjamin Drung (bdrung)
description: updated
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023b-0ubuntu0.22.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (tzdata/2023a-0ubuntu0.22.10.0)

All autopkgtests for the newly accepted tzdata (2023a-0ubuntu0.22.10.0) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

chrony/4.2-2ubuntu2 (amd64, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023b-0ubuntu0.22.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dariusz, or anyone else affected,

Accepted tzdata into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023b-0ubuntu0.20.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Dariusz, or anyone else affected,

Accepted tzdata into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023b-0ubuntu0.18.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote (last edit ): Re: tzdata 2023a/2023b release - Egypt restoring DST

Kinetic verification:
$ sudo timedatectl set-ntp false
$ sudo timedatectl set-timezone "Africa/Cairo"
$ timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 00:00:01 EET 2023

After upgrade to 2023b-0ubuntu0.22.10.0:
$ sudo timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 01:00:01 EET 2023

tags: added: verification-done-kinetic
removed: verification-needed-kinetic
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Jammy verification:
$ sudo timedatectl set-ntp false
$ sudo timedatectl set-timezone "Africa/Cairo"
$ timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 00:00:01 EET 2023

After upgrade to 2023b-0ubuntu0.22.04.0:
$ sudo timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 01:00:01 EET 2023

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Focal verification:
$ sudo timedatectl set-ntp false
$ sudo timedatectl set-timezone "Africa/Cairo"
$ timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 00:00:01 EET 2023

After upgrade to 2023b-0ubuntu0.20.04.0:
$ sudo timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 01:00:01 EET 2023

tags: added: verification-done-focal verification-done-jammy
removed: verification-needed-focal verification-needed-jammy
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Bionic verification:
$ sudo timedatectl set-ntp false
$ sudo timedatectl set-timezone "Africa/Cairo"
$ timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 00:00:01 EET 2023

After upgrade to 2023b-0ubuntu0.18.04.0:
$ sudo timedatectl set-time "2023-04-27 23:59:58" && sleep 3 && date
Fri Apr 28 01:00:01 EET 2023

tags: added: verification-bionic-bionic verification-done
removed: verification-needed verification-needed-bionic
Revision history for this message
Benjamin Drung (bdrung) wrote :

Remaining test for bionic:

```
$ apt install tzdata=2023b-0ubuntu0.18.04.0
$ diff <(zdump -v America/Phoenix | cut -d' ' -f2-) <(zdump -v SystemV/MST7 | cut -d' ' -f2-)
$
```

Also verified that all autopkgtest succeeded: https://autopkgtest.ubuntu.com/packages/tzdata

Benjamin Drung (bdrung)
tags: added: verification-done-bionic
removed: verification-bionic-bionic
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (tzdata/2023b-0ubuntu0.22.10.0)

All autopkgtests for the newly accepted tzdata (2023b-0ubuntu0.22.10.0) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

chrony/4.2-2ubuntu2 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Benjamin Drung (bdrung)
summary: - tzdata 2023a/2023b release - Egypt restoring DST
+ tzdata 2023a/2023b/2023c release - Egypt restoring DST
description: updated
description: updated
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
description: updated
Benjamin Drung (bdrung)
description: updated
Benjamin Drung (bdrung)
description: updated
description: updated
Benjamin Drung (bdrung)
description: updated
Benjamin Drung (bdrung)
description: updated
Revision history for this message
Robie Basak (racb) wrote :
Download full text (4.4 KiB)

Summary: there are too many apparently SRU-inappropriate changes bundled into this upload; please remove them and supply the minimal necessary changes only.

Full review:

This bug has had some unavoidable churn in -proposed due to external factors resulting in multiple releases of tzdata upstream in quick succession. This type of thing usually increases the risk of error in my experience, so I gave this a more thorough SRU review than usual from the perspective of the changes that would be experienced by users. Specifically this is the diff to this upload all the way from what is currently in the -updates pockets.

The pulling in of the actual upstreams (tzdata and icu-data) look fine, assuming that it's OK for the icu-data version to mismatch tzdata as the newest icu-data wasn't available at the time of upload.

I haven't checked the updates to *.pot and *.po but I assume that they are also fine.

The addition and improvement of automated tests are always OK and very welcome.

However, some remaining changes I'm not sure about. These weren't documented in the SRU paperwork, though we (bdrung and I) did discuss them extensively in #ubuntu-release - thank you for explaining them. However I'm still not sure if these changes are appropriate for an SRU.

Generating debconf templates with Python instead of bash seems like a reasonable improvement, but I'd expect this to be done in the development release only. SRU policy says:

> ...the requirements for stable updates are not necessarily the same as those in the development release. When preparing future releases, one of our goals is to construct the most elegant and maintainable system possible, and this often involves fundamental improvements to the system's architecture, rearranging packages to avoid bundled copies of other software so that we only have to maintain it in one place, and so on. However, once we have completed a release, the priority is normally to minimise risk caused by changes not explicitly required to fix qualifying bugs, and this tends to be well-correlated with minimising the size of those changes. As such, the same bug may need to be fixed in different ways in stable and development releases.

I'd therefore not expect this change to be present in the SRU, but instead for the existing mechanism to be used. If the existing mechanism is broken or not practical in some way, then I think this needs a separate SRU bug with a full justification of the reasons so that regression risk can be considered, and a QA plan can be agreed. I appreciate that you added a dep8 test, but it isn't clear to me that the dep8 test covers *all* the previous behaviour. That discussion should happen in that bug.

There are also multiple and extensive changes and refactorings to debian/tzdata.config. Some of these are unnecessary (reordering and normalising of shell syntax) and these mask the remaining changes, making the rest harder to review. Looking past those, there are some additional indirections, but also the removal of at least one indirection (upstream source at [1]) that we discussed. There's also the new use of convert_timezone. If these changes are necessary then they should be covered by...

Read more...

Changed in tzdata (Ubuntu Bionic):
status: Fix Committed → Triaged
Changed in tzdata (Ubuntu Focal):
status: Fix Committed → Triaged
Changed in tzdata (Ubuntu Jammy):
status: Fix Committed → Triaged
Changed in tzdata (Ubuntu Kinetic):
status: Fix Committed → Triaged
Revision history for this message
Benjamin Drung (bdrung) wrote :

Thanks for the detailed response. I stripped down the SRU to the absolute minimum (backport all test cases and fix the issues found by the test cases). Building timezones that differ pre-1970 (LP: #2003797) will be deferred to a subsequent separate SRU. Generating debconf templates with Python instead of bash has some consistency checks included. I will probably have to write test cases to have those consistency checks in the stable releases.

Attached SRU debdiff for kinetic and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/kinetic

Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached SRU debdiff for bionic and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/bionic

Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Robie Basak (racb) wrote :

Review of Kinetic:

This looks much better. Thanks!

> * Test convert_timezone for consistency and fix inconsistencies:

The fixing of inconsistencies are still potential functional changes in an SRU that need their own justification please. Generally we'll only make changes that affect real users, and avoid making changes that we don't think will cause anyone any problem in practice. That still applies here, and so needs the usual SRU justification that considers "user impact". Normally that would go in a separate SRU bug. But is there really a sufficient user impact to justify making this change in a stable release?

Alternatively, could you perhaps use "xfail" type tests, so that they are noted but do not fail the tests in the SRUs?

Or, if you really think the risk *to users* is lower with this fixed (eg. better maintainability resulting in lower risk of regression to users in the future), even accounting for the risk of change, then I think it's be reasonable to consider the case on that basis, but the argument should be documented somewhere.

> * Update debconf template and translations to 2023c-2

The translations changes don't look right to me. For example, in be.po:

@@ -1278,10 +1278,8 @@ msgstr "Мэрыда"
 #. Choices
 #. Translators: do not translate underscores. You can use spaces instead.
 #: ../tzdata.templates:3001
-#, fuzzy
-#| msgid "Mazatlan"
 msgid "Metlakatla"
-msgstr "Мазатлан"
+msgstr ""

 #. Type: select
 #. Choices

Why is this translation being dropped?

I dropped your translation updates, reran debconf-updatepo myself, and got far fewer changes. Is this because previous changes since dropped have been carried forward in lost translations? Please could you check?

Revision history for this message
Benjamin Drung (bdrung) wrote :

Also prepared the ESM updates for trusty and xenial and pushed those to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata

Revision history for this message
Benjamin Drung (bdrung) wrote :

Fixing the inconsistencies are also real issues reported by the user. Timezones that can be selected in debconf which will be converted on upgrade were reported in bug #772024. Converting an existing timezone should result in a timezone that can be selected in debconf for a similar reason. Example: Set the timezone to Europe/Kiev (in tzdata < 2022b). Then upgrade to tzdata. The timezone should be updated to Europe/Kyiv and Kyiv should be the selectable entry in debconf.

Regarding the translations: Most (or all) of the fuzzy translation are wrong. "Мазатлан" is the Belarus translation of "Mazatlan". Mazatlan is a different city than Metlakatla. In Debian I looked at all fuzzy translations and made them "unfuzzy". Except for city renames (like Kiev to Kyiv) the fuzzy names were wrong.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tzdata - 2023b-1exp1ubuntu1

---------------
tzdata (2023b-1exp1ubuntu1) lunar; urgency=medium

  * Merge with Debian experimental (LP: #2012599). Remaining changes:
    - Ship ICU 2022g timezone data which are utilized by PHP in tzdata-icu
    - Do not rename NEWS into changelog.gz, this fixes a build failure on
      moment-timezone.js
    - Point Vcs-Browser/Git to Launchpad
  * Update the ICU timezone data to 2023a (2023b is not available yet)
  * Add autopkgtest test case for ICU timezone data 2023a
  * Add autopkgtest test case for pre-1970 timestamps

tzdata (2023b-1exp1) experimental; urgency=medium

  * Drop /usr/share/zoneinfo/posix (identical to /usr/share/zoneinfo)
    (LP: #2008076)
  * Split right/* timezones into separate tzdata-legacy package (LP: #2008076)
  * Drop providing tzdata-bookworm from tzdata

tzdata (2023b-1) unstable; urgency=medium

  * New upstream version (LP: #2012599):
    - Lebanon delays the start of DST this year.

 -- Benjamin Drung <email address hidden> Fri, 24 Mar 2023 14:10:20 +0100

Changed in tzdata (Ubuntu Lunar):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

FTR, we discussed this further in #ubuntu-release earlier. IMHO, while there may be a good reason for the changes, they should be described in SRU bugs so that their impact can be considered by the SRU team, and QA can be tracked if accepted. I asked for either these changes to be removed, or a re-upload with SRU bugs in place.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Due to our discussion I decided to strip down this upload to update tzdata to 2023c and add the autopkgtests that succeed. All other changes are deferred to follow-up SRUs.

Attached the third iteration of SRU for kinetic and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/kinetic

Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.22.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Kinetic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-kinetic
removed: verification-done verification-done-kinetic
Benjamin Drung (bdrung)
description: updated
Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached the third iteration of SRU for jammy and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/jammy

Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached the third iteration of SRU for focal and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/focal

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (tzdata/2023b-0ubuntu0.22.10.0)

All autopkgtests for the newly accepted tzdata (2023b-0ubuntu0.22.10.0) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

chrony/4.2-2ubuntu2 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#tzdata

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Benjamin Drung (bdrung) wrote :

Attached the third iteration of SRU for bionic and force pushed the changes to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata/+ref/ubuntu/bionic

Revision history for this message
Benjamin Drung (bdrung) wrote :

Also prepared new ESM updates for trusty and xenial and pushed those to https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/+git/tzdata

Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Dariusz, or anyone else affected,

Accepted tzdata into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.22.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Jammy):
status: Triaged → Fix Committed
tags: added: verification-needed-jammy
removed: verification-done-jammy
Revision history for this message
Robie Basak (racb) wrote :

Hello Dariusz, or anyone else affected,

Accepted tzdata into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.20.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in tzdata (Ubuntu Focal):
status: Triaged → Fix Committed
tags: added: verification-needed-focal
removed: verification-done-focal
Revision history for this message
Robie Basak (racb) wrote :

13:51 <rbasak> bdrung: tzdata in Bionic has quite a bit of churn in debian/tzdata.templates, including the removal of Pacific-New from tzdata/Zones/US. I didn't see any removals in the later series. Do we have anything that demonstrates that this is safe? Shouldn't the choice be preserved somehow?

14:53 <bdrung> rbasak, previous SRUs forgot to regenerate debian/tzdata.templates. You could use 2022g and regenerate debian/tzdata.templates to see what previous SRUs should have included in their debdiff.

14:54 <bdrung> rbasak, Pacific-New was added but was never used. upstream removed Pacific-New some time ago.

15:13 <bdrung> rbasak, checked that. 2018a removed Pacific-New

15:19 <rbasak> bdrung: yeah but I wouldn't expect removals to be followed in SRUs. If it was user-selectable, then wouldn't dropping it be a regression for users who might have selected it previously?

15:22 <bdrung> rbasak, yes. That regression would have been happened years ago when upstream removed Pacific-New.

15:26 <rbasak> bdrung: OK, so Pacific-New in bionic-updates today is already broken?

15:27 <rbasak> If that's the case then there will be no SRU regression so that's fine, but I'd like to document that somewhere. Can you confirm and I'll just stick this conversation into a bug comment?

15:28 <bdrung> rbasak, I checked the history. Even 2018d-1 did not have Pacific-New as option (the source package has an outdated tzdata.templates). So it was never selectable for bionic users.

15:29 <bdrung> 2018d-1 was the version of the bionic release.

Changed in tzdata (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed-bionic
removed: verification-done-bionic
Revision history for this message
Robie Basak (racb) wrote :

Hello Dariusz, or anyone else affected,

Accepted tzdata into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tzdata/2023c-0ubuntu0.18.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Dariusz Gadomski (dgadomski) wrote (last edit ):

Verification for kinetic.
I've run autopkgtests locally on tzdata from the proposed pocket using [1]. All newly added tests were successful. Additionally I've run the Egypt DST test manually, like described for the previously tested version.

test_2023a (__main__.TestZoneinfo)
Test Egypt uses DST again from 2023a release. ... ok
test_2023c (__main__.TestZoneinfo)
Test Lebanon's reverted DST delay from 2023c release. ... ok

test_2023a (__main__.TestICU)
Test Egypt uses DST again from 2023a release. ... ok

[1] https://packaging.ubuntu.com/html/auto-pkg-test.html

tags: added: verification-done-kinetic
removed: verification-needed-kinetic
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Verification for jammy. Same procedure as for kinetic above.

tzdata 2023c-0ubuntu0.22.04.0

test_2023a (__main__.TestZoneinfo)
Test Egypt uses DST again from 2023a release. ... ok
test_2023c (__main__.TestZoneinfo)
Test Lebanon's reverted DST delay from 2023c release. ... ok
(...)
test_2023a (__main__.TestICU)
Test Egypt uses DST again from 2023a release. ... ok

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Dariusz Gadomski (dgadomski) wrote (last edit ):

Same procedure again, this time for focal.

tzdata 2023c-0ubuntu0.20.04.0

test_2023a (__main__.TestZoneinfo)
Test Egypt uses DST again from 2023a release. ... ok
test_2023c (__main__.TestZoneinfo)
Test Lebanon's reverted DST delay from 2023c release. ... ok
(...)
test_systemv_timezones (__main__.TestZoneinfo)
(...)
test_2023a (__main__.TestICU)
Test Egypt uses DST again from 2023a release. ... ok

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Bionic verification. Procedure unchanged.

tzdata 2023c-0ubuntu0.18.04

test_2023a (__main__.TestZoneinfo)
Test Egypt uses DST again from 2023a release. ... ok
test_2023c (__main__.TestZoneinfo)
Test Lebanon's reverted DST delay from 2023c release. ... ok
(...)
test_systemv_timezones (__main__.TestZoneinfo)

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Benjamin Drung (bdrung) wrote :

The successful autopkgtest results can also be seen on https://autopkgtest.ubuntu.com/packages/tzdata (ignore the failing i386; this is due to missing dependencies).

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tzdata - 2023c-0ubuntu0.22.10.0

---------------
tzdata (2023c-0ubuntu0.22.10.0) kinetic; urgency=medium

  * New upstream release (LP: #2012599)
    - Egypt now uses DST again, from April through October.
    - This year Morocco springs forward April 23, not April 30.
    - Palestine delays the start of DST this year.
    - Much of Greenland still uses DST from 2024 on.
  * Update the ICU timezone data to 2023c
  * Test timezones using Python's zoneinfo module
  * Add autopkgtest test case for 2023c release
  * Add autopkgtest test case for ICU timezone data 2023a/2023c
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Sun, 02 Apr 2023 15:38:36 +0200

Changed in tzdata (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for tzdata has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tzdata - 2023c-0ubuntu0.22.04.0

---------------
tzdata (2023c-0ubuntu0.22.04.0) jammy; urgency=medium

  * New upstream release (LP: #2012599)
    - Egypt now uses DST again, from April through October.
    - This year Morocco springs forward April 23, not April 30.
    - Palestine delays the start of DST this year.
    - Much of Greenland still uses DST from 2024 on.
  * Update the ICU timezone data to 2023c
  * Test timezones using Python's zoneinfo module
  * Add autopkgtest test case for 2023c release
  * Add autopkgtest test case for ICU timezone data 2023a/2023c
  * Update debconf template and translations

 -- Benjamin Drung <email address hidden> Mon, 03 Apr 2023 13:12:42 +0200

Changed in tzdata (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tzdata - 2023c-0ubuntu0.20.04.0

---------------
tzdata (2023c-0ubuntu0.20.04.0) focal; urgency=medium

  * New upstream release (LP: #2012599)
    - Egypt now uses DST again, from April through October.
    - This year Morocco springs forward April 23, not April 30.
    - Palestine delays the start of DST this year.
    - Much of Greenland still uses DST from 2024 on.
  * Update the ICU timezone data to 2023c
  * Test timezones using Python pytz module
  * Add autopkgtest test case for 2023c release
  * Add autopkgtest test case for ICU timezone data 2023a/2023c
  * Update debconf template and translations
  * Check that the old SystemV timezones are still available

 -- Benjamin Drung <email address hidden> Mon, 03 Apr 2023 13:30:19 +0200

Changed in tzdata (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tzdata - 2023c-0ubuntu0.18.04

---------------
tzdata (2023c-0ubuntu0.18.04) bionic; urgency=medium

  * New upstream release (LP: #2012599)
    - Egypt now uses DST again, from April through October.
    - This year Morocco springs forward April 23, not April 30.
    - Palestine delays the start of DST this year.
    - Much of Greenland still uses DST from 2024 on.
  * Test timezones using Python pytz module
  * Add autopkgtest test case for 2023c release
  * Update debconf template and translations
  * Check that the old SystemV timezones are still available

 -- Benjamin Drung <email address hidden> Mon, 03 Apr 2023 13:52:56 +0200

Changed in tzdata (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.