Comment 34 for bug 2012599

Revision history for this message
Robie Basak (racb) wrote :

Review of Kinetic:

This looks much better. Thanks!

> * Test convert_timezone for consistency and fix inconsistencies:

The fixing of inconsistencies are still potential functional changes in an SRU that need their own justification please. Generally we'll only make changes that affect real users, and avoid making changes that we don't think will cause anyone any problem in practice. That still applies here, and so needs the usual SRU justification that considers "user impact". Normally that would go in a separate SRU bug. But is there really a sufficient user impact to justify making this change in a stable release?

Alternatively, could you perhaps use "xfail" type tests, so that they are noted but do not fail the tests in the SRUs?

Or, if you really think the risk *to users* is lower with this fixed (eg. better maintainability resulting in lower risk of regression to users in the future), even accounting for the risk of change, then I think it's be reasonable to consider the case on that basis, but the argument should be documented somewhere.

> * Update debconf template and translations to 2023c-2

The translations changes don't look right to me. For example, in be.po:

@@ -1278,10 +1278,8 @@ msgstr "Мэрыда"
 #. Choices
 #. Translators: do not translate underscores. You can use spaces instead.
 #: ../tzdata.templates:3001
-#, fuzzy
-#| msgid "Mazatlan"
 msgid "Metlakatla"
-msgstr "Мазатлан"
+msgstr ""

 #. Type: select
 #. Choices

Why is this translation being dropped?

I dropped your translation updates, reran debconf-updatepo myself, and got far fewer changes. Is this because previous changes since dropped have been carried forward in lost translations? Please could you check?