po/Makevars line contuation marks break intltool-update -p

Bug #191920 reported by Kyle Nitzsche
4
Affects Status Importance Assigned to Milestone
claws-mail (Ubuntu)
Fix Released
Low
Emmet Hikory

Bug Description

Binary package hint: claws-mail

claws-mail 3.3.0
file: po/Makevars
section: XGETTEXT_OPTIONS =
This section contains line continuation chars ( "\" ) that cause a misparse fatal error when intltool-update -pot is executed. I will attached a patch that removes them. I mention this to Loic and he reported gnome bug 516501 to fix intltools, but for now let's fix claws so it works.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
Revision history for this message
Scott Kitterman (kitterman) wrote :

The patch needs to be packaged into a debdiff. Please resubscribe UUS after this is done.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Made the patch in debdiff format (first time ever...) and attached.

Revision history for this message
Luke Yelavich (themuso) wrote :

It appears your diff has changes to config.sub and config.guess, which is why its so large. Please remove these before uploading the diff. Also make sure that there aren't two copies of the changes in the one diff, every file that you modified is present twice in the diff, effectively doubling its size.

Changed in claws-mail:
status: New → Incomplete
Revision history for this message
Luke Yelavich (themuso) wrote :

Please upload a new debdiff with the above issues address, and re-subscribe ubuntu-universe-sponsors when done.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

I've made a new debdiff from a new source package to which I made my single change, but the resulting debdiff still contained the changes to config.sub and config.guess. Not sure why this is so. At any rate, I've edited the attached debdiff to contain only the changes that I believe are relevant: debian/changelog and po/Makevars. Please advise if I need to take further corrective actions.

Emmet Hikory (persia)
Changed in claws-mail:
assignee: nobody → persia
importance: Undecided → Low
status: Incomplete → In Progress
Revision history for this message
Emmet Hikory (persia) wrote :

That debdiff is appropriate for review. The additional apparent changes in the autotools hint files come from an unfortunate choice in debian/rules. Thank you for the adjustments. I've uploaded the resulting candidate.

Changed in claws-mail:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package claws-mail - 3.3.0-1ubuntu3

---------------
claws-mail (3.3.0-1ubuntu3) hardy; urgency=low

  * Removed line continuation chars from po/Makevars XGETTEXT_OPTIONS section
    because they cause an xgettext misparse when xgettext is called by
    intltool-update -p (LP: #191920)

 -- Kyle Nitzsche <email address hidden> Fri, 15 Feb 2008 19:18:00 +0000

Changed in claws-mail:
status: Fix Committed → Fix Released
Michael Terry (mterry)
tags: added: oem-services
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.