update-burg generates wrong burg.cfg

Bug #516501 reported by Stefan Saraev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
burg
Fix Released
Undecided
Unassigned

Bug Description

after update-burg in resulting burg.cfg I have:
....
function select_menu {
  if menu_popup -t template_popup theme_menu ; then
    free_config template_popup template_subitem menu
    load_config ${prefix}/themes/${theme_name}/theme
    menu_refresh\n fi\n}\nset theme_name=ubuntu
function toggle_fold {
  if test -z $theme_fold ; then
    set theme_fold=1
  else
    set theme_fold=
  fi
  save_env theme_fold\n menu_refresh\n}
...
  controller.ext\nfi
insmod ext2
...

there are few incorrect '\n's
the result should be:

...
function select_menu {
  if menu_popup -t template_popup theme_menu ; then
    free_config template_popup template_subitem menu
    load_config ${prefix}/themes/${theme_name}/theme
    menu_refresh
  fi
}
set theme_name=ubuntu
function toggle_fold {
  if test -z $theme_fold ; then
    set theme_fold=1
  else
    set theme_fold=
  fi
  save_env theme_fold
  menu_refresh
}
...
  controller.ext
fi
insmod ext2
...

I attached a fix.

Revision history for this message
Stefan Saraev (seo) wrote :
summary: - burg generates wrong burg.cfg
+ update-burg generates wrong burg.cfg
Revision history for this message
bean (bean123ch) wrote :

Thanks, this fix is included in bzr r1820

Stefan Saraev (seo)
Changed in burg:
status: New → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
bean (bean123ch) wrote :

BTW, there is a small issue with echo -e. Ubuntu's sh points to dash, which doesn't understand echo -e, therefore there is an extra -e in the output file. I have changed it to cat << EOF in r1821, which works in both bash and dash.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.