Edit from OPAC View doesnt' close on Save & Exit

[Mary Llewellyn]

Version 3.1

What we did:
Clicked on the Edit link from the OPAC view and made changes to an item in the Volume/Copy Editor.
Clicked on Save & Exit when finished.

What we expected:
The tab for the V/C editor would close, as it does when editing items from Holdings View and Item Status.

What happened:
The item was moved to the Completed Copies tab. The V/C editor tab did not close. It had to be closed manually.

Version 3.5
Same steps.

Expected the Editor tab to close after clicking Save & Exit.

Instead, we get a "Leave site?" message as if no changes had been made. Once the screen is left, refreshing the OPAC view shows the item was indeed edited.

[Mary Llewellyn (mllewell)]

I just tested again in 3.5.2 and found that edits from OPAC view are going to Completed copies instead of saving the changed item and closing the Editor tab.

[Jason Stephenson (jstephenson)]

See the duplicate bug 1914114 for more information and a patch for Evergreen 3.5 and earlier.

This issue appears to be caused by recent security updates in Chrome 88 and Firefox. (It was observed in Firefox 84, but not tested in earlier versions of that browser.)

[Jason Stephenson (jstephenson)]

We installed the patch from bug 1914114 in production on 3.2.10 this morning with no ill effects reported so far.

I will start a collab branch and link it in another comment here.

[Jason Stephenson (jstephenson)]

Here's the collab branch, as promised:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/lp1913219-staffcatalog-edit-link-repair

I'm less sure of a patch for the Angular Staff Catalog, but I have observed this behavior there. If anyone wants to push a fix to the collab branch, then feel free. That's why I've made a collab branch.

[Jane Sandberg (sandbergja)]

Thanks so much, Jason.

I signed off on your commit, and threw an Angular commit into this branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1913219-staffcatalog-edit-link-repair

[Mary Llewellyn (mllewell)]

I just tested on our 3.5 test database, and while the item is no longer sent to Completed Copies, I'm getting the message asking if it's OK to leave the screen. We still don't have an automatic exit after closing.

[Jennifer Bruch (jbruchpails)]

PaILS/SPARK

Just tested this on one of our test servers that has 3.6, still seeing this bug.

[Jason Stephenson (jstephenson)]

Those of you who report still seeing the bug, did you:

1. Apply the patches and reinstall the webstaff client on the server?
2. Clear cache in your browser before testing?

[Jason Stephenson (jstephenson)]

Jane's fix works for me with the Angular editor. I have signed off and pushed both commits to master and rel_3_6.

I tried backporting to rel_3_5 and there was a conflict in Open-ILS/src/eg2/src/app/staff/catalog/record/copies.component.ts that I was not sure how to resolve.

I'm not sure if the Angular client is affected by this in 3.5, anyway, so I'll attempt to retest it there.

I know that that the AngularJS edit is affected and could benefit from my patch.

[Jason Stephenson (jstephenson)]

I have confirmed that the experimental catalog is affected on 3.5.

I will attempt to back port Jane's fix.

[Jason Stephenson (jstephenson)]

I have pushed a backport branch that works for me:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dyrcona/lp1913219-staffcatalog-edit-link-repair-rel_3_5

More eyes welcome. Otherwise I'll likely push it in a day or two.

[Jason Stephenson (jstephenson)]

I pushed the backport to rel_3_5.

Thanks, Jane!