Header does not revert flickable topMargin when it has no parent
Bug #1560419 reported by
Andrea Bernabei
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Tim Peeters | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
High
|
Tim Peeters |
Bug Description
r1886
How to reproduce:
1) Open UITK gallery, it should open in 2 columns mode
2) Go to Bottom Edge page
3) Resize window so that the AdvancedPageLayout switches to 1 column layout
4) Look at the top margin of the Bottom Edge page content
Expected outcome:
The margin is the same as in 2 columns layout
Actual outcome:
The margin changes, and a blank space appears at the top, below the header
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/invisible-header-topmargin
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 410 lines (+112/-58)6 files modifiedsrc/Ubuntu/Components/1.3/Page.qml (+1/-4)
src/Ubuntu/Components/plugin/ucheader.cpp (+30/-22)
src/Ubuntu/Components/plugin/ucheader.h (+2/-2)
tests/unit_x11/tst_components/tst_header.qml (+63/-4)
tests/unit_x11/tst_components/tst_page_with_header.qml (+11/-13)
tests/unit_x11/tst_components/tst_scrollbar_header.qml (+5/-13)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
summary: |
- Header causes wrong flickable.topMargin to be set in BottomEdgePage + Header does not revert flickable topMargin when it has no parent |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Zoltan Balogh (bzoltan) |
importance: | Undecided → High |
milestone: | none → 11 |
Changed in canonical-devices-system-image: | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → Fix Committed |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The reason this is happening is because the BottomEdgePage sets a new PageHeader that overrides the default PageHeader of the gallery Template page. The old PageHeader is no longer visible because it has no parent any more, but it still sets/unsets the flickable topMargin.
I will work on fixing this together with the fix for this bug: https:/ /bugs.launchpad .net/ubuntu/ +source/ ubuntu- ui-toolkit/ +bug/1560458