Tabs and Page with PageHeader shows two headers

Bug #1566741 reported by Stuart Langridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Tim Peeters

Bug Description

If I use a Tabs component, and place a Page in one of the Tabs, and that Page has a new-style PageHeader, then my app shows two separate headers.

import QtQuick 2.4
import Ubuntu.Components 1.3

MainView {
    width: units.gu(70)
    height: units.gu(80)
    Tabs {
        Tab {
            page:Page {
                header: PageHeader {
                    id: pageHeader
                    title: i18n.tr("MyApp")
                }
            }
        }
        Tab {
            title: i18n.tr("Simple page")
            page: Page {
                Label {
                    id: label
                    anchors.centerIn: parent
                    text: "A centered label"
                }
            }
        }
    }
}

Related branches

Revision history for this message
Stuart Langridge (sil) wrote :
Andrea Bernabei (faenil)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Tim Peeters (tpeeters)
Tim Peeters (tpeeters)
description: updated
description: updated
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Tim Peeters (tpeeters) wrote :

We do not support using Tabs in combination with PageHeader. We need to document that, see this bug https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1566735

There will be new tab designs though, and we need to evaluate those to see if we will update the current Tabs component for those patterns (then we have to make it work with PageHeader), or we completely deprecated the old Tabs and we don't fix this bug.

I will try to get the new designs so we can make a more-informed decision.

Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Won't Fix
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1984+16.10.20160527.2

---------------
ubuntu-ui-toolkit (1.3.1984+16.10.20160527.2) yakkety; urgency=medium

  [ Christian Dywan ]
  * Slimmer frame for TextFields: 0.5dp. Fixes LP: #1578190.

  [ Albert Astals Cid ]
  * Add override
    The override specifier (since C++11) specifies that a virtual function
    overrides another virtual function. In a member function declaration or
    definition, override ensures that the function is virtual and is overriding
    a virtual function from the base class.

  [ Tim Peeters ]
  * Fix reference error in PullToRefreshStyle. Fixes LP: #1582843
  * Mark Tab, Tabs, TabBar, PageHeadConfiguration, PageHeadSections,
    PageHeadState, ToolbarButton, ToolbarItems as deprecated in the
    documentation. Fixes LP: #1566735, LP: #1566741.

  [ CI Train Bot ]
  * Resync trunk.

 -- Zoltan Balogh <email address hidden> Fri, 27 May 2016 07:08:44 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.