Tabs and Page with PageHeader shows two headers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Tim Peeters |
Bug Description
If I use a Tabs component, and place a Page in one of the Tabs, and that Page has a new-style PageHeader, then my app shows two separate headers.
import QtQuick 2.4
import Ubuntu.Components 1.3
MainView {
width: units.gu(70)
height: units.gu(80)
Tabs {
Tab {
}
}
}
Tab {
title: i18n.tr("Simple page")
page: Page {
}
}
}
}
}
Related branches
- Zsombor Egri: Approve
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 111 lines (+14/-0)8 files modifiedsrc/Ubuntu/Components/1.3/PageHeadConfiguration.qdoc (+1/-0)
src/Ubuntu/Components/1.3/PageHeadSections.qml (+1/-0)
src/Ubuntu/Components/1.3/PageHeadState.qml (+1/-0)
src/Ubuntu/Components/1.3/Tab.qml (+1/-0)
src/Ubuntu/Components/1.3/TabBar.qml (+1/-0)
src/Ubuntu/Components/1.3/Tabs.qml (+7/-0)
src/Ubuntu/Components/1.3/ToolbarButton.qml (+1/-0)
src/Ubuntu/Components/1.3/ToolbarItems.qml (+1/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
description: | updated |
description: | updated |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Won't Fix |
We do not support using Tabs in combination with PageHeader. We need to document that, see this bug https:/ /bugs.launchpad .net/ubuntu/ +source/ ubuntu- ui-toolkit/ +bug/1566735
There will be new tab designs though, and we need to evaluate those to see if we will update the current Tabs component for those patterns (then we have to make it work with PageHeader), or we completely deprecated the old Tabs and we don't fix this bug.
I will try to get the new designs so we can make a more-informed decision.