The new AdaptivePageLayout should allow replacing primaryPage
Bug #1500934 reported by
Michał Karnicki
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
The new AdaptivePageLayout does not allow replacing of the primaryPage.
Simplest use case:
primaryPage: isSignedIn ? masterPage : signInPage
I've explained in more detail in the #sdk channel, it seems I have convinced two developers the limitation of not allowing to replace the primaryPage now seems arbitrary. Allowing to replace the primaryPage makes the component much more flexible.
Naturally, replacing the primaryPage means all of the pages will be removed, as the primary page is like "tree root" in this situation.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/aplReplacePrimaryPage
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 466 lines (+179/-138)2 files modifiedsrc/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+52/-30)
tests/unit_x11/tst_components/tst_adaptivepagelayout.qml (+127/-108)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
ubuntu-ui-toolkit (1.3.1676+ 15.10.20151006. 2-0ubuntu1) wily; urgency=medium
[ Zsombor Egri ]
* StyledItem does no longer fall back to 1.2 style loading on mixed import
versions.
* Make primaryPage and primaryPageSource replaceable after component
completion. Fixes LP: #1500934
[ Christian Dywan ]
* Merge open_page and _open_page in GalleryTestCase.
[ CI Train Bot ]
* Resync trunk. added: po/zh_HK.po
-- Zoltan Balogh <email address hidden> Tue, 06 Oct 2015 09:11:40 +0000
ubuntu-ui-toolkit (1.3.1676+ 15.04.20151006. 2-0ubuntu1) vivid; urgency=medium
[ Zsombor Egri ]
* StyledItem does no longer fall back to 1.2 style loading on mixed import
versions.
* Make primaryPage and primaryPageSource replaceable after component
completion. Fixes LP: #1500934
[ Christian Dywan ]
* Merge open_page and _open_page in GalleryTestCase.
[ CI Train Bot ]
* Resync trunk. added: po/zh_HK.po