The new AdaptivePageLayout should allow replacing primaryPage

Bug #1500934 reported by Michał Karnicki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri

Bug Description

The new AdaptivePageLayout does not allow replacing of the primaryPage.

Simplest use case:
primaryPage: isSignedIn ? masterPage : signInPage

I've explained in more detail in the #sdk channel, it seems I have convinced two developers the limitation of not allowing to replace the primaryPage now seems arbitrary. Allowing to replace the primaryPage makes the component much more flexible.

Naturally, replacing the primaryPage means all of the pages will be removed, as the primary page is like "tree root" in this situation.

Related branches

Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → Confirmed
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

ubuntu-ui-toolkit (1.3.1676+15.10.20151006.2-0ubuntu1) wily; urgency=medium

  [ Zsombor Egri ]
  * StyledItem does no longer fall back to 1.2 style loading on mixed import
    versions.
  * Make primaryPage and primaryPageSource replaceable after component
    completion. Fixes LP: #1500934

  [ Christian Dywan ]
  * Merge open_page and _open_page in GalleryTestCase.

  [ CI Train Bot ]
  * Resync trunk. added: po/zh_HK.po

 -- Zoltan Balogh <email address hidden> Tue, 06 Oct 2015 09:11:40 +0000

ubuntu-ui-toolkit (1.3.1676+15.04.20151006.2-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * StyledItem does no longer fall back to 1.2 style loading on mixed import
    versions.
  * Make primaryPage and primaryPageSource replaceable after component
    completion. Fixes LP: #1500934

  [ Christian Dywan ]
  * Merge open_page and _open_page in GalleryTestCase.

  [ CI Train Bot ]
  * Resync trunk. added: po/zh_HK.po

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Landed in overlay.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1688+15.10.20151018.1-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1688+15.10.20151018.1-0ubuntu1) wily; urgency=medium

  [ Tim Peeters ]
  * Add delegate property to ActionBar.
  * Introduce PageHeader component.
  * Add header property to Page.
    Fixes LP: #1248898, LP: #1350893, LP: #1445016, LP: #1492328
  * Use the correct navigation overflow icon in PageHeader.

  [ Loïc Molinari ]
  * Fixed OpenGL ES 2 mipmap fallback. OpenGL ES 2 doesn't support
    GL_TEXTURE_MAX_LEVEL by default, it is only available via an extension. It
    was working on the devices where this extension is available but not on
    the emulator. Fixes LP: #1505221.

  [ Christian Dywan ]
  * Handle incubateObject returning null in PageWrapperUtils.
    Fixes LP: #1505197
  * Add module header to PageWrapperUtils.

  [ Zoltan Balogh ]
  * Improve test plan
    - Ad -q parameter to provision the device for normal use with a PPA
    - Fix up the camera and clock app on the device to acces services
    - Replace phablet tools with manual enabling writable image
    - Fix PPA pin up for staging and other regular PPAs.

  [ Zsombor Egri ]
  * Emit Dropped event for live ListItem drag'n'drop. Fixes LP: #1500118.

  [ Timo Jyrinki ]
  * Build dep on libinput-dev and libxkbcommon-dev (LP: #1437192).

  [ Benjamon Zeller ]
  * Remove unused variables.

  [ CI Train Bot ]
  * No-change rebuild.

 -- Zoltan Balogh <email address hidden> Sun, 18 Oct 2015 03:47:27 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.