ListItem feature request: Signal at end of live drag
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Zsombor Egri | ||
Bug Description
When a ListItem is dragged, it emits "Started" and "Moving" events. But if each "Moving" event is accepted, as happens in a live drag case, no "Dropped" event will be emitted when the item is finally dropped. One should be added. The "to" and "from" parameters could both be set to the final position, or they could be set to an invalid value.
Example use cases:
1) Updating an underlying data store. The QML list model may present data stored on disk. (In a database, for instance.) Updating the model may be quick while updating the disk store is slow. It would be nice to be able to give the feedback of the live updates but put off updating the data store until the drag is over. The "Dropped" signal is necessary for this.
2) Changing styling during drag. A developer may want to change some styling of elements other than the dragged element during the drag. For instance, non-dragged items could be shaded so as to be less prominent, or additional information could be presented. The "Dropped" signal is necessary to know when to reset the styles.
3) Consistency in a mixed drag action. By choosing which "Moving" events to accept, a developer can create a situation in which parts of a drag are live and others are not. Currently, the "Dropped" signal will be emitted for some of these drags and not for others. In addition to being surprising, this may complicated clean-up code. If the "Dropped" signal is always emitted, this situation would be simplified.
Related branches
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 184 lines (+63/-43)3 files modifiedsrc/Ubuntu/Components/plugin/privates/listitemdragarea.cpp (+1/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+31/-21)
tests/unit_x11/tst_components/tst_listitem13.qml (+31/-21)
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1688+
---------------
ubuntu-ui-toolkit (1.3.1688+
[ Tim Peeters ]
* Add delegate property to ActionBar.
* Introduce PageHeader component.
* Add header property to Page.
Fixes LP: #1248898, LP: #1350893, LP: #1445016, LP: #1492328
* Use the correct navigation overflow icon in PageHeader.
[ Loïc Molinari ]
* Fixed OpenGL ES 2 mipmap fallback. OpenGL ES 2 doesn't support
GL_
was working on the devices where this extension is available but not on
the emulator. Fixes LP: #1505221.
[ Christian Dywan ]
* Handle incubateObject returning null in PageWrapperUtils.
Fixes LP: #1505197
* Add module header to PageWrapperUtils.
[ Zoltan Balogh ]
* Improve test plan
- Ad -q parameter to provision the device for normal use with a PPA
- Fix up the camera and clock app on the device to acces services
- Replace phablet tools with manual enabling writable image
- Fix PPA pin up for staging and other regular PPAs.
[ Zsombor Egri ]
* Emit Dropped event for live ListItem drag'n'drop. Fixes LP: #1500118.
[ Timo Jyrinki ]
* Build dep on libinput-dev and libxkbcommon-dev (LP: #1437192).
[ Benjamon Zeller ]
* Remove unused variables.
[ CI Train Bot ]
* No-change rebuild.
-- Zoltan Balogh <email address hidden> Sun, 18 Oct 2015 03:47:27 +0000