header icon color should match title label color when backgroundColor is set
Bug #1492328 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Tim Peeters |
Bug Description
If I set a custom background color on a MainView, the color of the title label in the header is computed to make the title readable, but the color of the header icons isn’t, and it may be difficult to see them.
See the attached standalone reproducer, where the background color is green, the title is white (white on green is fairly readable), but the header icon is the default light grey, which makes it very hard to view on the green background. I would expect the icon to be white too.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/40-PageWithHeader
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 411 lines (+279/-12)8 files modifiedcomponents.api (+1/-0)
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+7/-3)
src/Ubuntu/Components/1.3/MainView.qml (+9/-1)
src/Ubuntu/Components/1.3/Page.qml (+40/-0)
src/Ubuntu/Components/1.3/PageTreeNode.qml (+0/-7)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+1/-1)
tests/unit_x11/tst_components/tst_multicolumnheader.qml (+69/-0)
tests/unit_x11/tst_components/tst_page_with_header.qml (+152/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
importance: | Undecided → High |
To post a comment you must log in.
In general Icon color should be same as text color in header. However the new design said a bit different things there.