header icon color should match title label color when backgroundColor is set

Bug #1492328 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Tim Peeters

Bug Description

If I set a custom background color on a MainView, the color of the title label in the header is computed to make the title readable, but the color of the header icons isn’t, and it may be difficult to see them.

See the attached standalone reproducer, where the background color is green, the title is white (white on green is fairly readable), but the header icon is the default light grey, which makes it very hard to view on the green background. I would expect the icon to be white too.

Related branches

Revision history for this message
Olivier Tilloy (osomon) wrote :
Revision history for this message
Zsombor Egri (zsombi) wrote :

In general Icon color should be same as text color in header. However the new design said a bit different things there.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
assignee: nobody → Tim Peeters (tpeeters)
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1688+15.10.20151018.1-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1688+15.10.20151018.1-0ubuntu1) wily; urgency=medium

  [ Tim Peeters ]
  * Add delegate property to ActionBar.
  * Introduce PageHeader component.
  * Add header property to Page.
    Fixes LP: #1248898, LP: #1350893, LP: #1445016, LP: #1492328
  * Use the correct navigation overflow icon in PageHeader.

  [ Loïc Molinari ]
  * Fixed OpenGL ES 2 mipmap fallback. OpenGL ES 2 doesn't support
    GL_TEXTURE_MAX_LEVEL by default, it is only available via an extension. It
    was working on the devices where this extension is available but not on
    the emulator. Fixes LP: #1505221.

  [ Christian Dywan ]
  * Handle incubateObject returning null in PageWrapperUtils.
    Fixes LP: #1505197
  * Add module header to PageWrapperUtils.

  [ Zoltan Balogh ]
  * Improve test plan
    - Ad -q parameter to provision the device for normal use with a PPA
    - Fix up the camera and clock app on the device to acces services
    - Replace phablet tools with manual enabling writable image
    - Fix PPA pin up for staging and other regular PPAs.

  [ Zsombor Egri ]
  * Emit Dropped event for live ListItem drag'n'drop. Fixes LP: #1500118.

  [ Timo Jyrinki ]
  * Build dep on libinput-dev and libxkbcommon-dev (LP: #1437192).

  [ Benjamon Zeller ]
  * Remove unused variables.

  [ CI Train Bot ]
  * No-change rebuild.

 -- Zoltan Balogh <email address hidden> Sun, 18 Oct 2015 03:47:27 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.