Editor: Make display of resources switchable

Bug #778540 reported by Astuur
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned

Bug Description

This is a request for a new editor feature.
Most obviously when designing the altitude profile of a landscape, be it mountain regions or grassland,
the display of mining resources (water, gold, iron, coal and granite) prevents a clear evaluation of the
landscape's altitude changes.
It would be very helpful to be able to switch that display on and off, similar to the buildhelp display.

It would be good to be able to hide immovables as well (c.f. https://bugs.launchpad.net/widelands/+bug/1512089).

Tags: editor ui

Related branches

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

>It would be very helpful to be able to switch that display on and off, similar to the buildhelp display.
Off the top of my head, the easiest way to add this would be to tie resources and buildhelp together, so that both are toggled at the same time. So when turning it on both are shown, and if it's off both are hidden. But I assume you probably want separate toggles instead (?), so we probably have to come up with some other mechanism to toggle this.

Changed in widelands:
importance: Undecided → Wishlist
tags: added: editor ui
Revision history for this message
Astuur (wolfsteinmetz) wrote :

> But I assume you probably want separate toggles instead (?),

to be honest, yes....
You see, changing the terrain altitude will always have an effect on the possible buildings in the region,
so you need to check that constantly, and that is when the ressource display gets in the way.

Revision history for this message
SirVer (sirver) wrote :

I am working on the editor atm and I see this as a useful feature. I will incorporate into my design for improvements.

I might need some 'beta-testers' sooner or later (rather later as I am quite busy atm and I started by cleaning up the editor code which means that I broke more features than added in so far :) ).

Changed in widelands:
assignee: nobody → SirVer (sirver)
status: New → Confirmed
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Astuur: that's more or less what I thought. Thanks for clarifying.

SirVer: I'm pretty busy as well currently, but when you have something working, just ping me and I'll see if I can break it. :)

Revision history for this message
Astuur (wolfsteinmetz) wrote :

@SirVer:
Having the resources hideable, could also be a prompt on starting a new map,
and remembered when loading that map again.
This would help those players that don't want to know where the mining resources are
because they want to play that map themselves.

Revision history for this message
SirVer (sirver) wrote :

Less interuptive would be to just have the display off by default, I guess.

Revision history for this message
Nicolai Hähnle (nha) wrote :

When adding that feature, remember to add a hint to the editor tips, especially if the toggle is bound to a hotkey.

Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
wl-zocker (wl-zocker) wrote :

I still miss this feature. The resources are always displayed and the build help signs are hard to see. This makes it difficult to observe them when changing the heigth of the terrain.
By default, the resources would not be shown (similar to the build help). They can be switched on/off by a key (r if this key does not do anything else).

SirVer (sirver)
Changed in widelands:
status: Incomplete → Confirmed
assignee: SirVer (sirver) → nobody
Revision history for this message
wl-zocker (wl-zocker) wrote :

Concerning the drawing mechanics: The duplicate bug 536612 states that "resources are currently rendered within maploading", so the complete map would need to be rerendered. The resource markers should be turned to overlays instead.

Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver)
Changed in widelands:
status: Expired → Confirmed
GunChleoc (gunchleoc)
description: updated
description: updated
Revision history for this message
kaputtnik (franku) wrote :

> It would be good to be able to hide immovables as well

I am unsure about that. Hiding immovables could lead in changes which a mapmaker does may not intend. F.e. He placed trees somewhere, hide immovables and modify the terrain to water. In Result the trees will stand in water. Same goes for granite stones. And what about critters?

Automatic removing of immovable if the terrains does normally not support this immovable (like trees on water) is another bug which should be solved if immovables could be hided (but rocks on water looks cool :-D )

Normally the immovables do not disturb the view, instead resources do (mostly fish)

Revision history for this message
wl-zocker (wl-zocker) wrote :

Hiding immovables shows how the land will be usable when the player has harvested the resources (talking about trees and rocks here). I am sometimes interested in where players can build big buildings or buildings at all (e.g. for military influence), but this is currently impossible without removing the forest first. If instead I could hide the forest (and the build help would get updated), this was super useful.

Critters are rather small and do rarely disturb my view.

I am unsure whether immovables should be removed. As you mention, they might be used to create nice visual effects.

Revision history for this message
king of nowhere (lainluigi86) wrote :

well, the mapmaker can choose to hide immovables. he can also choose to stop hiding them, if he wants to see how they look or whether they would be in the wrong place. hiding immovables is just another tool, and it's up to the player to use it wisely. and yes, if you are changing the terrain type from meadow to mountain meadow, you want to hide the trees to see how it looks like; if you are instead changing meadow to water, then you want to see the trees and you don't use the tool.

SirVer (sirver)
Changed in widelands:
milestone: none → build20-rc1
SirVer (sirver)
Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.