no "image-missing" fallback if an icon can not be found in the panel

Bug #1525186 reported by Michael Vogt on 2015-12-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity (Ubuntu)
Medium
Michael Vogt
Xenial
Medium
Michael Vogt

Bug Description

I "lost" my indicator-session menu today and had a bit of a hard time figuring out why. After a bit of poking it turned out that the icon theme I'm using (high-contrast) does not have the:
  #define ICON_DEFAULT "system-devices-panel"
icon that indicator-session is using (which is a bug on its own I guess). But not having a fallback is also not nice.

It appears that the panel is happily rendering a zero size icon in this case so the menu is not accessible for me. I poked a bit at it and attached is a patch that should fix it by adding a "image-missing" stock icon if the gicon can not be found.

Related branches

Michael Vogt (mvo) wrote :

To reproduce:
- switch to high-contrast theme in unity-system-settings
- observe that there is no icon for the session-indicator

- rebuild with my patch
- observe that there is an icon now

Note that I see in the log:
"""
WARN 2015-12-11 13:01:35 unity.panel.indicator.entry PanelIndicatorEntryView.cp
p:253 failed to load: /org/gtk/libgtk/icons/24x24/status/image-missing.png
"""

So this indicates that the code that tries to find the icon is wrong in some way. However I still think there is value in having a fallback in the panel "if (!pixbuf)" even if this other issue gets fixed.

Michael Vogt (mvo) wrote :

Fwiw, build finished and it works as expected.

Changed in unity (Ubuntu):
status: New → In Progress
assignee: nobody → Michael Vogt (mvo)
importance: Undecided → Medium
milestone: none → ubuntu-16.04
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.4.0+16.04.20151218-0ubuntu1

---------------
unity (7.4.0+16.04.20151218-0ubuntu1) xenial; urgency=medium

  [ Aneesh Madhavan ]
  * resources: optimize png images (LP: #1023745)

  [ Evan McIntire ]
  * ShortcutHint: Add key shortcut hints for Screenshot and Window
    Screenshot (LP: #1050195)

  [ Marco Trevisan (Treviño) ]
  * CompizShortcutModeller: show menus keybinding can be read from
    settings
  * GnomeKeyGrabber: refcount the actions and remove them only when
    nobody needs (LP: #1525308)
  * LayoutSystem: add ComputeDecorationHeight method to LayoutWindow
    (LP: #1526386)
  * PanelMenuView: ensure that the maximized window is computed when
    setting the monitor (LP: #1526835)
  * SwitcherModel: don't reiterate over windows all the time, keep a
    list and update it (LP: #1526434)
  * TextInput: reduce opacity to warning if only num_lock is enabled
  * Unity: compile a byte regex in order to get proper matching with
    byte cmdline (LP: #1526455)
  * a11y: don't spam the log with warnings when a quicklist is opened
  * a11y: move accessibility stuff to its own directory, adding a
    private lib for building

  [ Michael Vogt ]
  * Display "image-missing" icon in the panel if for some reason a icon
    can not be loaded. (LP: #1525186)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 18 Dec 2015 00:01:39 +0000

Changed in unity (Ubuntu Xenial):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers