no "image-missing" fallback if an icon can not be found in the panel
Bug #1525186 reported by
Michael Vogt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity (Ubuntu) |
Fix Released
|
Medium
|
Michael Vogt | ||
Xenial |
Fix Released
|
Medium
|
Michael Vogt |
Bug Description
I "lost" my indicator-session menu today and had a bit of a hard time figuring out why. After a bit of poking it turned out that the icon theme I'm using (high-contrast) does not have the:
#define ICON_DEFAULT "system-
icon that indicator-session is using (which is a bug on its own I guess). But not having a fallback is also not nice.
It appears that the panel is happily rendering a zero size icon in this case so the menu is not accessible for me. I poked a bit at it and attached is a patch that should fix it by adding a "image-missing" stock icon if the gicon can not be found.
Related branches
lp:~mvo/unity/lp1525186-icon-fallback
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
-
Diff: 51 lines (+19/-1)1 file modifiedpanel/PanelIndicatorEntryView.cpp (+19/-1)
Changed in unity (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Michael Vogt (mvo) |
importance: | Undecided → Medium |
milestone: | none → ubuntu-16.04 |
To post a comment you must log in.
To reproduce: settings
- switch to high-contrast theme in unity-system-
- observe that there is no icon for the session-indicator
- rebuild with my patch
- observe that there is an icon now
Note that I see in the log: indicator. entry PanelIndicatorE ntryView. cp libgtk/ icons/24x24/ status/ image-missing. png
"""
WARN 2015-12-11 13:01:35 unity.panel.
p:253 failed to load: /org/gtk/
"""
So this indicates that the code that tries to find the icon is wrong in some way. However I still think there is value in having a fallback in the panel "if (!pixbuf)" even if this other issue gets fixed.