Software Centre - automatically add app icon to launcher
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Ayatana Design |
High
|
Matthew Paul Thomas | ||
| Unity |
Fix Released
|
High
|
Bilal Akhtar | |
| unity-2d |
Medium
|
Unassigned | ||
| software-center (Ubuntu) |
Medium
|
Gary Lasker | ||
| unity (Ubuntu) |
High
|
Bilal Akhtar | ||
| unity-2d (Ubuntu) |
Medium
|
Florian Boucault |
Bug Description
Binary package hint: software-center
It seems quite a common case where after clicking "install" the user is prompted first with the user password and then with the "add to laucher" option dialog. I was wondering if the second dialog could be avoided providing a way to add it to launcher while it's downloading/
-------
Desired solution:
When a application is installed from the Software Centre it's icon should be automatically pinned to the Launcher. The option in the software centre to "Add [app name] to the launcher?" after installing a application should be removed.
Related branches
- Mikkel Kamstrup Erlandsen (community): Approve on 2012-01-23
- Unity Team: Pending requested 2012-01-20
- Neil J. Patel: Pending requested 2012-01-20
-
Diff: 330 lines (+223/-4)6 files modifiedplugins/unityshell/src/Launcher.cpp (+3/-3)
plugins/unityshell/src/Launcher.h (+1/-0)
plugins/unityshell/src/LauncherController.cpp (+55/-1)
plugins/unityshell/src/LauncherController.h (+2/-0)
plugins/unityshell/src/SoftwareCenterLauncherIcon.cpp (+102/-0)
plugins/unityshell/src/SoftwareCenterLauncherIcon.h (+60/-0)
- Michael Vogt: Pending requested 2011-11-30
-
Diff: 748 lines (+266/-243)6 files modifieddata/ui/gtk3/SoftwareCenter.ui (+20/-4)
softwarecenter/backend/unitylauncher.py (+98/-0)
softwarecenter/ui/gtk3/app.py (+35/-4)
softwarecenter/ui/gtk3/panes/availablepane.py (+91/-2)
softwarecenter/ui/gtk3/panes/softwarepane.py (+2/-193)
test/gtk3/test_unity_launcher_integration.py (+20/-40)
- software-store-developers: Pending requested 2012-01-27
-
Diff: 309 lines (+75/-95)4 files modifieddebian/changelog (+6/-1)
softwarecenter/backend/unitylauncher.py (+8/-27)
softwarecenter/ui/gtk3/panes/availablepane.py (+20/-36)
test/gtk3/test_unity_launcher_integration.py (+41/-31)
tags: | added: design |
Matthew Paul Thomas (mpt) wrote : | #1 |
Changed in software-center (Ubuntu): | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
importance: | Undecided → Medium |
status: | New → Triaged |
assignee: | Matthew Paul Thomas (mpt) → Bilal Akhtar (bilalakhtar) |
Gary Lasker (gary-lasker) wrote : | #2 |
I added a task for the Unity side (corresponding to Bilal's linked branch lp:~bilalakhtar/unity/software-center-integration-for-o). Could somebody please set the importance, and also specify bilalakhtar as the assignee for the Unity task? Thanks!
Gary
Changed in unity: | |
status: | New → Confirmed |
Changed in software-center (Ubuntu): | |
assignee: | Bilal Akhtar (bilalakhtar) → Gary Lasker (gary-lasker) |
status: | Triaged → In Progress |
Gary Lasker (gary-lasker) wrote : | #3 |
I've implemented the basic flow as described in mpt's spec (https:/
Note that this development implementation still uses the current Unity launcher integration capabilities, and so the icon animation and install progress features as described in items 1 through 5 in https:/
The additional animation and progress display features in the launcher will come when the Unity side work in Bilal's branch lp:~bilalakhtar/unity/software-center-integration-for-o is landed in Unity.
Thanks all!
Changed in unity: | |
importance: | Undecided → Medium |
assignee: | nobody → Bilal Akhtar (bilalakhtar) |
Launchpad Janitor (janitor) wrote : | #4 |
This bug was fixed in the package software-center - 5.1.3
---------------
software-center (5.1.3) precise; urgency=low
[ Robert Roth ]
* Show For version x string instead of for this version when the
app version is unknown (LP: #889080)
[ Michael Vogt ]
* lp:~mvo/software-center/system-wide-license-key-fixes:
- add support for installing system-wide license keys
via aptdaemon
* lp:~mvo/software-center/appdetailsview-cleanup:
- lots of cleanup for the details view code, merges appdetailsview
and appdetailsview_gtk, increases unit test coverage
* debian/control:
- update dependency from python-gobject to python-gi
[ Gary Lasker ]
* lp:~gary-lasker/software-center/launcher-integration-for-p:
- implement automatic adding of all newly installed applications to
the Unity launcher per the latest specification, this can be
disabled via menu item "View->Add Applications in Launcher"
(LP: #761851, LP: #756599, LP: #756701, LP: #773769)
* test/graph/
test/
- create a graph to track unit test coverage
[ Kiwinote ]
* lp:~kiwinote/software-center/fix-icon-updating:
- fix _update_app_icon() regression
-- Michael Vogt <email address hidden> Thu, 01 Dec 2011 16:03:34 +0100
Changed in software-center (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in software-center (Ubuntu): | |
status: | Fix Released → In Progress |
Gary Lasker (gary-lasker) wrote : | #5 |
I'm resetting the software-center task to In Progress because there will be one more update needed on the software-center side when the Unity branch is ready to land. Specifically, rather than queuing up all add-to-launcher requests and firing them when the installation has completed (because it is not until that time that we can determine the installed desktop file and icon locations), we will simply fire the add to launcher request to Unity right at the start of the install, per the specification.
Gary Lasker (gary-lasker) wrote : | #6 |
Omer, thanks for updating the importance and assignee, you rock! :)
tags: | added: udp |
Changed in ayatana-design: | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
importance: | Undecided → High |
status: | New → Fix Committed |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Bilal Akhtar (bilalakhtar) |
Gary Lasker (gary-lasker) wrote : | #7 |
Hi Bilal! Please be sure to use the attached branch lp:~gary-lasker/software-center/launcher-integration-lp761851 when you are developing/
The primary difference between this branch and trunk is that in this branch we fire the dbus call to the Unity launcher service immediately at the start of the application install, whereas in trunk we queue it up because we can't fire it until install is complete so that we can know the correct installed locations for the desktop file and the application icon.
Note that, as you and I have discussed previously, on the Unity side you will need to monitor aptdaemon's events on the dbus in order to display the install progress in the launcher, as well as to detect when a transaction has completed, or if it has failed or been canceled. Once the installation has completed, you can determine the installed locations for the application desktop file and icon (for reference, in the software-center branch you can find the code we used for this in the file softwarecenter/
As always, thank you for your work on this! And please be sure to ping me if you have any questions or if there's anything at all I can do to help.
description: | updated |
summary: |
- add to launcher request after started installing + Software Centre - automatically add app icon to launcher |
Changed in software-center (Ubuntu): | |
status: | In Progress → New |
Changed in ayatana-design: | |
status: | Fix Committed → New |
Omer Akram (om26er) wrote : | #8 |
could you please not change the bug status without a comment.
Changed in ayatana-design: | |
status: | New → Fix Committed |
Changed in software-center (Ubuntu): | |
status: | New → In Progress |
John Lea (johnlea) wrote : | #9 |
@riyadi27; and could you no change the status in ayatana-design at all, this should only be done by the design team. thanks!
Bilal Akhtar (bilalakhtar) wrote : | #10 |
I've updated my branch and the merge request here:
https:/
Sorry for all the delays, this time things are moving much faster. Most of the tougher parts of the code have landed already, and I can anticipate the rest to land by Alpha 2.
Now that we have Bilal's branch in lp:unity I see two remaining tasks:
1) landing lp:~gary-lasker/software-center/launcher-integration-lp761851 Remove
2) Adding support for the same feature to unity-2d
Who will pick up on this?
Bilal Akhtar (bilalakhtar) wrote : | #12 |
As Mikkel has already mentioned, my branch has landed into lp:unity which contains everthing except the animation and the wiggle (which I'll add after my exams or something).
The branch lp:~gary-lasker/software-center/launcher-integration-lp761851 needs to now go into lp:software-center . I'm sure Michael or Gary can do that.
Changed in unity: | |
status: | In Progress → Fix Committed |
milestone: | none → 5.2.0 |
Gary Lasker (gary-lasker) wrote : | #13 |
Hello Bilal and Mikkel! Indeed, we are ready to merge lp:~gary-lasker/software-center/launcher-integration-lp761851 and plan to release this at the same time that 5.2.0 goes out. We'll do our best to stay coordinated on it. Mikkel and didrocks are both aware that we want to release these as close to the same time as possible, so we should be in good shape. We'll be paying attention on Thursday! :)
I want to say thanks again Bilal for your great work on this!! I can't wait to see this feature finally in action in the world (and I look forward to the last pieces of functionality that you are working on). It's gonna be very cool.
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Launchpad Janitor (janitor) wrote : | #14 |
Status changed to 'Confirmed' because the bug affects multiple users.
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Launchpad Janitor (janitor) wrote : | #15 |
This bug was fixed in the package unity - 5.2.0-0ubuntu1
---------------
unity (5.2.0-0ubuntu1) precise; urgency=low
* New upstream release.
- Unity needs a way to switch (tab) between windows on current workspace
(LP: #863399)
- compiz crashed with SIGSEGV in BamfLauncherIco
(LP: #865840)
- Gradual degradation in desktop performance. (LP: #888039)
- compiz (unity) crashes with SIGSEGV when a window is minimized.
(LP: #918329)
- FavoriteStore external change support (LP: #681503)
- Launcher - Make Launcher left of screen reveal more responsive and less
prone to false positives (LP: #765819)
- Window auto-maximise functionality should be disabled on monitors with a
resolution above 1024 x 600 (LP: #797808)
- Dash: very high latency responding to input (LP: #828582)
- Dash - Behaviour of the 'All' button in the Dash filters broken in
several ways (LP: #841864)
- alt-tab - The app title in the top left of the top bar should change as
the alt-tab focus changes (LP: #855516)
- Keyboard shortcut - Add keyboard shortcut hint overlay that is displayed
when a user presses and holds the Super key (LP: #855532)
- Unity crashes when started in an environment without utouch support
(LP: #860707)
- Dash - Remove Dash Home shortcut icons (LP: #885738)
- Dash - Most Frequently Used apps change to Recently Used, without
Launcher favorites (LP: #893214)
- Should have a launcher on every monitor (LP: #915944)
- Launcher autohide behaviour on multi-monitor (LP: #915946)
- the unity wrapper should kill compiz before restarting it (LP: #919132)
- Launcher - Implement workspace/launcher cross interactions (LP: #690143)
- Application icons should only display windows from the current workspace
in the window spread (LP: #689733)
- Notification area ("system tray") missing when using dual monitors of
different sizes, with their bottoms aligned (LP: #778256)
- Clicking Nautilus launcher icon fails to open a Nautilus file explorer
window when copying a file and all other Nautilus windows are closed /
bamf should skip the taskbar (LP: #784804)
- Dash - the search box is not aligned correctly relative to the Launcher
BFB button (LP: #838904)
- Dash - A expand/collapse arrow is missing from all the filter category
headers (LP: #841870)
- Dash - the filter buttons should not have a mouse over state
(LP: #838901)
- Dash - the "Filter results" text is the wrong size, wrong font weight,
and aligned incorrectly in both the vertical and horizontal axis
(LP: #863240)
- Add SUPER+TAB switching mode that enables the user to switch
applications via the Launcher (LP: #891620)
- Software Centre - automatically add app icon to launcher (LP: #761851)
- Compiz add transparency to titlebar along with the panel (LP: #912682)
- The search box is too opaque and dark (LP: #913717)
- Dash - Make statefulness of Dash Home and Dash Lenses consistent
(LP: #914759)
- Unity 5.0: "All" button for filters render as "..." (LP: #91...
Changed in unity (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in unity-2d: | |
status: | New → Confirmed |
Launchpad Janitor (janitor) wrote : | #16 |
This bug was fixed in the package software-center - 5.1.8
---------------
software-center (5.1.8) precise; urgency=low
[ Michael Vogt ]
* softwarecenter/
- trivial fix to skip unreadable app-install-data files
* lp:~mvo/software-center/device-profiles:
- implement the hardware-
the detailsview
* lp:~mvo/software-center/arb-partner-channels:
- add support for extras.ubuntu.com and archive.
channel detection and adding via software-
* data/software-
- do not show "X-Publishing" in education because the
software-
compatibility with the old clients
* lp:~mvo/software-center/fix-cachedir-for-public-api:
- add missing cachedir argument
* lp:~mvo/software-center/region-support:
- add support for a region tag and display a warning to
the user if an application is not suitable for their
region
[ Brendan Donegan ]
* lp:~brendan-donegan/software-center/test_utils_get_nice_date_string:
- add a test function in test_utils.py which covers all of
get_
[ Gary Lasker ]
* lp:~gary-lasker/software-center/launcher-integration-lp761851:
- update to the Unity launcher integration implementation to
support the revamped functionality on the Unity side (LP: #761851)
* lp:~gary-lasker/software-center/recommends-ui-lobby:
- initial recommends UI implementation, limited to non-personalized
recommends currently
* lp:~gary-lasker/software-center/appdetailsview-button-focus-fix:
- make sure the action button in the applications details view
always gets the initial focus (LP: #925613)
-- Michael Vogt <email address hidden> Fri, 03 Feb 2012 18:34:43 +0100
Changed in software-center (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in unity-2d: | |
assignee: | nobody → Florian Boucault (fboucault) |
Changed in unity-2d (Ubuntu): | |
assignee: | nobody → Florian Boucault (fboucault) |
Changed in unity-2d: | |
assignee: | Florian Boucault (fboucault) → Gerry Boland (gerboland) |
milestone: | none → 5.4 |
Changed in unity-2d: | |
milestone: | 5.4 → 5.6 |
Changed in unity-2d: | |
importance: | Undecided → Medium |
Changed in unity-2d (Ubuntu): | |
importance: | Undecided → Medium |
Bilal Akhtar (bilalakhtar) wrote : | #17 |
Recent Unity changes broke SC integration with the launcher, so I've fixed it in the linked branch.
Changed in unity: | |
status: | Fix Released → In Progress |
Changed in unity (Ubuntu): | |
status: | Fix Released → In Progress |
Changed in unity: | |
importance: | Medium → High |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
Changed in unity: | |
milestone: | 5.2.0 → 5.6.0 |
Omer Akram (om26er) wrote : | #18 |
okay, this issue was fixed in the past now we just have a regression that is being tracked in bug 932280
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in unity: | |
status: | In Progress → Fix Released |
milestone: | 5.6.0 → none |
Bilal Akhtar (bilalakhtar) wrote : | #19 |
The regression is being tracked in bug #932280. Meanwhile, I've completed second phase too, so everything specified in the spec is complete now. Second phase merge request: https:/
Changed in unity-2d: | |
milestone: | 5.6 → 5.8 |
Changed in unity-2d: | |
assignee: | Gerry Boland (gerboland) → nobody |
Changed in unity-2d: | |
milestone: | 5.8 → 5.10.0 |
Changed in unity-2d: | |
milestone: | 5.10.0 → 5.12 |
tags: | added: delta-with-3d |
Changed in unity-2d: | |
milestone: | 5.12 → none |
Albert Astals Cid (aacid) wrote : | #20 |
I've marked the fixes as released for Unity-2d since trying with Unity-2d 5.8 the behaviour of adding the program tile to the launcher on install is already there (It has a bug in which the icon wrongly has a ? instead of the real icon) but the main functionality is there
Changed in unity-2d: | |
status: | Confirmed → Fix Released |
Changed in unity-2d (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignp removed: udp |
The item should just be added to the launcher, and then you can remove it if you want. /wiki.ubuntu. com/SoftwareCen ter#launching
https:/