aa-logprof: german translation: ERROR: PromptUser: Ungültiges Tastenkürzel für V: Änderungen ansehen

[Detlef]

after the last Erl(a)uben [Allow] theres an errormessage:
"ERROR: PromptUser: Ungültiges Tastenkürzel für V: Änderungen ansehen"
see here:

Profil: /usr/bin/snap
Pfad: /sys/kernel/security/apparmor/features/policy/versions/v5
Neuer Modus: r
Schweregrad: 4

 [1 - /sys/kernel/security/apparmor/features/policy/versions/v5 r,]
Erl(a)uben / [A(b)lehnen] / (I)gnorieren / (G)lob / Glob with (E)xtension / (N)eu / Audi(t) / Abb(r)echen / En(d)e
/sys/kernel/security/apparmor/features/policy/versions/v5 r, wird zum Profil hinzugefügt.

ERROR: PromptUser: Ungültiges Tastenkürzel für V: Änderungen ansehen [view changes]

imho it's a translation error.

[Detlef (guzzirentner)]

there is indeed a mistake in the translation, in a test profile with en-us setting aa-logprof works. please check the translated versions. tnx.

[Detlef (guzzirentner)]

workaround:
LANG=en_US.utf8 LANGUAGE=en_US sudo -s
aa-logprof

and whatever as admimistrator ...

[Christian Boltz (cboltz)]

That's interesting[tm] - in all branches I checked, '(V)iew changes' is not translated to german...

Which AppArmor version and which distribution do you use?

[Detlef (guzzirentner)]

apparmor 2.12-4ubuntu5.1 amd64 user-space parser utility for AppArmor
apparmor-easyprof 2.12-4ubuntu5.1 all AppArmor easyprof profiling tool
apparmor-notify 2.12-4ubuntu5.1 all AppArmor notification system
apparmor-utils 2.12-4ubuntu5.1 amd64 utilities for controlling AppArmor
dh-apparmor 2.12-4ubuntu5.1 all AppArmor debhelper routines
libapparmor-perl 2.12-4ubuntu5.1 amd64 AppArmor library Perl bindings
libapparmor1:amd64 2.12-4ubuntu5.1 amd64 changehat AppArmor library
python3-apparmor 2.12-4ubuntu5.1 amd64 AppArmor Python3 utility library
python3-libapparmor 2.12-4ubuntu5.1 amd64 AppArmor library Python3 bindings

LSB Version: core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
Distributor ID: Ubuntu
Description: Ubuntu 18.04.2 LTS
Release: 18.04
Codename: bionic

Linux 5.0.9-050009-generic #201904200830 x86_64

possibly here?
aa-logprof:
25 # setup module translations
26 from apparmor.translations import init_translation
27 _ = init_translation()

[Christian Boltz (cboltz)]

That makes it even more interesting[tm]

AppArmor 2.12 was released in december 2017, but git blame utils/po/de.po says "(V)iew changes" is untranslated since (at least) 2014:

e67f6561c (Launchpad Translations on behalf of apparmor-dev 2014-09-12 05:53:50 +0000 1192) msgid "(V)iew Changes"
e67f6561c (Launchpad Translations on behalf of apparmor-dev 2014-09-12 05:53:50 +0000 1193) msgstr ""

so even if translation handling of course gets set up, it can't translate something out of thin air.

John, Seth, Steve - does Ubuntu have translations that aren't upstream, or do you have another idea where "Änderungen ansehen" could come from?

[Seth Arnold (seth-arnold)]

Here we are:

https://translations.launchpad.net/ubuntu/bionic/+source/apparmor/+pots/apparmor-utils/de/205/+translate

Thanks

[Christian Boltz (cboltz)]

Great[tm]. I downloaded the "po diff" file, and it seems someone broke several hotkeys :-(

# This file is a partial export from Launchpad.net.
# See https://help.launchpad.net/Translations/PartialPOExport
# for more information.

#: ../apparmor/ui.py:260
msgid "(V)iew Profile"
msgstr "V: Profil ansehen"

#: ../apparmor/ui.py:261
msgid "(U)se Profile"
msgstr "U: Profil verwenden"

#: ../apparmor/ui.py:262
msgid "(C)reate New Profile"
msgstr "C: Neues Profil erstellen"

#: ../apparmor/ui.py:263
msgid "(U)pdate Profile"
msgstr "U: Profil aktualisieren"

#: ../apparmor/ui.py:264
msgid "(I)gnore Update"
msgstr "I: Aktualisierung ignorieren"

#: ../apparmor/ui.py:267
msgid "(U)pload Changes"
msgstr "U: Änderungen hochladen"

#: ../apparmor/ui.py:268
msgid "(V)iew Changes"
msgstr "V: Änderungen ansehen"

Seth, can you please delete these translations and then make sure to get a fixed package released?

Please also check if other languages were broken in a similar way.

Needless to say that upstream AppArmor has automated tests to prevent damage like this :-/

[Seth Arnold (seth-arnold)]

It looks like only the German translations broke the hotkeys. All the others in the apparmor-utils.po files I've got on my local Ubuntu mirror are either:

- empty
- translated

I've prepared a small table for each string you selected to show which languages use empty strings, which languages use translated strings, and if they translated, which key they used. (Some languages are in two lists because there are multiple versions of each package.)

msgid "(V)iew Profile"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru sv uk
            V L V V V

msgid "(U)se Profile"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru uk
            U G U U

msgid "(C)reate New Profile"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru uk
            C B C C

msgid "(U)pdate Profile"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru sv uk
            u P U U U

msgid "(I)gnore Update"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru sv uk
            I A I I I

msgid "(U)pload Changes"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru uk
            U U U U

msgid "(V)iew Changes"

broken: de
empty: de es fr hi it ko pl pt sv tr ug uk
translated: bs id ru sv uk
            V L V V V

id appears to be the only one to pick different letters.

Thanks

[Seth Arnold (seth-arnold)]

Hello German translators, what's involved in fixing translations and pushing an updated translation package to users? The new strings have broken some AppArmor utilities.

I believe the lines that need fixing:

language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(V)iew Profile"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "V: Profil ansehen"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)se Profile"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Profil verwenden"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(C)reate New Profile"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "C: Neues Profil erstellen"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)pdate Profile"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Profil aktualisieren"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(I)gnore Update"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "I: Aktualisierung ignorieren"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)pload Changes"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Änderungen hochladen"
--
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(V)iew Changes"
language-pack-de_18.04+20190117/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "V: Änderungen ansehen"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(V)iew Profile"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "V: Profil ansehen"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)se Profile"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Profil verwenden"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(C)reate New Profile"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "C: Neues Profil erstellen"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)pdate Profile"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Profil aktualisieren"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(I)gnore Update"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "I: Aktualisierung ignorieren"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(U)pload Changes"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "U: Änderungen hochladen"
--
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(V)iew Changes"
language-pack-de_19.04+20190408/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "V: Änderungen ansehen"

and

language-pack-de-base_19.04+20190304/data/de/LC_MESSAGES/apparmor-utils.po:msgid "(V)iew Profile"
language-pack-de-base_19.04+20190304/data/de/LC_MESSAGES/apparmor-utils.po-msgstr "V: Profil...

[Gunnar Hjalmarsson (gunnarhj)]

@Seth: The translators don't deal with the language pack packages directly. What's needed is that a German translator fixes those strings via LP:

https://translations.launchpad.net/ubuntu/disco/+source/apparmor/+pots/apparmor-utils/de

Then, once the corrected translations have made it to the weekly builds in the PPA for the purpose (<https://launchpad.net/~ubuntu-langpack/+archive/ubuntu/ppa>), and if it's considered important enough, we can ask Łukasz Zemczak to copy the German langpacks to -proposed so they can be tested before being moved to -updates. This is the documented procedure:

https://wiki.ubuntu.com/Translations/LanguagePackUpdateRequest

Maybe this bug report can be used for the purpose, though.

[Christian Boltz (cboltz)]

> id appears to be the only one to pick different letters.

For the records: changing the hotkeys is allowed, but you have to make sure that you don't cause hotkey conflicts. To be sure, run the updated translation through the AppArmor utils tests - or ask me to run these tests ;-)

> and if it's considered important enough

Currently aa-logprof (and likely also aa-genprof and aa-mergeprof) are completely broken by these translations - IMHO that qualifies as "important enough" ;-)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Gunnar Hjalmarsson (gunnarhj)]

This seems to have been fixed in eoan; disco is EOL. Closing.