Comment 9 for bug 1904419

Revision history for this message
Frank Heimes (fheimes) wrote :

Ok, so the following two topics remain:

1)
"Fixing unneeded extra conversion of IPC_INFO and SHM_INFO for __IPC_TIME64, since their information does not contain any time related fields."
Fixed with:

commit "sysvipc: Fix IPC_INFO and SHM_INFO handling [BZ #26636]"
(https://sourceware.org/git/?p=glibc.git;a=commit;h=0b9460d22e285432d232f42c7442a3226e1bf830)
"Bug 26636 - 32-bit shmctl(IPC_INFO) crashes when shminfo struct is at the end of a memory mapping "
(https://sourceware.org/bugzilla/show_bug.cgi?id=26636)
and
commit "sysvipc: Fix IPC_INFO and MSG_INFO handling [BZ #26639]"
(https://sourceware.org/git/?p=glibc.git;a=commit;h=c4aeedea598a1bd80f52ca9ebd07fe447680d491)
"Bug 26639 - msgctl IPC_INFO and MSG_INFO return garbage "
(https://sourceware.org/bugzilla/show_bug.cgi?id=26639)

2)
With SEM_STAT_ANY the buffer argument is not properly passed over (in contrast to just SEM_STAT).
Fixed with:

commit "sysvipc: Fix SEM_STAT_ANY kernel argument pass [BZ #26637]"
(https://sourceware.org/git/?p=glibc.git;a=commit;h=9b139b6b81a5def91bec01f30301acc95fbf0289)
"Bug 26637 - semctl SEM_STAT_ANY fails to pass the buffer specified by the caller to the kernel "
(https://sourceware.org/bugzilla/show_bug.cgi?id=26637)

(skipping resolv)

Since the integration of such patches in Ubuntu require that an SRU justification is provided;
https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template
I'm wondering what the real impact is? And if there is a known reproducer available?

For 1) is it just performance improvements due to the unneeded conversion or did something broke (particularly on s390x) ?

For 2) again is it just an improved performance due to the fact that the buffer was not properly passed over or did the erroneous passing over of the buffer led to errors and broke something?

How were these issues identified - due to code analysis or by users that raised bugs?

From the commits I noticed that there are regression test cases mentioned.
But I'm not sure if that's sufficient for the needed SRU TestCase section (https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template).