no clear indication that format has been selected

[Scott Cowles Jacobs]

STEPS TO REPRODUCE
 1. Select manual partitioning
 2. Select a partition
 3. Click "Edit"
 4. Click the "Format" radio button
 5. Click "OK"
 6. Note anywhere that formatting is mentioned
 7. Select the partition
 8. Click "Edit"
 9. Click the "Format" radio button
10. Click "OK"

EXPECTED BEHAVIOR
 * The main screen would have a column showing whether or not formatting has been selected
 * The "Format" radio button would be selected in the dialog upon further edits
 * In the summary screen, formatting is only done once

ACTUAL BEHAVIOR
 * The main screen shows no information about whether or not formatting is to occur
 * The "Keep" radio button is selected in the dialog upon further edits
 * In the summary screen, formatting is shown twice

AFFECTED VERSIONS
calamares 3.2.0-1 - 3.2.4-0ubuntu3
18.10 - 20.04 (and possibly more)

[Scott Cowles Jacobs (scott092707)]

As of the 2018-07-12 .iso,

( newer calamares 3.2.1-1 and
the same partitionmanager 3.3.1-2 )

the situation is the same.

[In case calamares-settings-lubuntu is involved,
the original version was 2, and the current = 7. ]

[Scott Cowles Jacobs (scott092707)]

As of the Beta release (03/26) of Lubuntu 19.04, the same thing occurs.

calamares 3.2.4-0ubuntu1
calamares-settings-lubuntu 1:19.04.3
calamares-settings-ubuntu-common 1:19.04.3
partitionmanager 3.3.1-5

[Chris Guiver (guiverc)]

I noted somewhat similar behavior in https://bugs.launchpad.net/ubuntu/+source/calamares/+bug/1822249 where I say
"I noticed what appeared (twice at that stage) where I'd selected "format" a partition, when I re-entered the partition [settings] it seemed to show "keep". I was re-opening to explore that before seeing if I was mistaken, or it is an issue when the calamares installer disappeared off screen (crash)."
----

Exploring this further today (daily image 20190407) has been problematic with calamares regularly crashing. Installed on my system (d780) is a prior QA full-disk install so only a single partition.

If I enter manual-partition, select the sda1, select 'edit', choose content: 'format' mount.point: "/" with flags:"boot" then click okay to go back to partitions overview, when I re-enter sda1 i would expect it to still say 'format' but instead it says "keep".

I can change it again, if it doesn't crash on exit (which currently occurs more often than not), it'll return back to "keep" if I get back in to check the status.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Chris Guiver (guiverc)]

I also noted in https://bugs.launchpad.net/ubuntu/+source/calamares/+bug/1822249

Lubuntu 19.04 Manual Partitioning Install
Daily Image : 20190326.1

On selecting a pre-existing partition, I have the option of 'keep' or 'format'. I'm trying to 'format' my / partition so I select format. I'm happy with settings (have selected / as mount point, 'format' & 'boot' as option) so I exit to select next partition (say my /home).

I however decide to go back & check my / partition which should be 'format', but when I re-enter it, I find it's set to 'keep'. I've tried this many times (only today's ISO) and have discovered the same nearly each time. It could be it flips to 'keep' whenever you enter; but given I've set it to 'format' I'd expect it to say 'format'.

I was exploring this when I had the crash that caused this bug report, but have since rebooted and the 'format' is being flipped to 'keep' I'm convinced (though if you enter many times, it seems to stop flipping??)

[Chris Guiver (guiverc)]

Thank you for reporting this bug to Ubuntu.

Ubuntu 19.10 (eoan) reached end-of-life on July 17, 2020.
Ubuntu 19.04 (disco) reached end-of-life on January 23, 2020.
Ubuntu 18.10 (cosmic) reached end-of-life on July 18, 2019.

See this document for currently supported Ubuntu releases:
https://wiki.ubuntu.com/Releases

We appreciate that this bug may be old and you might not be interested in discussing it any more. But if you are then please upgrade to the latest Ubuntu version and re-test. If you then find the bug is still present in the newer Ubuntu version, please add a comment here telling us which new version it is in.

[Chris Guiver (guiverc)]

Having just completed a 20.04.2 QA-test install..
I've changed my mind; this bug still applies in focal

Recommend the "New" be returned to Triaged; sorry my mistake.

[Chris Guiver (guiverc)]

I'll add FORMAT I consider easy to see in the summary screen

https://photos.app.goo.gl/5hUYYXCxQEP8BBpd9

20.04.2 summary screen (QA-test) on
- sony vaio svp112a1cw (i5-9400u, 4gb, intel haswell-ULT)

[Chris Guiver (guiverc)]

I've explored this issue again with another FOCAL install and I'll disagree with myself (comment #7).

On selecting FORMAT, the label /dev/sda2 changes to "New Partition" which is a pretty clear indicator that it's FORMAT selected.

It doesn't change (remaining /dev/sda2) when "KEEP" is selected (you can tell it was selected because it now has a mount location).

As such I'll return this to incomplete, and remove the 'focal' tag.
(Fix Released doesn't apply given the upstream bug report)

[ԜаӀtеr Ⅼарсһуnѕkі (wxl)]

I just checked this and I can confirm that it is still affecting Focal, which is consistent with the fact that the upstream bug has not been updated. Look at the picture in the upstream issue and it should be clearer. Also the other two conditions of expected results aren't met.