calamares crashed with SIGSEGV in KPMHelpers::isPartitionNew()

[Chris Guiver]

Lubuntu 19.04 QA checklist installs.

This install was going to re-use my partitions (keep my /home & format my /) and have auto-login enabled using manual partitioning.

I noticed what appeared (twice at that stage) where I'd selected "format" a partition, when I re-entered the partition [settings] it seemed to show "keep". I was re-opening to explore that before seeing if I was mistaken, or it is an issue when the calamares installer disappeared off screen (crash).

Sure enough there was a crash report in /var/crash, which `ubuntu-bug` caused this report.

Only significant behavior was re-entering (to view) partitions a few times exploring the 'keep' or 'format' option which I'm suspicious is flipping 'keep' when it shouldn't.

---
I've done more exploration/testing of the keep/format option & so have added some notes at the bottom, which is an issue I've logged here instead of a new bug report.

ProblemType: Crash
DistroRelease: Ubuntu 19.04
Package: calamares 3.2.4-0ubuntu1
ProcVersionSignature: Ubuntu 5.0.0-7.8-generic 5.0.0
Uname: Linux 5.0.0-7-generic x86_64
.etc.calamares.modules.automirror.conf:
 ---
 baseUrl: archive.ubuntu.com
 distribution: Lubuntu
 geoIpUrl: https://ipapi.co/json
.etc.calamares.modules.finished.conf:
 ---
 restartNowChecked: true
 restartNowEnabled: true
 restartNowCommand: "systemctl -i reboot"
.etc.calamares.modules.partition.conf:
 efiSystemPartition: "/boot/efi"
 enableLuksAutomatedPartitioning: true
 neverCreateSwap: true
 drawNestedPartitions: true
.etc.calamares.modules.shellprocess_logs.conf:
 ---
 dontChroot: true
 timeout: 30
 script:
     - calamares-logs-helper @@ROOT@@
.etc.calamares.modules.unpackfs.conf:
 ---
 unpack:
     - source: "/cdrom/casper/filesystem.squashfs"
         sourcefs: "squashfs"
         destination: ""
ApportVersion: 2.20.10-0ubuntu23
Architecture: amd64
CasperVersion: 1.402
CurrentDesktop: LXQt
Date: Fri Mar 29 17:58:38 2019
ExecutablePath: /usr/bin/calamares
ExecutableTimestamp: 1550273216
LiveMediaBuild: Lubuntu 19.04 "Disco Dingo" - Alpha amd64 (20190326.1)
ProcCmdline: calamares
ProcCwd: /home/lubuntu
ProcEnviron:
 SHELL=/bin/bash
 LANG=C.UTF-8
 TERM=qterminal
 XDG_RUNTIME_DIR=<set>
 PATH=(custom, no user)
RelatedPackageVersions:
 calamares-settings-ubuntu-common 1:19.04.3
 calamares-settings-lubuntu 1:19.04.3
 xfsprogs 4.15.1-1ubuntu1
 btrfs-progs 4.20.2-1
SegvAnalysis:
 Segfault happened at: 0x7f9b8f157f10 <_ZN10KPMHelpers14isPartitionNewEP9Partition>: cmpl $0x1,0x90(%rdi)
 PC (0x7f9b8f157f10) ok
 source "$0x1" ok
 destination "0x90(%rdi)" (0x00000090) not located in a known VMA region (needed writable region)!
SegvReason: writing NULL VMA
Signal: 11
SourcePackage: calamares
StacktraceTop:
 KPMHelpers::isPartitionNew(Partition*) () from /usr/lib/x86_64-linux-gnu/calamares/modules/partition/libcalamares_viewmodule_partition.so
 PartitionPage::onEditClicked() () from /usr/lib/x86_64-linux-gnu/calamares/modules/partition/libcalamares_viewmodule_partition.so
 QMetaObject::activate(QObject*, int, int, void**) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
 QAbstractButton::clicked(bool) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 ?? () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
Title: calamares crashed with SIGSEGV in KPMHelpers::isPartitionNew()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups:

separator:

----

Lubuntu 19.04 Manual Partitioning Install
Daily Image : 20190326.1

On selecting a pre-existing partition, I have the option of 'keep' or 'format'. I'm trying to 'format' my / partition so I select format. I'm happy with settings (have selected / as mount point, 'format' & 'boot' as option) so I exit to select next partition (say my /home).

I however decide to go back & check my / partition which should be 'format', but when I re-enter it, I find it's set to 'keep'. I've tried this many times (only today's ISO) and have discovered the same nearly each time. It could be it flips to 'keep' whenever you enter; but given I've set it to 'format' I'd expect it to say 'format'.

I was exploring this when I had the crash that caused this bug report, but have since rebooted and the 'format' is being flipped to 'keep' I'm convinced (though if you enter many times, it seems to stop flipping??)

[Apport retracing service (apport)]

StacktraceTop:
 KPMHelpers::isPartitionNew (partition=0x0) at /usr/include/kpmcore/core/partition.h:187
 PartitionPage::onEditClicked (this=0x7f9b64024480) at ./src/modules/partition/gui/PartitionPage.cpp:403
 QtPrivate::QSlotObjectBase::call (a=0x7ffea4f2e940, r=0x7f9b64024480, this=0x555da4e63760) at ../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:376
 QMetaObject::activate (sender=0x555da4e4f9d0, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3754
 QAbstractButton::clicked (this=this@entry=0x555da4e4f9d0, _t1=<optimized out>) at .moc/moc_qabstractbutton.cpp:308

[Chris Guiver (guiverc)]

19.04 daily image (20190407) on my dell optiplex 780

i have a full-disk install of 19.04 on this machine from an earlier qa-test; I was trying to look at another lp bug report related to partitioning and the installer crashed on my trying to doa anything with /dev/sda1

sudo fdisk -l shows

Disk /dev/sda: 1.4 TiB, 1500301910016 bytes, 2930277168 sectors
Disk model: WDC WD15EADS-00S
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x41bd7169

Device Boot Start End Sectors Size Id Type
/dev/sda1 2048 2930272064 2930270017 1.4T 83 Linux

[Chris Guiver (guiverc)]

this could be related to https://bugs.launchpad.net/ubuntu/+source/calamares/+bug/1823569

[Chris Guiver (guiverc)]

Walter (wxl) said in https://bugs.launchpad.net/ubuntu/+source/calamares/+bug/1823569
Chris, according to the upstream bug, the issue is actually the fact that no selection is made when an action (either edit or create) is selected, so I don't think that bug is related.
----

When you enter a partition (sda1 in my case today) and exit, your 'chosen' and in my today's case only possible selection has been de-selected, and it's very possible that I'm assuming the partition I selected before (sda1) is still selected and i thus click 'edit' causing the crash defined in the other bug.

As a consequence the actual "calamares crashed with SIGSEGV in PMHelpers::isPartitionNew()" part of this bug report maybe a duplicate; I'll endeavor to test this again in coming days, but for now.. i'll mark it 'invalid'

My discussion on the 'format' flag being flipped to 'keep' is also covered in https://bugs.launchpad.net/ubuntu/+source/calamares/+bug/1773610