Redmine Local Avatars Plugin

Compatibility with 2.1.x

Bug #1069808 reported by Oleg V. Kozlyuk
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Redmine Local Avatars Plugin
New
Undecided
Unassigned

Bug Description

Are there any plans on ensuring compatibility with 2.1.x?

We're using 2.1.3 in the company, and we're trying to make sales departments use it along with IT crowd... So the functionality like this is highly beneficial to "sell" redmine to sales :)

current errors:

Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
Processing by UsersController#edit as HTML
  Parameters: {"id"=>"30"}
  Current user: admin (id=1)
  Rendered users/_mail_notifications.html.erb (12.5ms)
  Rendered users/_preferences.html.erb (412.0ms)
  Rendered users/_form.html.erb (446.3ms)
  Rendered users/_general.html.erb (453.8ms)
  Rendered users/_groups.html.erb (10.5ms)
  Rendered users/_memberships.html.erb (105.9ms)
  Rendered common/_tabs.html.erb (583.8ms)
  Rendered users/edit.html.erb within layouts/admin (599.7ms)
Missing template, responding with 404
  Rendered common/error.html.erb within layouts/base (0.1ms)
Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)

Revision history for this message
Luca Pireddu (pireddu) wrote :

Hi Oleg. Currently I don't have the time to maintain upwards Redmine compatibility.

However, I'll accept patches. Are you a developer?

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote : Re: [Bug 1069808] Re: Compatibility with 2.1.x

Hi, Luca.

Yes, but my Ruby knowledge is close to zero. I'll try to dig in if you give
me a hint, though.

2012/10/22 Luca Pireddu <email address hidden>

> Hi Oleg. Currently I don't have the time to maintain upwards Redmine
> compatibility.
>
> However, I'll accept patches. Are you a developer?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05
> +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: admin (id=1)
> Rendered users/_mail_notifications.html.erb (12.5ms)
> Rendered users/_preferences.html.erb (412.0ms)
> Rendered users/_form.html.erb (446.3ms)
> Rendered users/_general.html.erb (453.8ms)
> Rendered users/_groups.html.erb (10.5ms)
> Rendered users/_memberships.html.erb (105.9ms)
> Rendered common/_tabs.html.erb (583.8ms)
> Rendered users/edit.html.erb within layouts/admin (599.7ms)
> Missing template, responding with 404
> Rendered common/error.html.erb within layouts/base (0.1ms)
> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions
>

Revision history for this message
archonwang (archonwang1981) wrote :

Urrr....

I have the same problem..

my logs as follow:

<pre>
Started GET "/users/1/edit" for 192.168.3.41 at 2012-10-24 11:58:15 +0800
Processing by UsersController#edit as HTML
  Parameters: {"id"=>"1"}
  Current user: admin (id=1)
  Rendered users/_mail_notifications.html.erb (18.0ms)
  Rendered users/_preferences.html.erb (762.8ms)
  Rendered users/_form.html.erb (824.7ms)
  Rendered users/_general.html.erb (841.5ms)
  Rendered users/_memberships.html.erb (15.6ms)
  Rendered common/_tabs.html.erb (905.8ms)
  Rendered users/edit.html.erb within layouts/admin (920.8ms)
Missing template, responding with 404
  Rendered common/error.html.erb within layouts/base (0.8ms)
  Rendered plugins/redmine_cut_tag/app/views/hooks/redmine_cut_tag/_includes.html.erb (0.8ms)
  Rendered plugins/redmine_private_wiki/app/views/hooks/_html_header.html.erb (0.1ms)
  Rendered plugins/redmine_favourite_projects/app/views/favourite_projects/_favourite_projects_searchbox_partial.html.erb (0.1ms)
  Rendered plugins/redmine_favourite_projects/app/views/favourite_projects/_update_menu.erb (0.1ms)
  Rendered plugins/redmine_private_wiki/app/views/hooks/_body_bottom.html.erb (0.1ms)
Completed 404 Not Found in 1105ms (Views: 86.0ms | ActiveRecord: 6.4ms)

</pre>

Revision history for this message
Chris Luke (chrisy) wrote :

This patch seems to fix the plugin for rm 2.1.x. Fixes the naming of the two templates, and makes my/avatar a full page rather than a partial (there was no parent page for it to be a partial of):

=== renamed file 'app/views/hooks/redmine_local_avatars/_view_my_account_contextual.erb.html' => 'app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb'
=== added directory 'app/views/my'
=== renamed file 'app/views/users/_avatar.erb.html' => 'app/views/my/avatar.html.erb'
--- app/views/users/_avatar.erb.html 2012-08-13 15:03:33 +0000
+++ app/views/my/avatar.html.erb 2012-10-24 19:09:00 +0000
@@ -1,11 +1,17 @@
 <div class="box">
-<h3><%= l(:label_avatar)%></h3>
+
+<h2><%= l(:label_avatar)%></h2>
+
 <div style="width: 128px; height: 128px; border: 1px silver solid;">
 <%= avatar(@user, :size => "128") %>
 </div><br>
-<%= form_tag( { :action => 'save_avatar', :id => @user }, :multipart => true) do %>
+
+<%= form_tag( { :action => 'save_avatar', :id => @user.id }, :multipart => true) do %>
     <%= file_field_tag "avatar" %><br />
     <%= submit_tag l(:button_save) %>
   <%= submit_tag l(:button_delete), :confirm => l(:are_you_sure_delete_avatar) %>
 <% end %>
+
 </div>
+
+<% html_title(l(:label_avatar)) -%>

=== removed directory 'app/views/users'
=== modified file 'lib/my_controller_patch.rb'
--- lib/my_controller_patch.rb 2010-12-26 04:26:55 +0000
+++ lib/my_controller_patch.rb 2012-10-24 19:03:39 +0000
@@ -31,7 +31,6 @@

   def avatar
    @user = User.current
- render :partial => 'users/avatar', :layout => true
   end

   def save_avatar

Revision history for this message
Chris Luke (chrisy) wrote :
Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :

Thank you, Chris!

Unfortunately, that didn't cut it for me.
[root@redmine-test redminelocalavatars]# patch -p0<rm21x-avatar.patch
patching file app/views/users/_avatar.erb.html
patching file lib/my_controller_patch.rb

Results: still 404 (http://pastebin.com/tmP2KsUU)

Fixes with erb.html -> html.erb are nice pick, regardless. Maybe there is something else?

Revision history for this message
cforce (cforce) wrote :

Is it solved now?

Revision history for this message
André Radke (radke) wrote :

Oleg, I ran into the same problems you did and I think I have figured out a solution:

The GET on /my/account appears to fail if your plugin directory is named anything other than "redmine_local_avatars" (note the underscores!). Otherwise, the code that hooks the "Change local avatar" link into /my/account fails to locate the template. I'm not sure of the exact mechanics, but renaming my plugin directory and restarting my webserver fixed this for me.

The page for editing users fails because it expects a partial template at app/views/users/_avatar.html.erb but Chris's patch explicitly removes that whole directory. I'm going to attach a modified version of Chris's patch. Applying this against revision 28 works for me on Redmine 2.2.1.stable.11175.

I'm new to hacking Ruby on Rails, so I have no idea if my patch is backwards compatible.

HTH, -Andre

=== renamed file 'app/views/hooks/redmine_local_avatars/_view_my_account_contextual.erb.html' => 'app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb'
=== added directory 'app/views/my'
=== added file 'app/views/my/avatar.html.erb'
--- app/views/my/avatar.html.erb 1970-01-01 00:00:00 +0000
+++ app/views/my/avatar.html.erb 2013-01-12 23:29:51 +0000
@@ -0,0 +1,13 @@
+<div class="box">
+<h2><%= l(:label_avatar)%></h2>
+<div style="width: 128px; height: 128px; border: 1px silver solid;">
+<%= avatar(@user, :size => "128") %>
+</div><br>
+<%= form_tag( { :action => 'save_avatar', :id => @user.id }, :multipart => true) do %>
+ <%= file_field_tag "avatar" %><br />
+ <%= submit_tag l(:button_save) %>
+ <%= submit_tag l(:button_delete), :confirm => l(:are_you_sure_delete_avatar) %>
+<% end %>
+</div>
+
+<% html_title(l(:label_avatar) + " - " + l(:label_my_account)) -%>

=== renamed file 'app/views/users/_avatar.erb.html' => 'app/views/users/_avatar.html.erb'
=== modified file 'lib/my_controller_patch.rb'
--- lib/my_controller_patch.rb 2010-12-26 04:26:55 +0000
+++ lib/my_controller_patch.rb 2013-01-12 23:14:58 +0000
@@ -31,7 +31,7 @@

   def avatar
    @user = User.current
- render :partial => 'users/avatar', :layout => true
+# render :partial => 'users/avatar', :layout => true
   end

   def save_avatar

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :

Hi, Andre.
Your patch does fix the /users/X view and /my/page view, however, when opening my/account page, I am still presented with 404.

Upon applying your patch, the patch utility says it is unable to locate lib/my_controller_patch.rb file (strangely, as it is present). When asked which file to patch, I input lib/my_controller_patch.rb manually, and the patch proceeds - don't know if it is correct, though.
Could you please send me your whole plugin folder, to see if it works for me?

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :

Current log message:

Started GET "/my/account" for 172.16.9.84 at 2013-01-14 17:21:29 +0400
Processing by MyController#account as HTML
  Current user: o.kozlyuk (id=4)
  Rendered my/account.html.erb within layouts/base (7.0ms)
Missing template, responding with 404
  Rendered common/error.html.erb within layouts/base (0.2ms)
  Rendered inline template (1.1ms)
Completed 404 Not Found in 50ms (Views: 29.8ms | ActiveRecord: 2.1ms)

Revision history for this message
André Radke (radke) wrote :

I created my patch with "bzr diff". I'm not sure if the patch utility will handle the file renaming properly. Anyway, here's what the file hierarchy should look like after applying my patch:

redmine_local_avatars/README.rd
redmine_local_avatars/app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb
redmine_local_avatars/app/views/my/avatar.html.erb
redmine_local_avatars/app/views/users/_avatar.html.erb
redmine_local_avatars/config/routes.rb
redmine_local_avatars/config/locales/bg.yml
redmine_local_avatars/config/locales/de.yml
redmine_local_avatars/config/locales/en.yml
redmine_local_avatars/config/locales/es.yml
redmine_local_avatars/config/locales/fr.yml
redmine_local_avatars/config/locales/it.yml
redmine_local_avatars/config/locales/pt-BR.yml
redmine_local_avatars/config/locales/ru.yml
redmine_local_avatars/config/locales/zh-TW.yml
redmine_local_avatars/config/locales/zh.yml
redmine_local_avatars/init.rb
redmine_local_avatars/lib/account_controller_patch.rb
redmine_local_avatars/lib/application_helper_avatar_patch.rb
redmine_local_avatars/lib/local_avatars.rb
redmine_local_avatars/lib/my_controller_patch.rb
redmine_local_avatars/lib/redmine_local_avatars/hooks.rb
redmine_local_avatars/lib/users_avatar_patch.rb
redmine_local_avatars/lib/users_controller_patch.rb
redmine_local_avatars/lib/users_helper_avatar_patch.rb

It's apparently important to get the leading underscores right in app/views...

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :
Download full text (3.3 KiB)

Hi,

unfortunately, leading underscores were not the problem here... I've
tried them in all combination (_avatar.html.erb, avatar.html.erb,
_avatar.erb.html, etc.)

Your version is working, however, many thanks!!!
I'll compare the file structure later today - need to figure out how
to correctly use "patch" myself. However, the version looks good.
Maybe you can send a "pull request" to Luca Pireddu with your changes?

2013/1/15 André Radke <email address hidden>:
> I created my patch with "bzr diff". I'm not sure if the patch utility
> will handle the file renaming properly. Anyway, here's what the file
> hierarchy should look like after applying my patch:
>
> redmine_local_avatars/README.rd
> redmine_local_avatars/app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb
> redmine_local_avatars/app/views/my/avatar.html.erb
> redmine_local_avatars/app/views/users/_avatar.html.erb
> redmine_local_avatars/config/routes.rb
> redmine_local_avatars/config/locales/bg.yml
> redmine_local_avatars/config/locales/de.yml
> redmine_local_avatars/config/locales/en.yml
> redmine_local_avatars/config/locales/es.yml
> redmine_local_avatars/config/locales/fr.yml
> redmine_local_avatars/config/locales/it.yml
> redmine_local_avatars/config/locales/pt-BR.yml
> redmine_local_avatars/config/locales/ru.yml
> redmine_local_avatars/config/locales/zh-TW.yml
> redmine_local_avatars/config/locales/zh.yml
> redmine_local_avatars/init.rb
> redmine_local_avatars/lib/account_controller_patch.rb
> redmine_local_avatars/lib/application_helper_avatar_patch.rb
> redmine_local_avatars/lib/local_avatars.rb
> redmine_local_avatars/lib/my_controller_patch.rb
> redmine_local_avatars/lib/redmine_local_avatars/hooks.rb
> redmine_local_avatars/lib/users_avatar_patch.rb
> redmine_local_avatars/lib/users_controller_patch.rb
> redmine_local_avatars/lib/users_helper_avatar_patch.rb
>
> It's apparently important to get the leading underscores right in
> app/views...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: admin (id=1)
> Rendered users/_mail_notifications.html.erb (12.5ms)
> Rendered users/_preferences.html.erb (412.0ms)
> Rendered users/_form.html.erb (446.3ms)
> Rendered users/_general.html.erb (453.8ms)
> Rendered users/_groups.html.erb (10.5ms)
> Rendered users/_memberships.html.erb (105.9ms)
> Rendered common/_tabs.html.erb (583.8ms)
> Rendered users/edit.html.erb within layouts/admin (599.7ms)
> Missing template, responding with 404
> Rendered common/error.html.erb wit...

Read more...

Revision history for this message
André Radke (radke) wrote :
Download full text (5.3 KiB)

Hi Oleg,

I already tried to generate a "pull request" for the version control system at launchpad.net but I have never used the bzr client before and thus failed. Now that you have confirmed that my version works for you, I might give it another go...

André

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Oleg V. Kozlyuk
Sent: Dienstag, 15. Januar 2013 09:17
To: André Radke
Subject: Re: [Bug 1069808] Re: Compatibility with 2.1.x

Hi,

unfortunately, leading underscores were not the problem here... I've
tried them in all combination (_avatar.html.erb, avatar.html.erb,
_avatar.erb.html, etc.)

Your version is working, however, many thanks!!!
I'll compare the file structure later today - need to figure out how
to correctly use "patch" myself. However, the version looks good.
Maybe you can send a "pull request" to Luca Pireddu with your changes?

2013/1/15 André Radke <email address hidden>:
> I created my patch with "bzr diff". I'm not sure if the patch utility
> will handle the file renaming properly. Anyway, here's what the file
> hierarchy should look like after applying my patch:
>
> redmine_local_avatars/README.rd
> redmine_local_avatars/app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb
> redmine_local_avatars/app/views/my/avatar.html.erb
> redmine_local_avatars/app/views/users/_avatar.html.erb
> redmine_local_avatars/config/routes.rb
> redmine_local_avatars/config/locales/bg.yml
> redmine_local_avatars/config/locales/de.yml
> redmine_local_avatars/config/locales/en.yml
> redmine_local_avatars/config/locales/es.yml
> redmine_local_avatars/config/locales/fr.yml
> redmine_local_avatars/config/locales/it.yml
> redmine_local_avatars/config/locales/pt-BR.yml
> redmine_local_avatars/config/locales/ru.yml
> redmine_local_avatars/config/locales/zh-TW.yml
> redmine_local_avatars/config/locales/zh.yml
> redmine_local_avatars/init.rb
> redmine_local_avatars/lib/account_controller_patch.rb
> redmine_local_avatars/lib/application_helper_avatar_patch.rb
> redmine_local_avatars/lib/local_avatars.rb
> redmine_local_avatars/lib/my_controller_patch.rb
> redmine_local_avatars/lib/redmine_local_avatars/hooks.rb
> redmine_local_avatars/lib/users_avatar_patch.rb
> redmine_local_avatars/lib/users_controller_patch.rb
> redmine_local_avatars/lib/users_helper_avatar_patch.rb
>
> It's apparently important to get the leading underscores right in
> app/views...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
> Processing by UsersController#edit as HTM...

Read more...

Revision history for this message
Luca Pireddu (pireddu) wrote :
Download full text (7.2 KiB)

Hi André,

I quietly monitor the progress you guys are making :-)

If you send me a patch I'll apply it for you.

Luca

ps: if someone's interested in maintaining this project, I'd be happy to
add you to the developers with commit access.

On 15 January 2013 11:58, André Radke <email address hidden> wrote:

> Hi Oleg,
>
> I already tried to generate a "pull request" for the version control
> system at launchpad.net but I have never used the bzr client before and
> thus failed. Now that you have confirmed that my version works for you,
> I might give it another go...
>
> André
>
>
> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf Of
> Oleg V. Kozlyuk
> Sent: Dienstag, 15. Januar 2013 09:17
> To: André Radke
> Subject: Re: [Bug 1069808] Re: Compatibility with 2.1.x
>
> Hi,
>
> unfortunately, leading underscores were not the problem here... I've
> tried them in all combination (_avatar.html.erb, avatar.html.erb,
> _avatar.erb.html, etc.)
>
> Your version is working, however, many thanks!!!
> I'll compare the file structure later today - need to figure out how
> to correctly use "patch" myself. However, the version looks good.
> Maybe you can send a "pull request" to Luca Pireddu with your changes?
>
> 2013/1/15 André Radke <email address hidden>:
> > I created my patch with "bzr diff". I'm not sure if the patch utility
> > will handle the file renaming properly. Anyway, here's what the file
> > hierarchy should look like after applying my patch:
> >
> > redmine_local_avatars/README.rd
> >
> redmine_local_avatars/app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb
> > redmine_local_avatars/app/views/my/avatar.html.erb
> > redmine_local_avatars/app/views/users/_avatar.html.erb
> > redmine_local_avatars/config/routes.rb
> > redmine_local_avatars/config/locales/bg.yml
> > redmine_local_avatars/config/locales/de.yml
> > redmine_local_avatars/config/locales/en.yml
> > redmine_local_avatars/config/locales/es.yml
> > redmine_local_avatars/config/locales/fr.yml
> > redmine_local_avatars/config/locales/it.yml
> > redmine_local_avatars/config/locales/pt-BR.yml
> > redmine_local_avatars/config/locales/ru.yml
> > redmine_local_avatars/config/locales/zh-TW.yml
> > redmine_local_avatars/config/locales/zh.yml
> > redmine_local_avatars/init.rb
> > redmine_local_avatars/lib/account_controller_patch.rb
> > redmine_local_avatars/lib/application_helper_avatar_patch.rb
> > redmine_local_avatars/lib/local_avatars.rb
> > redmine_local_avatars/lib/my_controller_patch.rb
> > redmine_local_avatars/lib/redmine_local_avatars/hooks.rb
> > redmine_local_avatars/lib/users_avatar_patch.rb
> > redmine_local_avatars/lib/users_controller_patch.rb
> > redmine_local_avatars/lib/users_helper_avatar_patch.rb
> >
> > It's apparently important to get the leading underscores right in
> > app/views...
> >
> > --
> > You received this bug notification because you are subscribed to the bug
> > report.
> > https://bugs.launchpad.net/bugs/1069808
> >
> > Title:
> > Compatibility with 2.1.x
> >
> > Status in Redmine Local Avatars Plugin:
> > New
> >
> > Bug description:
> > Are there any plans on ensuring compatibil...

Read more...

Revision history for this message
André Radke (radke) wrote :

Luca: The patch I posted in comment #8 above is still current to the best of my knowledge. I just haven't figured out yet how to apply that patch file to an unmodified checkout of revision 28 in a way that will also perform the file renames listed in the patch. If you know how to do that, you should be good to go...

Revision history for this message
cforce (cforce) wrote :

Hi guys, don't wanna discourage you, but there alreasy is a local avatar plugin which runs on redmine 2.2.1, and its pretty the same you do here.

https://github.com/thorin/redmine_local_avatars.git

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :

Hi again, guys

I've tried to make a patch for the differences between the latest Launchpad version and Andre's version, but there seems to be too much differences like renaming .html.erb into .erb.html.
The diff utility doesn't handle it well - it shows such changes as one file being deleted, and the other created.

Luca, is it possible to replace the directory altogether and make a commit? I guess, that'd be the easiest way.

Revision history for this message
Luca Pireddu (pireddu) wrote :

Did you rename the files with "bzr mv"?

Bzr should take care of communicating any changes through a patch file,
even file renaming.

Try running
  bzr send -o my.patch
and then mail me the patch file it generates.

Luca

On 18 January 2013 10:11, Oleg V. Kozlyuk <email address hidden> wrote:

> Hi again, guys
>
> I've tried to make a patch for the differences between the latest
> Launchpad version and Andre's version, but there seems to be too much
> differences like renaming .html.erb into .erb.html.
> The diff utility doesn't handle it well - it shows such changes as one
> file being deleted, and the other created.
>
> Luca, is it possible to replace the directory altogether and make a
> commit? I guess, that'd be the easiest way.
>
> --
> You received this bug notification because you are subscribed to Redmine
> Local Avatars Plugin.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05
> +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: admin (id=1)
> Rendered users/_mail_notifications.html.erb (12.5ms)
> Rendered users/_preferences.html.erb (412.0ms)
> Rendered users/_form.html.erb (446.3ms)
> Rendered users/_general.html.erb (453.8ms)
> Rendered users/_groups.html.erb (10.5ms)
> Rendered users/_memberships.html.erb (105.9ms)
> Rendered common/_tabs.html.erb (583.8ms)
> Rendered users/edit.html.erb within layouts/admin (599.7ms)
> Missing template, responding with 404
> Rendered common/error.html.erb within layouts/base (0.1ms)
> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions
>

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote :
Download full text (3.8 KiB)

Negative... I've asked Andre to send me his whole plugin folder, as
his patch wasn't properly renaming and/or changins some files.

2013/1/18 Luca Pireddu <email address hidden>:
> Did you rename the files with "bzr mv"?
>
> Bzr should take care of communicating any changes through a patch file,
> even file renaming.
>
> Try running
> bzr send -o my.patch
> and then mail me the patch file it generates.
>
> Luca
>
>
> On 18 January 2013 10:11, Oleg V. Kozlyuk <email address hidden> wrote:
>
>> Hi again, guys
>>
>> I've tried to make a patch for the differences between the latest
>> Launchpad version and Andre's version, but there seems to be too much
>> differences like renaming .html.erb into .erb.html.
>> The diff utility doesn't handle it well - it shows such changes as one
>> file being deleted, and the other created.
>>
>> Luca, is it possible to replace the directory altogether and make a
>> commit? I guess, that'd be the easiest way.
>>
>> --
>> You received this bug notification because you are subscribed to Redmine
>> Local Avatars Plugin.
>> https://bugs.launchpad.net/bugs/1069808
>>
>> Title:
>> Compatibility with 2.1.x
>>
>> Status in Redmine Local Avatars Plugin:
>> New
>>
>> Bug description:
>> Are there any plans on ensuring compatibility with 2.1.x?
>>
>> We're using 2.1.3 in the company, and we're trying to make sales
>> departments use it along with IT crowd... So the functionality like
>> this is highly beneficial to "sell" redmine to sales :)
>>
>> current errors:
>>
>> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05
>> +0400 2012
>> Processing by UsersController#edit as HTML
>> Parameters: {"id"=>"30"}
>> Current user: admin (id=1)
>> Rendered users/_mail_notifications.html.erb (12.5ms)
>> Rendered users/_preferences.html.erb (412.0ms)
>> Rendered users/_form.html.erb (446.3ms)
>> Rendered users/_general.html.erb (453.8ms)
>> Rendered users/_groups.html.erb (10.5ms)
>> Rendered users/_memberships.html.erb (105.9ms)
>> Rendered common/_tabs.html.erb (583.8ms)
>> Rendered users/edit.html.erb within layouts/admin (599.7ms)
>> Missing template, responding with 404
>> Rendered common/error.html.erb within layouts/base (0.1ms)
>> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions
>>
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: a...

Read more...

Revision history for this message
André Radke (radke) wrote :

Luca: I think I finally figured out how to generate the patch with bzr so that it also performs the file renames, see attached file.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.